[PR #24] [MERGED] Added NSCoding to OAuthSwiftCredential for easy storage in the Keychain. #487

New issue

Closed

opened 2026-03-03 16:49:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/24
Author: @harlanhaskins
Created: 1/28/2015
Status: ✅ Merged
Merged: 1/29/2015
Merged by: @dongri

Base: master ← Head: master

📝 Commits (2)

f4bf20b Added NSCoding to OAuthSwiftCredential for easy storage in the Keychain.
aba84bf Changed base to use the CFBundleIdentifier.

📊 Changes

1 file changed (+31 additions, -2 deletions)

View changed files

📝 OAuthSwift/OAuthSwiftCredential.swift (+31 -2)

📄 Description

SwiftKeychainWrapper, and other such keychain wrappers, allow for easily storing an retrieving NSCoding-compatible objects in the keychain. OAuthSwiftCredential could benefit from some NSCoding love.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/24 **Author:** [@harlanhaskins](https://github.com/harlanhaskins) **Created:** 1/28/2015 **Status:** ✅ Merged **Merged:** 1/29/2015 **Merged by:** [@dongri](https://github.com/dongri) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`f4bf20b`](https://github.com/OAuthSwift/OAuthSwift/commit/f4bf20ba8c0c0cd4b10c3a7d5b98312088861d58) Added NSCoding to OAuthSwiftCredential for easy storage in the Keychain. - [`aba84bf`](https://github.com/OAuthSwift/OAuthSwift/commit/aba84bffedef2b0f11d6ad54b78a1c46508165de) Changed base to use the CFBundleIdentifier. ### 📊 Changes **1 file changed** (+31 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuthSwiftCredential.swift` (+31 -2) </details> ### 📄 Description [SwiftKeychainWrapper](https://github.com/jrendel/SwiftKeychainWrapper), and other such keychain wrappers, allow for easily storing an retrieving `NSCoding`-compatible objects in the keychain. `OAuthSwiftCredential` could benefit from some `NSCoding` love. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>