[GH-ISSUE #644] Allow customization of OAuth1 authorize url params #422

Closed
opened 2026-03-03 16:48:33 +03:00 by kerem · 1 comment
Owner

Originally created by @daironmichel on GitHub (Feb 11, 2021).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/644

Description:

By default OAuth1Swift.authorize() function generates an authorize url with params ?oath_token=oauthRequestToken.
However ETrade's authorize url params must be ?key=consumerKey&token=oauthRequestToken or the authorization will fail.

OAuth Provider? (Twitter, Github, ..):

ETrade (https://api.etrade.com)

OAuth Version:

  • Version 1
  • Version 2

OS (Please fill the version) :

  • iOS :
  • OSX :
  • TVOS :
  • WatchOS :

Installation method:

  • Carthage
  • CocoaPods
  • Swift Package Manager
  • Manually

Library version:

  • head
  • v2.1.0
  • v2.0.0
  • v1.4.1
  • other: (Please fill in the version you are using.)

Xcode version:

  • 11.4 (Swift 5.2)

  • 11.x (Swift 5.1)

  • 10.x (Swift 5.0)

  • other: (Please fill in the version you are using.)

  • objective c

Originally created by @daironmichel on GitHub (Feb 11, 2021). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/644 ### Description: By default OAuth1Swift.authorize() function generates an authorize url with params `?oath_token=oauthRequestToken`. However ETrade's authorize url params must be `?key=consumerKey&token=oauthRequestToken` or the authorization will fail. ### OAuth Provider? (Twitter, Github, ..): ETrade (https://api.etrade.com) ### OAuth Version: - [x] Version 1 - [ ] Version 2 ### OS (Please fill the version) : - [x] iOS : - [ ] OSX : - [ ] TVOS : - [ ] WatchOS : ### Installation method: - [ ] Carthage - [ ] CocoaPods - [x] Swift Package Manager - [ ] Manually ### Library version: - [x] head - [ ] v2.1.0 - [ ] v2.0.0 - [ ] v1.4.1 - [ ] other: (Please fill in the version you are using.) ### Xcode version: - [x] 11.4 (Swift 5.2) - [ ] 11.x (Swift 5.1) - [ ] 10.x (Swift 5.0) - [ ] other: (Please fill in the version you are using.) - [ ] objective c
kerem closed this issue 2026-03-03 16:48:33 +03:00
Author
Owner

@phimage commented on GitHub (Feb 18, 2021):

you could provide a PR with a boolean to configure like that

for instance there is here some
https://github.com/OAuthSwift/OAuthSwift/blob/master/Sources/OAuth1Swift.swift#L15

<!-- gh-comment-id:781504724 --> @phimage commented on GitHub (Feb 18, 2021): you could provide a PR with a boolean to configure like that for instance there is here some https://github.com/OAuthSwift/OAuthSwift/blob/master/Sources/OAuth1Swift.swift#L15
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#422
No description provided.