[GH-ISSUE #635] Adding timeout interval to "makeRequest" methods

kerem commented

2026-03-03 16:48:30 +03:00

Owner

Copy link

Originally created by @rentateam-mashatrubina on GitHub (Nov 23, 2020).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/635

Description:

Hi!

Could you please add the possibility to set timeout interval right inside one of the makeRequest methods?
For now it can be done in OAuthSwiftClient.makeRequest(_: URLRequest) only, as I may see. I find this not that convenient as I need to do some preparations to URLRequest instance before passing it to makeRequest (add parameters, httpMethod and so on). While all of that could be easily done with makeRequest method, if it could accept time interval parameter as well.

P.S. Thank you very much for your work! Your framework saves me tons of hours!

OAuth Provider? (Twitter, Github, ..):

Auth using grant type "password"

OAuth Version:

Version 1
Version 2

OS (Please fill the version) :

iOS :
OSX :
TVOS :
WatchOS :

Installation method:

Carthage
CocoaPods
Swift Package Manager
Manually

Library version:

head
v2.1.0
v2.0.0
v1.4.1
other: (Please fill in the version you are using.)

Originally created by @rentateam-mashatrubina on GitHub (Nov 23, 2020). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/635 ### Description: Hi! Could you please add the possibility to set **timeout interval** right inside one of the `makeRequest` methods? For now it can be done in `OAuthSwiftClient.makeRequest(_: URLRequest)` only, as I may see. I find this not that convenient as I need to do some preparations to `URLRequest` instance before passing it to `makeRequest` (add parameters, httpMethod and so on). While all of that could be easily done with `makeRequest` method, if it could accept time interval parameter as well. P.S. Thank you very much for your work! Your framework saves me tons of hours! ### OAuth Provider? (Twitter, Github, ..): Auth using grant type "password" ### OAuth Version: - [ ] Version 1 - [x] Version 2 ### OS (Please fill the version) : - [x] iOS : - [ ] OSX : - [ ] TVOS : - [ ] WatchOS : ### Installation method: - [ ] Carthage - [x] CocoaPods - [ ] Swift Package Manager - [ ] Manually ### Library version: - [ ] head - [x] v2.1.0 - [ ] v2.0.0 - [ ] v1.4.1 - [ ] other: (Please fill in the version you are using.)

kerem closed this issue

2026-03-03 16:48:30 +03:00

kerem commented

2026-03-03 16:48:31 +03:00

Author

Owner

Copy link

@phimage commented on GitHub (Apr 29, 2021):

timeout is generally managed by session manager, there is URLSessionFactory and the configuration to create the session

@phimage commented on GitHub (Apr 29, 2021): timeout is generally managed by session manager, there is `URLSessionFactory` and the configuration to create the session

No Branch/Tag specified