mirror of
https://github.com/OAuthSwift/OAuthSwift.git
synced 2026-04-26 20:55:57 +03:00
[GH-ISSUE #591] tvOS project & @available attributes errors #383
Labels
No labels
bug
cocoapod
duplicate
enhancement
feature-request
help wanted
help wanted
invalid
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/OAuthSwift#383
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @max1mvs on GitHub (Apr 30, 2020).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/591
Description:
Building a blank tvOS project renders several issues regarding
@availableattributes referring to code that is only supported in tvOS 13.0 or newer:OAuthSwiftOpenURLExternally.swift, line 28:
String+OAuthSwift.swift, line 58-62:
UIApplication+OAuthSwift.swift
Line 22 + 27:
Line 23:
Also, I get three warnings on
saying:
OAuth Provider? (Twitter, Github, ..):
N/A
OAuth Version:
OS (Please fill the version) :
Installation method:
Library version:
Xcode version:
11.x (Swift 5.1)
10.x (Swift 5.0)
10.x (Swift 4.1)
9.3 (Swift 4.1)
9.0 (Swift 4.0)
other: (Please fill in the version you are using.)
objective c
@phimage commented on GitHub (Apr 30, 2020):
The minimum version is not very well specified. Even for iOS, I will do not take much time to make it compatible for version lower than 13.0
I update the code for instance with scanUpToString to fix Xcode warnings and use new api
So maybe an old version could work (or not if not tested by anybody)
@phimage commented on GitHub (Apr 30, 2020):
I update the head code and add where it is possible tvOS version checking
It seems to compile with tvOS 9
@max1mvs let me know if it works and close the issue , thanks in advance
If I can I will add into CI some other OS version
@max1mvs commented on GitHub (Apr 30, 2020):
I don't seem to see the changes in version 2.1.1..? Sorry for being a bit of a nuisance here, but I'm fairly new to all things Github, so I might have missed something here… 😅
@max1mvs commented on GitHub (May 1, 2020):
Ok, figured out how to implement the latest build. All errors are gone now. Thank you!