starred/OAuthSwift

Fork 0

mirror of https://github.com/OAuthSwift/OAuthSwift.git synced 2026-04-26 12:45:52 +03:00

oauth2 library #352

New issue

Closed

opened 2026-03-03 16:47:59 +03:00 by kerem · 8 comments

kerem commented

2026-03-03 16:47:59 +03:00

Owner

Originally created by @iam-manikandan on GitHub (Jul 9, 2019).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/534

Feature request

1 ) Is this library have any logging solution like p2/oauth2 library?
2) Please make client secret as optional in oauth2swift class because some of oauth2 provider doesn't need client secret in the request.

Please concentrate on logging the request/response details, that will be really good. Thanks

Originally created by @iam-manikandan on GitHub (Jul 9, 2019). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/534 **Feature request** 1 ) Is this library have any logging solution like p2/oauth2 library? 2) Please make client secret as optional in oauth2swift class because some of oauth2 provider doesn't need client secret in the request. Please concentrate on logging the request/response details, that will be really good. Thanks

kerem closed this issue

2026-03-03 16:47:59 +03:00

kerem commented

2026-03-03 16:48:00 +03:00

Author

Owner

@phimage commented on GitHub (Jul 9, 2019):

1/ I will not study another library, please describe the eventual missing feature
2/ There is a github template for issue. This is important to not loose time. Here I need to ask a question that is already asked.. the oauth provider?

@phimage commented on GitHub (Jul 9, 2019): 1/ I will not study another library, please describe the eventual missing feature 2/ There is a github template for issue. This is important to not loose time. Here I need to ask a question that is already asked.. the oauth provider?

kerem commented

2026-03-03 16:48:00 +03:00

Author

Owner

@iam-manikandan commented on GitHub (Jul 9, 2019):

I have been working on integrating the cloud storages (drive,box,dropbox) in my app, for that I have went through libraries that handle all accounts authentication and authorization and I have found yours and p2/oauth2. Initially I have chosen yours for my app but really tedious to find what's happening in the request/response flow and debug the errors. p2/oauth2 has logging property, so we can enable/disable the logging.
Google drive doesn't need client secret for authorize and getting access token, thats what i asked to make that client secret parameter as optional.

Sorry for mentioning other libraries here, I have just saying what I felt.

@iam-manikandan commented on GitHub (Jul 9, 2019): 1) I have been working on integrating the cloud storages (drive,box,dropbox) in my app, for that I have went through libraries that handle all accounts authentication and authorization and I have found yours and p2/oauth2. Initially I have chosen yours for my app but really tedious to find what's happening in the request/response flow and debug the errors. p2/oauth2 has logging property, so we can enable/disable the logging. 2) Google drive doesn't need client secret for authorize and getting access token, thats what i asked to make that client secret parameter as optional. Sorry for mentioning other libraries here, I have just saying what I felt.

kerem commented

2026-03-03 16:48:00 +03:00

Author

Owner

@slizeray commented on GitHub (Jul 9, 2019):

you can use an empty string for the client secret...I agree nil would be better though....But an empty string works fine.

@slizeray commented on GitHub (Jul 9, 2019): you can use an empty string for the client secret...I agree nil would be better though....But an empty string works fine.

kerem commented

2026-03-03 16:48:00 +03:00

Author

Owner

@iam-manikandan commented on GitHub (Jul 9, 2019):

Yes I tried empty string,but I had some issue. Will try again and let you know. Thanks

@iam-manikandan commented on GitHub (Jul 9, 2019): Yes I tried empty string,but I had some issue. Will try again and let you know. Thanks

kerem commented

2026-03-03 16:48:00 +03:00

Author

Owner

@slizeray commented on GitHub (Jul 9, 2019):

FYI, I integrate with Google Drive using OAuthSwift....

@slizeray commented on GitHub (Jul 9, 2019): FYI, I integrate with Google Drive using OAuthSwift....

kerem commented

2026-03-03 16:48:01 +03:00

Author

Owner

@svoip commented on GitHub (Apr 10, 2020):

I agree with the thread author on having a logging solution for this library would be great.
For example, under a logging flag, the library adds more print statements, in all or most of the flows (be it a presentation/dismiss of Safari, or network request or encoding, etc).
Can I participate in adding such a feature?

@svoip commented on GitHub (Apr 10, 2020): I agree with the thread author on having a logging solution for this library would be great. For example, under a logging flag, the library adds more print statements, in all or most of the flows (be it a presentation/dismiss of Safari, or network request or encoding, etc). Can I participate in adding such a feature?

kerem commented

2026-03-03 16:48:01 +03:00

Author

Owner

@phimage commented on GitHub (Apr 10, 2020):

@svoip yes you can PR

instead of printing directly, better implementation will be to have a protocol to log, replacable with debug, error, warning log level

@phimage commented on GitHub (Apr 10, 2020): @svoip yes you can PR instead of printing directly, better implementation will be to have a protocol to log, replacable with debug, error, warning log level

kerem commented

2026-03-03 16:48:01 +03:00

Author

Owner

@svoip commented on GitHub (Apr 22, 2020):

@phimage I have created pull request
https://github.com/OAuthSwift/OAuthSwift/pull/586
Could you review it please?

@svoip commented on GitHub (Apr 22, 2020): @phimage I have created pull request https://github.com/OAuthSwift/OAuthSwift/pull/586 Could you review it please?