mirror of
https://github.com/OAuthSwift/OAuthSwift.git
synced 2026-04-26 12:45:52 +03:00
[GH-ISSUE #501] Does OAuthSwift support the Authorization code with proof key flow? I am not seeing where we can send a code challenge. #330
Labels
No labels
bug
cocoapod
duplicate
enhancement
feature-request
help wanted
help wanted
invalid
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/OAuthSwift#330
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @scottblomquistjr on GitHub (Dec 12, 2018).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/501
Description:
I am trying to use this library with Okta Authorization code with proof key flow. However I keep getting an error on my server "code_challenge is missing". Is this flow not supported?
OAuth Provider? (Twitter, Github, ..):
Okta
OAuth Version:
OS (Please fill the version) :
Installation method:
Library version:
Xcode version:
9.3 (Swift 4.1)
9.0 (Swift 4.0)
9.0 (Swift 3.2)
8.x (Swift 3.x)
8.0 (Swift 2.3)
7.3.1
[x ] other: (Please fill in the version you are using.)
10 (Swift 4.2)
objective c
@BjoeBrunn commented on GitHub (Jan 4, 2019):
I have the same issue.
There is no way to insert a code_verifier parameter during the second step to get the access token with the code provided in the first step.
As a quick workaround I inserted a new variable codeVerifier in the OAuth2Swift code, a new initializer and modified the postOAuthAccessTokenWithRequestToken function in order to add this extra parameter as the parameters in the original function are limited to client_id, client_secret, code and grant_type.
This way, authentication with PKCE works.
@phimage commented on GitHub (Jan 7, 2019):
https://tools.ietf.org/html/rfc7636
@BjoeBrunn if you make a fork (or a PR) I will look at it to see the flow
If you know other provider which use that. I see Okta, Salesforce
@mraible commented on GitHub (Feb 3, 2019):
@BjoeBrunn I’d love to see your code too. I’m trying to make an Ionic 4 app work with Okta using https://github.com/moberwasserlechner/capacitor-oauth2 (which uses this library).
@BjoeBrunn commented on GitHub (Feb 3, 2019):
Hi Matt,
This is a sketch, how to use the proof key flow :
I hope this helps,
Regards,
Björn
@phimage commented on GitHub (Feb 4, 2019):
readme edited by #510
implementation done by #506
I close
If any issue, feel free to open a new github issue
@moberwasserlechner commented on GitHub (Feb 9, 2019):
Hey,
It would be really appreciated if you create a release with PKCE in Cocoapods.
I develop a library so I have to use a version from cocoapods because other depends on it. For testing I could use the master directly but for a production release it's to risky.
Thanks & BR
@mraible commented on GitHub (Feb 21, 2019):
I agree! A release with this feature would be awesome.
@phimage commented on GitHub (Feb 21, 2019):
🎉 Congrats
🚀 OAuthSwift (1.3.0) successfully published
📅 February 21st
🌎 https://cocoapods.org/pods/OAuthSwift
👍 Tell your friends!