mirror of
https://github.com/OAuthSwift/OAuthSwift.git
synced 2026-04-28 13:45:49 +03:00
[GH-ISSUE #498] Content-Disposition header not valid #329
Labels
No labels
bug
cocoapod
duplicate
enhancement
feature-request
help wanted
help wanted
invalid
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/OAuthSwift#329
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bengsson on GitHub (Nov 23, 2018).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/498
Description:
The Content-Disposition header ends with ";" when creating an OAuthSwiftMultipartData object with the parameter fileName set to nil. This violates the Hypertext Transfer Protocol RFC 6266 section 4.1 (https://tools.ietf.org/html/rfc6266#section-4.1).
When building the contentDispositionString in the append function in OAuthSwiftMultipartData.swift the ";" should not be separating name and filename, it should be a prefix in the filenameClause variable and therefor only be present when it supposed to.
OAuth Provider? (Twitter, Github, ..):
OpenID
OAuth Version:
OS (Please fill the version) :
Installation method:
Library version:
Xcode version:
9.3 (Swift 4.1)
9.0 (Swift 4.0)
9.0 (Swift 3.2)
8.x (Swift 3.x)
8.0 (Swift 2.3)
7.3.1
other: (Please fill in the version you are using.)
objective c
@phimage commented on GitHub (Nov 23, 2018):
thanks, waiting for the PR ;)