[GH-ISSUE #460] OAuthSwift1 tests are failing #303

Closed
opened 2026-03-03 16:47:32 +03:00 by kerem · 0 comments
Owner

Originally created by @aranasaurus on GitHub (May 15, 2018).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/460

Description:

The two tests that are testing to make sure failures don't call their success handlers are failing because they're calling their success handlers. This is happening because the server they're talking to is returning a string and a 200 and the authorize method considers that a success without making sure there's a non-empty token value provided in the response.

OAuth Provider? (Twitter, Github, ..):

OAuth Version:

  • Version 1
  • Version 2

OS (Please fill the version) :

  • iOS :
  • OSX :
  • TVOS :
  • WatchOS :

Installation method:

  • Carthage
  • CocoaPods
  • Manually

Library version:

  • head
  • v1.2.1
  • v1.2 (Swift 4.0)
  • v1.0.0
  • v0.6
  • other: (Please fill in the version you are using.)

Xcode version:

  • 9.3 (Swift 4.1)

  • 9.0 (Swift 4.0)

  • 9.0 (Swift 3.2)

  • 8.x (Swift 3.x)

  • 8.0 (Swift 2.3)

  • 7.3.1

  • other: (Please fill in the version you are using.)

  • objective c

Originally created by @aranasaurus on GitHub (May 15, 2018). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/460 ### Description: The two tests that are testing to make sure failures don't call their success handlers are failing because they're calling their success handlers. This is happening because the server they're talking to is returning a string and a 200 and the `authorize` method considers that a success without making sure there's a non-empty token value provided in the response. ### OAuth Provider? (Twitter, Github, ..): ### OAuth Version: - [x] Version 1 - [ ] Version 2 ### OS (Please fill the version) : - [x] iOS : - [ ] OSX : - [ ] TVOS : - [ ] WatchOS : ### Installation method: - [ ] Carthage - [ ] CocoaPods - [ ] Manually ### Library version: - [x] head - [ ] v1.2.1 - [ ] v1.2 (Swift 4.0) - [ ] v1.0.0 - [ ] v0.6 - [ ] other: (Please fill in the version you are using.) ### Xcode version: - [x] 9.3 (Swift 4.1) - [ ] 9.0 (Swift 4.0) - [ ] 9.0 (Swift 3.2) - [ ] 8.x (Swift 3.x) - [ ] 8.0 (Swift 2.3) - [ ] 7.3.1 - [ ] other: (Please fill in the version you are using.) - [ ] objective c
kerem closed this issue 2026-03-03 16:47:32 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#303
No description provided.