starred/OAuthSwift
1
0
Fork 0
mirror of https://github.com/OAuthSwift/OAuthSwift.git synced 2026-04-26 12:45:52 +03:00
Code Issues 56 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #450] startAuthorizedRequest() fails to refresh the access token on Google Api #292

New issue
Closed
opened 2026-03-03 16:47:27 +03:00 by kerem · 3 comments
kerem commented 2026-03-03 16:47:27 +03:00
Owner
Copy link

Originally created by @mixable on GitHub (Apr 11, 2018).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/450

Description:

I use OAuth2Swift for authentication on Google. After updating from version 1.1.2 to version 1.2.0, requesting an access token is not possible anymore.

To call the Google api, I use startAuthorizedRequest() in the following way. In 1.1.2 this automatically handled the authorization:

let oauthswift = OAuth2Swift(
    consumerKey:    "... .apps.googleusercontent.com",
    consumerSecret: "",
    authorizeUrl:   "https://accounts.google.com/o/oauth2/auth?access_type=offline&prompt=consent",
    accessTokenUrl: "https://accounts.google.com/o/oauth2/token",
    responseType:   "code"
)
oauthswift.client.credential = ...
oauthswift.startAuthorizedRequest(
    "https://www.googleapis.com/gmail/v1/users/me/messages/send",
    method: .POST,
    parameters: [
        "raw": "..."
    ],
    headers: [
        "Content-Type": "application/json",
        "Accept": "application/json"
    ],
    onTokenRenewal: { (credential) in
        // ...
    },
    success: { (response) in
        // ...
    }
) { (error) in
    // ...
}

The problem appears, when the current token expired and a new token is requested using the refresh token (inside the requestOAuthAccessToken() method). The error returned is:

invalid_request: Invalid header Content Type

It turned out, that this is a problem of the header I use. The send API (3) requires "Content-Type: application/json" to work, the access token API (2) does not allow this Content-Type. But the method requestOAuthAccessToken() uses the same header for both requests.

The reason for the same header is line 239 (OAuth2Swift.swift), which was changed from (v1.1.2):

var finalHeaders: OAuthSwift.Headers? = nil

to (v1.2.0):

var finalHeaders: OAuthSwift.Headers? = headers

The code seems to be correct, but I was wondering if anybody else has this problem. Or are there any suggestions, how to deal with this behavior?

OAuth Provider (Twitter, Github, ..):

Google, the API endpoints are:
(1) Authorize Url https://accounts.google.com/o/oauth2/auth?access_type=offline&prompt=consent
(2) Access Token Url: https://accounts.google.com/o/oauth2/token
(3) Send Email API: https://www.googleapis.com/gmail/v1/users/me/messages/send

OAuth Version:

  • Version 1
  • Version 2

OS (Please fill the version) :

  • iOS :
  • OSX :
  • TVOS :
  • WatchOS :

Installation method:

  • Carthage
  • CocoaPods
  • Manually

Library version:

  • head
  • v1.2 (Swift 4.0)
  • v1.0.0
  • [x].6
  • [x]her: (Please fill in the version you are using.)

Xcode version:

  • 9.0 (Swift 4.0)

  • 9.0 (Swift 3.2)

  • 8.x (Swift 3.x)

  • 8.0 (Swift 2.3)

  • 7.3.1

  • other: (Please fill in the version you are using.)

  • objective c

Originally created by @mixable on GitHub (Apr 11, 2018). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/450 ### Description: I use OAuth2Swift for authentication on Google. After updating from version 1.1.2 to version 1.2.0, requesting an access token is not possible anymore. To call the Google api, I use startAuthorizedRequest() in the following way. In 1.1.2 this automatically handled the authorization: let oauthswift = OAuth2Swift( consumerKey: "... .apps.googleusercontent.com", consumerSecret: "", authorizeUrl: "https://accounts.google.com/o/oauth2/auth?access_type=offline&prompt=consent", accessTokenUrl: "https://accounts.google.com/o/oauth2/token", responseType: "code" ) oauthswift.client.credential = ... oauthswift.startAuthorizedRequest( "https://www.googleapis.com/gmail/v1/users/me/messages/send", method: .POST, parameters: [ "raw": "..." ], headers: [ "Content-Type": "application/json", "Accept": "application/json" ], onTokenRenewal: { (credential) in // ... }, success: { (response) in // ... } ) { (error) in // ... } The problem appears, when the current token expired and a new token is requested using the refresh token (inside the requestOAuthAccessToken() method). The error returned is: invalid_request: Invalid header Content Type It turned out, that this is a problem of the header I use. The send API (3) requires "Content-Type: application/json" to work, the access token API (2) does not allow this Content-Type. But the method requestOAuthAccessToken() uses the same header for both requests. The reason for the same header is line 239 (OAuth2Swift.swift), which was changed from (v1.1.2): var finalHeaders: OAuthSwift.Headers? = nil to (v1.2.0): var finalHeaders: OAuthSwift.Headers? = headers The code seems to be correct, but I was wondering if anybody else has this problem. Or are there any suggestions, how to deal with this behavior? ### OAuth Provider (Twitter, Github, ..): Google, the API endpoints are: (1) Authorize Url https://accounts.google.com/o/oauth2/auth?access_type=offline&prompt=consent (2) Access Token Url: https://accounts.google.com/o/oauth2/token (3) Send Email API: https://www.googleapis.com/gmail/v1/users/me/messages/send ### OAuth Version: - [ ] Version 1 - [x] Version 2 ### OS (Please fill the version) : - [x] iOS : - [ ] OSX : - [ ] TVOS : - [ ] WatchOS : ### Installation method: - [ ] Carthage - [x] CocoaPods - [ ] Manually ### Library version: - [ ] head - [x] v1.2 (Swift 4.0) - [ ] v1.0.0 - [ ][x].6 - [ ][x]her: (Please fill in the version you are using.) ### Xcode version: - [x] 9.0 (Swift 4.0) - [ ] 9.0 (Swift 3.2) - [ ] 8.x (Swift 3.x) - [ ] 8.0 (Swift 2.3) - [ ] 7.3.1 - [ ] other: (Please fill in the version you are using.) - [ ] objective c
kerem 2026-03-03 16:47:27 +03:00
  • closed this issue
  • added the
    bug
         label
kerem commented 2026-03-03 16:47:28 +03:00
Author
Owner
Copy link

@phimage commented on GitHub (May 16, 2018):

I think that the fix for 1.2 reveal a real issue
why use request issue for authentication

there is this code in startAuthorizedRequest

            case OAuthSwiftError.tokenExpired:
                _ = self.renewAccessToken(withRefreshToken: self.client.credential.oauthRefreshToken, headers: headers, ...

@mixable maybe removing the header here will fix your issue
and if we want some specific header for renew, it must be another parameter

<!-- gh-comment-id:389402223 --> @phimage commented on GitHub (May 16, 2018): I think that the fix for 1.2 reveal a real issue why use request issue for authentication there is this code in startAuthorizedRequest ```swift case OAuthSwiftError.tokenExpired: _ = self.renewAccessToken(withRefreshToken: self.client.credential.oauthRefreshToken, headers: headers, ... ``` @mixable maybe removing the header here will fix your issue and if we want some specific header for renew, it must be another parameter
kerem commented 2026-03-03 16:47:28 +03:00
Author
Owner
Copy link

@mixable commented on GitHub (Jun 14, 2018):

@phimage yes, using a different parameter for the renew request should fix the problem

<!-- gh-comment-id:397259979 --> @mixable commented on GitHub (Jun 14, 2018): @phimage yes, using a different parameter for the renew request should fix the problem
kerem commented 2026-03-03 16:47:28 +03:00
Author
Owner
Copy link

@phimage commented on GitHub (Jun 25, 2018):

I do want to change the behaviour if some people have provider that need some header so I add a new parameters called renewHeaders

So @mixable you can do

oauthswift.startAuthorizedRequest(
    "https://www.googleapis.com/gmail/v1/users/me/messages/send",
    method: .POST,
    parameters: [
        "raw": "..."
    ],
    headers: [
        "Content-Type": "application/json",
        "Accept": "application/json"
    ],
    renewHeaders: [:], // here a empty header for renew request
    onTokenRenewal: { (credential) in
        // ...
    },
    success: { (response) in
        // ...
    }
) { (error) in
    // ...
}
<!-- gh-comment-id:399885421 --> @phimage commented on GitHub (Jun 25, 2018): I do want to change the behaviour if some people have provider that need some header so I add a new parameters called `renewHeaders` So @mixable you can do ```swift oauthswift.startAuthorizedRequest( "https://www.googleapis.com/gmail/v1/users/me/messages/send", method: .POST, parameters: [ "raw": "..." ], headers: [ "Content-Type": "application/json", "Accept": "application/json" ], renewHeaders: [:], // here a empty header for renew request onTokenRenewal: { (credential) in // ... }, success: { (response) in // ... } ) { (error) in // ... } ```
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
ci/action/danger
ci/action/release-drafter
pkce
ci/action/tvos
ci/travis
2.1.0
2.0.0
fix/fitbiterror
swift3
digu-demo
swift3.0objc
swift2.2
swift2.3
swift2.0
2.2.0
2.1.2
2.1.1
2.1.0
2.0.1
2.0.0
1.4.1
1.4.0
1.3.0
1.2.2
1.2.1
1.2.0
1.1.2
1.1.1
1.1.0
1.0.0
0.6.0
0.5.2
v0.5.2
0.5.1
0.5.0
0.4.8
0.4.6
v0.4.6
0.4.5
v0.4.5
0.4.4
v0.4.4
0.4.3
0.4.2
0.4.1
v0.4.1
0.4.0
v0.4.0
Swift1.x
0.3.7
v0.3.7
0.3.6
v0.3.6
0.3.5
v0.3.5
0.3.4
v0.3.4
0.3.3
v0.3.3
v0.3.2
0.3.2
0.3.1
v0.3.1
0.3.0
v0.3.0
0.2.1
0.2.0
v0.2.0
0.1.9
0.1.8
0.1.7
v0.1.7
v0.1.6
Labels
Clear labels   
bug

   
cocoapod

   
duplicate

   
enhancement

   
feature-request

   
help wanted

   
help wanted

   
invalid

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
wontfix
No labels
bug
cocoapod
duplicate
enhancement
feature-request
help wanted
help wanted
invalid
pull-request
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#292
No description provided.