[GH-ISSUE #420] webViewController Dismiss animation Disable #268

Closed
opened 2026-03-03 16:47:15 +03:00 by kerem · 1 comment
Owner

Originally created by @rakeshgits on GitHub (Nov 20, 2017).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/420

Description:

There is no way to disable the animation while dismissing the webview controller, however there is one to disable it while presenting.

Can be resolved by adding animated parameter in the dismiss webview controller, or adding a globar animation variable like present.

OAuth Provider (Twitter, Github, ..):

OAuth Version:

  • Version 1
  • Version 2

OS (Please fill the version) :

  • iOS :
  • OSX :
  • TVOS :
  • WatchOS :

Installation method:

  • Carthage
  • CocoaPods
  • Manually

Library version:

  • head
  • v1.2 (Swift 4.0)
  • v1.0.0
  • v0.6
  • other: (Please fill in the version you are using.)

Xcode version:

  • 9.0 (Swift 4.0)

  • 9.0 (Swift 3.2)

  • 8.x (Swift 3.x)

  • 8.0 (Swift 2.3)

  • 7.3.1

  • other: (Please fill in the version you are using.)

  • objective c

Originally created by @rakeshgits on GitHub (Nov 20, 2017). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/420 ### Description: There is no way to disable the animation while dismissing the webview controller, however there is one to disable it while presenting. Can be resolved by adding animated parameter in the dismiss webview controller, or adding a globar animation variable like present. ### OAuth Provider (Twitter, Github, ..): ### OAuth Version: - [ ] Version 1 - [x] Version 2 ### OS (Please fill the version) : - [x] iOS : - [ ] OSX : - [ ] TVOS : - [ ] WatchOS : ### Installation method: - [ ] Carthage - [x] CocoaPods - [ ] Manually ### Library version: - [ ] head - [x] v1.2 (Swift 4.0) - [ ] v1.0.0 - [ ] v0.6 - [ ] other: (Please fill in the version you are using.) ### Xcode version: - [x] 9.0 (Swift 4.0) - [ ] 9.0 (Swift 3.2) - [ ] 8.x (Swift 3.x) - [ ] 8.0 (Swift 2.3) - [ ] 7.3.1 - [ ] other: (Please fill in the version you are using.) - [ ] objective c
kerem closed this issue 2026-03-03 16:47:15 +03:00
Author
Owner

@phimage commented on GitHub (Nov 20, 2017):

I add dismissViewControllerAnimated boolean

<!-- gh-comment-id:345625957 --> @phimage commented on GitHub (Nov 20, 2017): I add `dismissViewControllerAnimated` boolean
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#268
No description provided.