[GH-ISSUE #379] Access_token request headers get lost during request creation #242

Closed
opened 2026-03-03 16:46:59 +03:00 by kerem · 1 comment
Owner

Originally created by @ondrejhanak on GitHub (Jun 5, 2017).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/379

Description:

When finalHeaders are constructed in OAuth2Swift.swift on line 225, original headers passed into the method get lost.

What about changing the line like following?

var finalHeaders: OAuthSwift.Headers? = headers

I am happy to submit PR if the solution gets approved.

Originally created by @ondrejhanak on GitHub (Jun 5, 2017). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/379 ### Description: When `finalHeaders` are constructed in `OAuth2Swift.swift` on [line 225](https://github.com/OAuthSwift/OAuthSwift/blob/master/Sources/OAuth2Swift.swift#L225), original headers passed into the method get lost. What about changing the line like following? ``` var finalHeaders: OAuthSwift.Headers? = headers ``` I am happy to submit PR if the solution gets approved.
kerem closed this issue 2026-03-03 16:47:00 +03:00
Author
Owner

@phimage commented on GitHub (Jun 5, 2017):

thanks, yes you can PR

<!-- gh-comment-id:306143418 --> @phimage commented on GitHub (Jun 5, 2017): thanks, yes you can PR
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#242
No description provided.