[GH-ISSUE #316] Missing renewAccessToken objc #193

Closed
opened 2026-03-03 16:46:34 +03:00 by kerem · 3 comments
Owner

Originally created by @Hendrik44 on GitHub (Nov 30, 2016).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/316

Description:

The function "renewAccessToken" is missing when using OAuthSwift at Version 1.1.0 or later in an objective-c-project. Maybe it only need to be add in Objc.swift?

OAuth Provider (Twitter, Github, ..):

OAuth2 Provider for own service, with Version 0.6.0 the function can call directly und OAuth workflow is fine.

OAuth Version:

  • Version 1
  • Version 2

OS (Please fill the version) :

  • iOS :
  • OSX :
  • TVOS :
  • WatchOS :

Installation method:

  • Carthage
  • CocoaPods
  • Manually

Library version:

  • head
  • v1.0.0
  • v0.6
  • other: 1.1.1

Xcode version:

  • 8.0 (Swift 3.0)

  • 8.0 (Swift 2.3)

  • 7.3.1

  • other: 8.1

  • objective c

Originally created by @Hendrik44 on GitHub (Nov 30, 2016). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/316 ### Description: The function "renewAccessToken" is missing when using OAuthSwift at Version 1.1.0 or later in an objective-c-project. Maybe it only need to be add in Objc.swift? ### OAuth Provider (Twitter, Github, ..): OAuth2 Provider for own service, with Version 0.6.0 the function can call directly und OAuth workflow is fine. ### OAuth Version: - [ ] Version 1 - [x] Version 2 ### OS (Please fill the version) : - [x] iOS : - [ ] OSX : - [ ] TVOS : - [ ] WatchOS : ### Installation method: - [x] Carthage - [ ] CocoaPods - [ ] Manually ### Library version: - [ ] head - [ ] v1.0.0 - [ ] v0.6 - [x] other: 1.1.1 ### Xcode version: - [ ] 8.0 (Swift 3.0) - [ ] 8.0 (Swift 2.3) - [ ] 7.3.1 - [x] other: 8.1 - [x] objective c
kerem 2026-03-03 16:46:34 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@phimage commented on GitHub (Nov 30, 2016):

yes in objc.swift we must add

    open func objc_renewAccessToken(withRefreshToken refreshToken: String, headers: OAuthSwift.Headers? = nil, success: @escaping TokenSuccessHandler, failure: Obj_FailureHandler?) -> OAuthSwiftRequestHandle? {
  // here call renewAccessToken
}
<!-- gh-comment-id:263873242 --> @phimage commented on GitHub (Nov 30, 2016): yes in objc.swift we must add ```swift open func objc_renewAccessToken(withRefreshToken refreshToken: String, headers: OAuthSwift.Headers? = nil, success: @escaping TokenSuccessHandler, failure: Obj_FailureHandler?) -> OAuthSwiftRequestHandle? { // here call renewAccessToken } ```
Author
Owner

@Hendrik44 commented on GitHub (Dec 2, 2016):

Will anyone merge it into the repo or should i do an pull-request?

<!-- gh-comment-id:264439236 --> @Hendrik44 commented on GitHub (Dec 2, 2016): Will anyone merge it into the repo or should i do an pull-request?
Author
Owner

@phimage commented on GitHub (Dec 2, 2016):

please do the PR, thx in advance
write Fix # into the commit message

<!-- gh-comment-id:264445923 --> @phimage commented on GitHub (Dec 2, 2016): please do the PR, thx in advance write Fix #<this bug number> into the commit message
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#193
No description provided.