[GH-ISSUE #263] Swift 2.3 Support #154

New issue

Closed

opened 2026-03-03 16:46:11 +03:00 by kerem · 5 comments

kerem commented

2026-03-03 16:46:11 +03:00

Owner

Originally created by @cpinski on GitHub (Aug 9, 2016).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/263

Could a Swift 2.3 branch be opened so that I can open a PR with full swift 2.3 support? I am currently on a project that would benefit greatly from having a dedicated Swift 2.3 branch.

Originally created by @cpinski on GitHub (Aug 9, 2016). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/263 Could a Swift 2.3 branch be opened so that I can open a PR with full swift 2.3 support? I am currently on a project that would benefit greatly from having a dedicated Swift 2.3 branch.

kerem

2026-03-03 16:46:11 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-03-03 16:46:12 +03:00

Author

Owner

@phimage commented on GitHub (Aug 10, 2016):

Since #239 I have not updated xcode beta
There is other change ? Warnings or errors? If yes could be fixed or not using same method from #239

@phimage commented on GitHub (Aug 10, 2016): Since #239 I have not updated xcode beta There is other change ? Warnings or errors? If yes could be fixed or not using same method from #239

kerem commented

2026-03-03 16:46:13 +03:00

Author

Owner

@cpinski commented on GitHub (Aug 10, 2016):

There have been some modifications to the code which makes the diff a little different currently. Also I have updated the project settings to use the project settings recommended by Xcode. I believe the biggest change there is setting SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule". This should speed up the execution of the code.

@cpinski commented on GitHub (Aug 10, 2016): There have been some modifications to the code which makes the diff a little different currently. Also I have updated the project settings to use the project settings recommended by Xcode. I believe the biggest change there is setting SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule". This should speed up the execution of the code.

kerem commented

2026-03-03 16:46:13 +03:00

Author

Owner

@cpinski commented on GitHub (Aug 10, 2016):

@phimage I added you as a collaborator on my fork so you can see the changes here

@cpinski commented on GitHub (Aug 10, 2016): @phimage I added you as a collaborator on my fork so you can see the changes [here](https://github.com/cpinski/OAuthSwift/commit/fd2ec2df7b2fe9a926eeacc04ff75736eede3957)

kerem commented

2026-03-03 16:46:13 +03:00

Author

Owner

@phimage commented on GitHub (Aug 10, 2016):

ok I simulate a PR and see the change
It's essentially xcode project file change.
So it's for compilation with carthage or xcode (cocoapod is not affected)
The other change seems to be conflict with new code

I will create a swift 2.3 branch
But If you PR I want to see only one commit with only project file change (refork or rebase current branch to a new branch in your fork, make the change and commit)
Thanks in advance

@phimage commented on GitHub (Aug 10, 2016): ok I simulate a PR and see the change It's essentially xcode project file change. So it's for compilation with carthage or xcode (cocoapod is not affected) The other change seems to be conflict with new code I will create a swift 2.3 branch But If you PR I want to see only one commit with only project file change (refork or rebase current branch to a new branch in your fork, make the change and commit) Thanks in advance

kerem commented

2026-03-03 16:46:13 +03:00

Author

Owner

@phimage commented on GitHub (Aug 12, 2016):

fixed by #264

@phimage commented on GitHub (Aug 12, 2016): fixed by #264