[GH-ISSUE #246] No encoding the auth_token for authorize #139

Closed
opened 2026-03-03 16:46:02 +03:00 by kerem · 1 comment
Owner

Originally created by @ElvisYang on GitHub (Jun 29, 2016).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/246

in https://github.com/OAuthSwift/OAuthSwift/blob/master/OAuthSwift/OAuth1Swift.swift#L87

do not encoding the oauth_token

"oauth_token=(credential.oauth_token)", when it contains just like &, + .....

For example credential.oauth_token.urlEncodedStringWithEncoding(OAuthSwiftDataEncoding)

Originally created by @ElvisYang on GitHub (Jun 29, 2016). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/246 in https://github.com/OAuthSwift/OAuthSwift/blob/master/OAuthSwift/OAuth1Swift.swift#L87 do not encoding the oauth_token "oauth_token=(credential.oauth_token)", when it contains just like `&`, `+` ..... For example `credential.oauth_token.urlEncodedStringWithEncoding(OAuthSwiftDataEncoding)`
kerem 2026-03-03 16:46:02 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@phimage commented on GitHub (Jul 7, 2016):

Ok I think you are right, there is an encoding problem
But I will use urlQueryEncodedto encode based on NSCharacterSet.URLQueryAllowedCharacterSet()

<!-- gh-comment-id:230997511 --> @phimage commented on GitHub (Jul 7, 2016): Ok I think you are right, there is an encoding problem But I will use `urlQueryEncoded`to encode based on `NSCharacterSet.URLQueryAllowedCharacterSet()`
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#139
No description provided.