[GH-ISSUE #244] When will there be swift 3 support? #137

Closed
opened 2026-03-03 16:45:59 +03:00 by kerem · 20 comments
Owner

Originally created by @simonnarang on GitHub (Jun 24, 2016).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/244

Thanks, have an app running on spm 3.0

Originally created by @simonnarang on GitHub (Jun 24, 2016). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/244 Thanks, have an app running on spm 3.0
kerem 2026-03-03 16:45:59 +03:00
Author
Owner

@phimage commented on GitHub (Jul 7, 2016):

I will a create a beta branch starting with last stable release
(and me or another contributor will commit into)
Master branch will be updated as usual when xcode 8 will be released

Downloading xcode 8 beta now and reading https://swift.org/migration-guide/
I am not familiar with swift package manager, so If you have some clues

  • like maybe create a file at root which describe the repository[like cocoadpod] or this could work "automatically"[like carthage])
  • if a branch could be specified (ie. the beta branch from OAuthSwift)
<!-- gh-comment-id:230986675 --> @phimage commented on GitHub (Jul 7, 2016): I will a create a beta branch starting with last stable release (and me or another contributor will commit into) Master branch will be updated as usual when xcode 8 will be released Downloading xcode 8 beta now and reading https://swift.org/migration-guide/ I am not familiar with swift package manager, so If you have some clues - like maybe create a file at root which describe the repository[like cocoadpod] or this could work "automatically"[like carthage]) - if a branch could be specified (ie. the beta branch from OAuthSwift)
Author
Owner

@phimage commented on GitHub (Jul 8, 2016):

branch swift 3.0 created with automatic conversion and come compilation fix

<!-- gh-comment-id:231314219 --> @phimage commented on GitHub (Jul 8, 2016): branch swift 3.0 created with automatic conversion and come compilation fix
Author
Owner

@phimage commented on GitHub (Aug 19, 2016):

WIP PR #267 https://github.com/skedgo/OAuthSwift.git branch swift3.0

<!-- gh-comment-id:240928339 --> @phimage commented on GitHub (Aug 19, 2016): WIP PR #267 https://github.com/skedgo/OAuthSwift.git branch swift3.0
Author
Owner

@leo150 commented on GitHub (Sep 16, 2016):

What about https://github.com/OAuthSwift/OAuthSwift.git swift3.0 branch? Is it working?

<!-- gh-comment-id:247560408 --> @leo150 commented on GitHub (Sep 16, 2016): What about https://github.com/OAuthSwift/OAuthSwift.git swift3.0 branch? Is it working?
Author
Owner

@phimage commented on GitHub (Sep 16, 2016):

@leo150 the branch I thinks is not working
use temporary fork https://github.com/skedgo/OAuthSwift/ on branch swift3.0

<!-- gh-comment-id:247613578 --> @phimage commented on GitHub (Sep 16, 2016): @leo150 the branch I thinks is not working use temporary fork https://github.com/skedgo/OAuthSwift/ on branch swift3.0
Author
Owner

@phimage commented on GitHub (Sep 25, 2016):

PR #277 (old one PR #267 ) merged into swift3.0 branch
then merged into master 5a1e575993
with some modifications :

  • fix project settings
  • some missing conversion
  • add swift-version file
  • rename functions and attributes
    • authorizeWithCallbackURL(...-> authorize(withCallbackURL...-
    • authorize_url_handler -> authorizeURLHandler
    • handleOpenURL-> handle(url:
    • ...
  • Return only OAuthSwiftError in failure callback ie. typed errors (tokenExpired, ...)
  • Return an handle on authorize( to be able to cancel
  • alias on OAuthSwift.Headers = [String: String], OAuthSwift.Parameters = [String: Any]
  • ...

There is yet some TODO

  • remove NSData and NSString reference
  • better handle returned when authorizing
    • when cancelling, cancel all the children request (there is cascading request)
    • by keeping a list of current request in OAuthSwiftobject

let me know if there is some bug, before tagging and releasing

<!-- gh-comment-id:249425219 --> @phimage commented on GitHub (Sep 25, 2016): PR #277 (old one PR #267 ) merged into swift3.0 branch then merged into master 5a1e5759934f8138c8ae96d2c7614d776c608b33 with some modifications : - fix project settings - some missing conversion - add swift-version file - rename functions and attributes - `authorizeWithCallbackURL(...`-> `authorize(withCallbackURL...`- - `authorize_url_handler` -> `authorizeURLHandler` - `handleOpenURL`-> `handle(url:` - ... - Return only `OAuthSwiftError` in failure callback ie. typed errors (`tokenExpired`, ...) - Return an handle on `authorize(` to be able to cancel - alias on `OAuthSwift.Headers = [String: String]`, `OAuthSwift.Parameters = [String: Any]` - ... There is yet some TODO - remove NSData and NSString reference - better handle returned when authorizing - when cancelling, cancel all the children request (there is cascading request) - by keeping a list of current request in `OAuthSwift`object let me know if there is some bug, before tagging and releasing
Author
Owner

@SMillerDev commented on GitHub (Sep 27, 2016):

@phimage the branch for https://github.com/skedgo/OAuthSwift/ is swift3 btw (no .0)

<!-- gh-comment-id:249785127 --> @SMillerDev commented on GitHub (Sep 27, 2016): @phimage the branch for https://github.com/skedgo/OAuthSwift/ is swift3 btw (no **.0**)
Author
Owner

@phimage commented on GitHub (Sep 27, 2016):

@SMillerDev you comment an old post (so useless)
skedgo branch has been merged to origin swift3.0 branch and then master

<!-- gh-comment-id:249788194 --> @phimage commented on GitHub (Sep 27, 2016): @SMillerDev you comment an old post (so useless) skedgo branch has been merged to origin swift3.0 branch and then master
Author
Owner

@SMillerDev commented on GitHub (Sep 27, 2016):

My bad, it was still open. Figured it was still relevant.

<!-- gh-comment-id:249812431 --> @SMillerDev commented on GitHub (Sep 27, 2016): My bad, it was still open. Figured it was still relevant.
Author
Owner

@hardikdevios commented on GitHub (Sep 28, 2016):

@phimage Please update PodSpec bro

<!-- gh-comment-id:250117272 --> @hardikdevios commented on GitHub (Sep 28, 2016): @phimage Please update PodSpec bro
Author
Owner

@phimage commented on GitHub (Sep 28, 2016):

@hardikdevios podspec is already updated
but no 1.0.0 tag
no push to cocoapod trunk
I choose when I release...( because you can use last code at your own risk now)

<!-- gh-comment-id:250127358 --> @phimage commented on GitHub (Sep 28, 2016): @hardikdevios podspec is already updated but no 1.0.0 tag no push to cocoapod trunk I choose when I release...( because you can use last code at your own risk now)
Author
Owner

@hardikdevios commented on GitHub (Sep 28, 2016):

Lol no problem Bro 👍

For now i am using

pod 'OAuthSwift', :git => 'https://github.com/OAuthSwift/OAuthSwift.git', :commit => '0b8f8d10e101d3c67c809fc2365c0ef07407ba47'

Working perfectly have to make some changes in Methods for Swift 3 other then its safe :)

<!-- gh-comment-id:250134663 --> @hardikdevios commented on GitHub (Sep 28, 2016): Lol no problem Bro 👍 For now i am using > `pod 'OAuthSwift', :git => 'https://github.com/OAuthSwift/OAuthSwift.git', :commit => '0b8f8d10e101d3c67c809fc2365c0ef07407ba47' > ` Working perfectly have to make some changes in Methods for Swift 3 other then its safe :)
Author
Owner

@jjjeeerrr111 commented on GitHub (Sep 30, 2016):

Any idea when the 1.0.0 will be released for Cocoapod support?

<!-- gh-comment-id:250810680 --> @jjjeeerrr111 commented on GitHub (Sep 30, 2016): Any idea when the 1.0.0 will be released for Cocoapod support?
Author
Owner

@phimage commented on GitHub (Oct 1, 2016):

@jjjeeerrr111: no, why?
see no date for milestone https://github.com/OAuthSwift/OAuthSwift/milestone/2

<!-- gh-comment-id:250894970 --> @phimage commented on GitHub (Oct 1, 2016): @jjjeeerrr111: no, why? see no date for milestone https://github.com/OAuthSwift/OAuthSwift/milestone/2
Author
Owner

@tonygon commented on GitHub (Oct 2, 2016):

@hardikdevios thanks for the command!
@phimage and @contributors of course thank you for developing OAuthSwift ;) great stuff!

<!-- gh-comment-id:250960692 --> @tonygon commented on GitHub (Oct 2, 2016): @hardikdevios thanks for the command! @phimage and @contributors of course thank you for developing OAuthSwift ;) great stuff!
Author
Owner

@jjjeeerrr111 commented on GitHub (Oct 2, 2016):

@phimage wondering how I can incorporate OAuthSwift into my Swift 3.0 project

<!-- gh-comment-id:250975736 --> @jjjeeerrr111 commented on GitHub (Oct 2, 2016): @phimage wondering how I can incorporate OAuthSwift into my Swift 3.0 project
Author
Owner

@phimage commented on GitHub (Oct 2, 2016):

to use head master code

pod 'OAuthSwift', :git => 'https://github.com/OAuthSwift/OAuthSwift.git'

3d0f81ae5c

  • remove NSData, NSDate and NSString from code
  • missing renaming (functions, variables[no more _] )
  • cleaning
  • Encode version in credential

I will release soon

<!-- gh-comment-id:250994394 --> @phimage commented on GitHub (Oct 2, 2016): to use head master code ``` ruby pod 'OAuthSwift', :git => 'https://github.com/OAuthSwift/OAuthSwift.git' ``` 3d0f81ae5c4cf2e1509481b7ff97f9c33a519622 - [x] remove NSData, NSDate and NSString from code - [x] missing renaming (functions, variables[no more _] ) - [x] cleaning - [x] Encode version in credential I will release soon
Author
Owner

@ahmad-ishfaq commented on GitHub (Oct 5, 2016):

pod 'OAuthSwift', :git => 'https://github.com/OAuthSwift/OAuthSwift.git' is not working properly it gives me an oauthswit error -10 when authenticating for twitter

<!-- gh-comment-id:251703619 --> @ahmad-ishfaq commented on GitHub (Oct 5, 2016): pod 'OAuthSwift', :git => 'https://github.com/OAuthSwift/OAuthSwift.git' is not working properly it gives me an oauthswit error -10 when authenticating for twitter
Author
Owner

@phimage commented on GitHub (Oct 6, 2016):

@ahmad-ishfaq please make a descriptive issue instead of writing here... (and fill issue template)
with the detailed content of the error (maybe an OAuthSwiftError.requestError(error: /*an NSError with info*/))
because how you know that is a master branch, did you test with older release ?
do you know that twitter have HTTP callback url that you must declare? (or you will receive "Desktop applications only support the oauth_callback value ‘oob’")

<!-- gh-comment-id:251939560 --> @phimage commented on GitHub (Oct 6, 2016): @ahmad-ishfaq please make a descriptive issue instead of writing here... (and fill issue template) with the detailed content of the error (maybe an `OAuthSwiftError.requestError(error: /*an NSError with info*/)`) because how you know that is a master branch, did you test with older release ? do you know that twitter have HTTP callback url that you must declare? (or you will receive "Desktop applications only support the oauth_callback value ‘oob’")
Author
Owner

@phimage commented on GitHub (Oct 6, 2016):

1.0.0 tagged
swift3 branch removed

please open new issues if bug

<!-- gh-comment-id:251943926 --> @phimage commented on GitHub (Oct 6, 2016): 1.0.0 tagged swift3 branch removed please open new issues if bug
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#137
No description provided.