[GH-ISSUE #214] Fix unit tests to improve trust in this library

kerem commented

2026-03-03 16:45:50 +03:00

Owner

Copy link

Originally created by @FGoessler on GitHub (Apr 3, 2016).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/214

We want to use this library in a quite big project in our efforts to migrate our network stack to Swift and OAuth 2 from a custom build OAuth 1 lib written in Objective C. Since OAuthSwift would then be a big essential part of our app we need a very high reliability in it's functionality and quality.

Unfortunately some unit tests of this project are currently failing and there also some that are just commented out and ignored.

To increase the trust in this library it would be nice to have 100% running unit tests with a good coverage which are also automatically run against each pull request e.g. via Travis.

Originally created by @FGoessler on GitHub (Apr 3, 2016). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/214 We want to use this library in a quite big project in our efforts to migrate our network stack to Swift and OAuth 2 from a custom build OAuth 1 lib written in Objective C. Since OAuthSwift would then be a big essential part of our app we need a very high reliability in it's functionality and quality. Unfortunately some unit tests of this project are currently failing and there also some that are just commented out and ignored. To increase the trust in this library it would be nice to have 100% running unit tests with a good coverage which are also automatically run against each pull request e.g. via Travis.

kerem

2026-03-03 16:45:50 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-03-03 16:45:51 +03:00

Author

Owner

Copy link

@phimage commented on GitHub (Apr 4, 2016):

Yes more unit test and travis are in roadmap https://github.com/OAuthSwift/OAuthSwift/wiki/Roadmap
I ask authorization for travis (organisation owner must accept it)

I have not run unit test since previous release.
There is many change into signature for OAuth1.

@phimage commented on GitHub (Apr 4, 2016): Yes more unit test and travis are in roadmap https://github.com/OAuthSwift/OAuthSwift/wiki/Roadmap I ask authorization for travis (organisation owner must accept it) I have not run unit test since previous release. There is many change into signature for OAuth1.

kerem commented

2026-03-03 16:45:51 +03:00

Author

Owner

Copy link

@FGoessler commented on GitHub (Apr 5, 2016):

Imo the following tasks should be done:

Fix existing unit tests
Look at all test that are commented out and fix them or delete them
Setup Travis CI for this repo and let it check PRs
Test previously untested stuff:
- Multipart requests
- NSDate category
- String category
- Utils, SHA1 and HMAC
- Access Token renewal
- Convenience & request methods on OAuthSwiftClient

@FGoessler commented on GitHub (Apr 5, 2016): Imo the following tasks should be done: - [x] Fix existing unit tests - [ ] Look at all test that are commented out and fix them or delete them - [ ] Setup Travis CI for this repo and let it check PRs - [ ] Test previously untested stuff: - [x] Multipart requests - [x] NSDate category - [ ] String category - [x] Utils, SHA1 and HMAC - [ ] Access Token renewal - [x] Convenience & request methods on OAuthSwiftClient

kerem commented

2026-03-03 16:45:51 +03:00

Author

Owner

Copy link

@phimage commented on GitHub (Oct 7, 2016):

some unit tests has been added

@phimage commented on GitHub (Oct 7, 2016): some unit tests has been added

kerem referenced this issue

2026-03-03 16:49:16 +03:00

[PR #119] [CLOSED] Split makeRequest to enable populating existing URLRequest #525

No Branch/Tag specified