starred/OAuthSwift

Fork 0

mirror of https://github.com/OAuthSwift/OAuthSwift.git synced 2026-04-26 12:45:52 +03:00

[GH-ISSUE #174] Incorrect signature when parameter includes a [ or ] #104

New issue

Closed

opened 2026-03-03 16:45:42 +03:00 by kerem · 7 comments

kerem commented

2026-03-03 16:45:42 +03:00

Owner

Originally created by @obuseme on GitHub (Jan 18, 2016).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/174

Using the AWeber public API (https://labs.aweber.com/docs) I discovered that when passing parameters with OAuthSwift requests that include braces, [ or ], they aren't actually encoded, and thus the signature isn't properly created. When the server attempts to verify the signature, it does so based on encoded values for the braces, and thus does not match what the client provides. I created #173 to fix this. Let me know what you think.

Originally created by @obuseme on GitHub (Jan 18, 2016). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/174 Using the AWeber public API (https://labs.aweber.com/docs) I discovered that when passing parameters with OAuthSwift requests that include braces, [ or ], they aren't actually encoded, and thus the signature isn't properly created. When the server attempts to verify the signature, it does so based on encoded values for the braces, and thus does not match what the client provides. I created #173 to fix this. Let me know what you think.

kerem

2026-03-03 16:45:42 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-03 16:45:43 +03:00

Author

Owner

@phimage commented on GitHub (Jan 18, 2016):

#173 exact duplicate of #168
#165 also introduce bracket (but do more change)

one of this PR will fix this bug

@phimage commented on GitHub (Jan 18, 2016): #173 exact duplicate of #168 #165 also introduce bracket (but do more change) one of this PR will fix this bug

kerem commented

2026-03-03 16:45:43 +03:00

Author

Owner

@obuseme commented on GitHub (Jan 18, 2016):

Oops, my bad, totally missed #168. Doesn't matter to me which one merges, as long as one does. Should I close mine? Need this change available via CocoaPods ASAP. Thanks

I'm not seeing anything related to braces in #169 ?

@obuseme commented on GitHub (Jan 18, 2016): Oops, my bad, totally missed #168. Doesn't matter to me which one merges, as long as one does. Should I close mine? Need this change available via CocoaPods ASAP. Thanks I'm not seeing anything related to braces in #169 ?

kerem commented

2026-03-03 16:45:43 +03:00

Author

Owner

@phimage commented on GitHub (Jan 18, 2016):

#165 I fix my comment
I already close your PR but keep the issue open

I don't know when me or project owner will merge so =

You can use cocoapod
with a local repo with your change with something like that

:path => ‘../OAuthSwift/OAuthSwift.podspec'

or with podspec => to point a podspec, a remote one on your repo

@phimage commented on GitHub (Jan 18, 2016): #165 I fix my comment I already close your PR but keep the issue open I don't know when me or project owner will merge so = You can use cocoapod with a local repo with your change with something like that ``` :path => ‘../OAuthSwift/OAuthSwift.podspec' ``` or with `podspec =>` to point a podspec, a remote one on your repo

kerem commented

2026-03-03 16:45:44 +03:00

Author

Owner

@obuseme commented on GitHub (Jan 18, 2016):

Ok, thanks

@obuseme commented on GitHub (Jan 18, 2016): Ok, thanks

kerem commented

2026-03-03 16:45:44 +03:00

Author

Owner

@dbmrq commented on GitHub (Mar 3, 2016):

No news on merging this? I'm having trouble with the brackets as well.

@dbmrq commented on GitHub (Mar 3, 2016): No news on merging this? I'm having trouble with the brackets as well.

kerem commented

2026-03-03 16:45:44 +03:00

Author

Owner

@phimage commented on GitHub (Mar 5, 2016):

The reason why I have not yet merged are

3 fix about signature (2 PR and one issue where you commented)
no enough unit tests (to prevent regression on signature) so I am little scared :p (if one oauth provider work differently from others.. for instance)

Any help will be welcomed

@phimage commented on GitHub (Mar 5, 2016): The reason why I have not yet merged are - 3 fix about signature (2 PR and one issue where you commented) - no enough unit tests (to prevent regression on signature) so I am little scared :p (if one oauth provider work differently from others.. for instance) Any help will be welcomed

kerem commented

2026-03-03 16:45:44 +03:00

Author

Owner

@phimage commented on GitHub (Mar 9, 2016):

PR #201 must fix this one

@phimage commented on GitHub (Mar 9, 2016): PR #201 must fix this one