[PR #46] [CLOSED] Add missing UI elements initialization for LoginDialog #99

New issue

Closed

opened 2026-02-28 14:39:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:39:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NTifyApp/NTify/pull/46
Author: @oleg-dubinskiy
Created: 7/19/2024
Status: ❌ Closed

Base: main ← Head: fix_2

📝 Commits (1)

6d42613 Add missing UI elements initialization for LoginDialog

📊 Changes

1 file changed (+29 additions, -15 deletions)

View changed files

📝 src/main/java/com/spotifyxp/dialogs/LoginDialog.java (+29 -15)

📄 Description

Restore an initialization of several UI elements which was previously removed. Move some initialization code to the dialog creation constructor.
Fixes LoginDialog crash when trying to login in Spotify account.
Properly fixes #43.
Here are some screenshots proving LoginDialog does not crash anymore and works perfectly now, although it looks a bit crooked, judging by the elements position (works on all OSes):
Ubuntu 21.10:

Windows XP Professional SP3:

I did not make a screenshot yet, but it works in ReactOS 0.4.15-dev as well too. 🙂
On ReactOS and Windows XP, I tested it with the following Java version: https://archive.org/details/jre1.8.0_251_XP. Much older versions (e. g., 8u51, are not working properly with this still).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NTifyApp/NTify/pull/46 **Author:** [@oleg-dubinskiy](https://github.com/oleg-dubinskiy) **Created:** 7/19/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix_2` --- ### 📝 Commits (1) - [`6d42613`](https://github.com/NTifyApp/NTify/commit/6d42613e6c04f3e42e8e8a6cb8af442649b9d88d) Add missing UI elements initialization for LoginDialog ### 📊 Changes **1 file changed** (+29 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/main/java/com/spotifyxp/dialogs/LoginDialog.java` (+29 -15) </details> ### 📄 Description Restore an initialization of several UI elements which was previously removed. Move some initialization code to the dialog creation constructor. Fixes LoginDialog crash when trying to login in Spotify account. Properly fixes #43. Here are some screenshots proving LoginDialog does not crash anymore and works perfectly now, although it looks a bit crooked, judging by the elements position (works on all OSes): Ubuntu 21.10: ![Снимок экрана от 2024-07-19 21-09-18](https://github.com/user-attachments/assets/d6e12666-6d47-49e2-83a7-b71253e904ab) Windows XP Professional SP3: ![VirtualBox_Windows XP_19_07_2024_21_15_38](https://github.com/user-attachments/assets/fab38215-792b-4e07-babb-66aa7c2b365c) I did not make a screenshot yet, but it works in ReactOS 0.4.15-dev as well too. :slightly_smiling_face: On ReactOS and Windows XP, I tested it with the following Java version: https://archive.org/details/jre1.8.0_251_XP. Much older versions (e. g., 8u51, are not working properly with this still). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>