[PR #45] [MERGED] Ignore SocketTimeoutException when reading connection responses first time #97

New issue

Closed

opened 2026-02-28 14:39:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:39:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NTifyApp/NTify/pull/45
Author: @oleg-dubinskiy
Created: 7/19/2024
Status: ✅ Merged
Merged: 8/8/2024
Merged by: @werwolf2303

Base: main ← Head: fix_1

📝 Commits (2)

da8aebd Ignore SocketTimeoutException when reading connection responses first time
e8e8702 Merge branch 'main' into fix_1

📊 Changes

1 file changed (+1 additions, -8 deletions)

View changed files

📝 src/main/java/com/spotifyxp/deps/xyz/gianlu/librespot/core/Session.java (+1 -8)

📄 Description

Handle it only if the first connection request has failed. This avoids endless exception with reconnecting when connecting SpotifyXP with already logined account. However LoginDialog still crashes. This imports a part of the latest librespot-java code from github.com/librespot-org/librespot-java@d0ff31b4f4/lib/src/main/java/xyz/gianlu/librespot/core/Session.java (L321).
Fixes #44 .
Here are some screenshots proving SpotifyXP now starts properly on several OSes (despite LoginDialog):
Ubuntu 21.10:

ReactOS 0.4.15-dev:

Windows XP Professional SP3:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NTifyApp/NTify/pull/45 **Author:** [@oleg-dubinskiy](https://github.com/oleg-dubinskiy) **Created:** 7/19/2024 **Status:** ✅ Merged **Merged:** 8/8/2024 **Merged by:** [@werwolf2303](https://github.com/werwolf2303) **Base:** `main` ← **Head:** `fix_1` --- ### 📝 Commits (2) - [`da8aebd`](https://github.com/NTifyApp/NTify/commit/da8aebd0053207180e39adec9815f92ea0ca5e78) Ignore SocketTimeoutException when reading connection responses first time - [`e8e8702`](https://github.com/NTifyApp/NTify/commit/e8e8702a364c46ce62d4eb6571fb32454b348a29) Merge branch 'main' into fix_1 ### 📊 Changes **1 file changed** (+1 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/main/java/com/spotifyxp/deps/xyz/gianlu/librespot/core/Session.java` (+1 -8) </details> ### 📄 Description Handle it only if the first connection request has failed. This avoids endless exception with reconnecting when connecting SpotifyXP with already logined account. However LoginDialog still crashes. This imports a part of the latest librespot-java code from https://github.com/librespot-org/librespot-java/blob/d0ff31b4f476590c9c17401aac01a6762e4ba908/lib/src/main/java/xyz/gianlu/librespot/core/Session.java#L321. Fixes #44 . Here are some screenshots proving SpotifyXP now starts properly on several OSes (despite LoginDialog): Ubuntu 21.10: ![Снимок экрана от 2024-07-19 21-07-50](https://github.com/user-attachments/assets/27e11e3a-c2db-4b1f-9e1e-9082e950391a) ReactOS 0.4.15-dev: ![SpotifyXP_ROS](https://github.com/user-attachments/assets/7a55cca0-677c-45f5-b567-75a4a3be7371) Windows XP Professional SP3: ![VirtualBox_Windows XP_19_07_2024_21_16_36](https://github.com/user-attachments/assets/755072e7-e635-4870-8831-d902c4342fc1) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>