mirror of
https://github.com/NTifyApp/NTify.git
synced 2026-04-26 07:55:51 +03:00
[GH-ISSUE #44] Exception with endless reconnecting after login #37
Labels
No labels
In Progress
bug
enhancement
pull-request
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/NTify#37
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @oleg-dubinskiy on GitHub (Jul 19, 2024).
Original GitHub issue: https://github.com/NTifyApp/NTify/issues/44
After login into Spotify account, or with already logined one, when SpotifyXP tries to connect, appears EOFException/SocketTimeoutExcetion (actually only 2nd one), followed by endless looped reconnecting. And no actual connecting and login into my account.
The debug output is as follows:
(tested on ReactOS 0.4.15-dev, but is also the same on all other OSes).
debug_ReactOS_0.4.15_dev_NEW.txt
Tested with this Java version: https://archive.org/details/jre1.8.0_251_XP, and there is exactly the same result.
It occurs starting from
f6c1b7ca82, which had a purpose to fix a LoginDialog crash, but did not fix it actually. It has introduced this issue instead.I already figured out how to fix it and made a fix in my branch, so will submit a new PR soon.
@werwolf2303 commented on GitHub (Jul 23, 2024):
This reconnecting thing was an attempt to make spotifyxp more stable. When SpotifyXP reconnects and has an error it retries and retries and retries.... but eventually it should die with a message popping up
@oleg-dubinskiy commented on GitHub (Jul 23, 2024):
But more interesting is the reason: why it reconnects even when there's actually no error? Maybe it's a problem of the client itself instead of a server? Other clients are connecting fine. Maybe it reconnects in case when it shouldn't? Spotify server actually doesn't fail. It seems to me that exception is simply always triggered, even when no any connection error has occurred.
Is my linked fix correct btw? It ignores that exception when there's no any error yet and SpotifyXP connects and works just fine after my changes. 🙂
@werwolf2303 commented on GitHub (Jul 23, 2024):
I check for an error via try catch. So it's guaranteed that an exception happened but I don't know why. This also happened at my old school's wifi
@oleg-dubinskiy commented on GitHub (Aug 7, 2024):
Unfortunately it's not fixed in latest master for me yet. The same exception is still occurring.
Perhaps we need to simply ignore that.