mirror of
https://github.com/FujiwaraChoki/MoneyPrinterV2.git
synced 2026-04-26 06:35:51 +03:00
[GH-ISSUE #95] from fixed "4" line script to N line script #69
Labels
No labels
bug
enhancement
good first issue
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/MoneyPrinterV2#69
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @taehwann on GitHub (Feb 14, 2025).
Original GitHub issue: https://github.com/FujiwaraChoki/MoneyPrinterV2/issues/95
I have a little improvement idea in youtube shorts feature, so if you feel like it's a good idea, then I'll make a pull request.
So basically mpv2 currently forces to be "4" sentences of script in youtube shorts, and that was around 20 seconds when I tested it. But I think if we change this forced number "4" into variable placed somewhere like config, able to make users change their script's size, and it's video length, it will be better to use.
Anyway, thanks for this awesome repo! 👍 👍
@FujiwaraChoki commented on GitHub (Feb 15, 2025):
Sure! Happy to accept a PR.
@taehwann commented on GitHub (Feb 16, 2025):
thanks. I'll make a PR for this enhancement.
@taehwann commented on GitHub (Feb 16, 2025):
@FujiwaraChoki I've updated the PR. Please review it when you have time. Thank you!