[PR #130] [MERGED] Fix songs download fallback and audio selection #128

New issue

Closed

opened 2026-03-02 04:06:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 04:06:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/FujiwaraChoki/MoneyPrinterV2/pull/130
Author: @FujiwaraChoki
Created: 3/1/2026
Status: ✅ Merged
Merged: 3/1/2026
Merged by: @FujiwaraChoki

Base: main ← Head: fix/media-generation-fallbacks

📝 Commits (2)

170f913 Fix songs download fallback and audio selection
789cdd7 Retry songs download when directory exists but empty

📊 Changes

1 file changed (+57 additions, -15 deletions)

View changed files

📝 src/utils.py (+57 -15)

📄 Description

Summary

add fallback download URL handling for song archives instead of relying on a single endpoint
validate each archive download before extraction and provide clear warnings per failed URL
improve random track selection to only consider audio files and fail clearly when none are available
preserve cleanup behavior for temporary archives after successful extraction

Why this change

Song zip URLs regularly expire or return invalid payloads, causing startup failures and corrupted media state. This update makes song fetching resilient and ensures video generation only picks valid audio files.

#118
#124

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/FujiwaraChoki/MoneyPrinterV2/pull/130 **Author:** [@FujiwaraChoki](https://github.com/FujiwaraChoki) **Created:** 3/1/2026 **Status:** ✅ Merged **Merged:** 3/1/2026 **Merged by:** [@FujiwaraChoki](https://github.com/FujiwaraChoki) **Base:** `main` ← **Head:** `fix/media-generation-fallbacks` --- ### 📝 Commits (2) - [`170f913`](https://github.com/FujiwaraChoki/MoneyPrinterV2/commit/170f913059746f562cc0e44c1a727ba255ee7efe) Fix songs download fallback and audio selection - [`789cdd7`](https://github.com/FujiwaraChoki/MoneyPrinterV2/commit/789cdd7e170dd590b306a15887aad01a76c10952) Retry songs download when directory exists but empty ### 📊 Changes **1 file changed** (+57 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/utils.py` (+57 -15) </details> ### 📄 Description ## Summary - add fallback download URL handling for song archives instead of relying on a single endpoint - validate each archive download before extraction and provide clear warnings per failed URL - improve random track selection to only consider audio files and fail clearly when none are available - preserve cleanup behavior for temporary archives after successful extraction ## Why this change Song zip URLs regularly expire or return invalid payloads, causing startup failures and corrupted media state. This update makes song fetching resilient and ensures video generation only picks valid audio files. ## Related issues - #118 - #124 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>