[PR #129] [MERGED] Fix outreach scraper execution and CSV handling #126

New issue

Closed

opened 2026-03-02 04:06:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 04:06:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/FujiwaraChoki/MoneyPrinterV2/pull/129
Author: @FujiwaraChoki
Created: 3/1/2026
Status: ✅ Merged
Merged: 3/1/2026
Merged by: @FujiwaraChoki

Base: main ← Head: fix/outreach-scraper-resilience

📝 Commits (1)

6ee0f27 Fix outreach scraper execution and CSV handling

📊 Changes

1 file changed (+86 additions, -36 deletions)

View changed files

📝 src/classes/Outreach.py (+86 -36)

📄 Description

Summary

remove hardcoded scraper folder assumptions and discover extracted google-maps-scraper-* folders dynamically
make build/run logic cross-platform by removing Windows-only process-kill behavior and using explicit subprocess execution
fail fast with a clear message when scraper output CSV is missing instead of raising FileNotFoundError later
fix company name interpolation and row indexing bugs when enriching and emailing scraped rows

Why this change

Outreach frequently fails due to version/path drift in scraper archives and brittle process handling. These changes make scraper execution predictable, improve diagnostics, and prevent malformed outbound emails caused by incorrect string indexing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/FujiwaraChoki/MoneyPrinterV2/pull/129 **Author:** [@FujiwaraChoki](https://github.com/FujiwaraChoki) **Created:** 3/1/2026 **Status:** ✅ Merged **Merged:** 3/1/2026 **Merged by:** [@FujiwaraChoki](https://github.com/FujiwaraChoki) **Base:** `main` ← **Head:** `fix/outreach-scraper-resilience` --- ### 📝 Commits (1) - [`6ee0f27`](https://github.com/FujiwaraChoki/MoneyPrinterV2/commit/6ee0f27324b8162d1054ae2c95f0d4cca23fc087) Fix outreach scraper execution and CSV handling ### 📊 Changes **1 file changed** (+86 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/classes/Outreach.py` (+86 -36) </details> ### 📄 Description ## Summary - remove hardcoded scraper folder assumptions and discover extracted `google-maps-scraper-*` folders dynamically - make build/run logic cross-platform by removing Windows-only process-kill behavior and using explicit subprocess execution - fail fast with a clear message when scraper output CSV is missing instead of raising `FileNotFoundError` later - fix company name interpolation and row indexing bugs when enriching and emailing scraped rows ## Why this change Outreach frequently fails due to version/path drift in scraper archives and brittle process handling. These changes make scraper execution predictable, improve diagnostics, and prevent malformed outbound emails caused by incorrect string indexing. ## Related issues - #90 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>