[PR #1094] [CLOSED] Improve code quality and reliability across all activation scripts #952

New issue

Closed

opened 2026-02-27 10:13:34 +03:00 by kerem · 0 comments

kerem commented 2026-02-27 10:13:34 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/massgravel/Microsoft-Activation-Scripts/pull/1094
Author: @atanuroy22
Created: 9/24/2025
Status: ❌ Closed

Base: master ← Head: master

---

📝 Commits (1)

• 24e0209 Improve code quality and reliability

📊 Changes

11 files changed (+120 additions, -24 deletions)

View changed files

📝 MAS/All-In-One-Version-KL/MAS_AIO.cmd (+4 -4)
📝 MAS/Separate-Files-Version/Activators/HWID_Activation.cmd (+2 -2)
📝 MAS/Separate-Files-Version/Activators/KMS38_Activation.cmd (+2 -2)
📝 MAS/Separate-Files-Version/Activators/Ohook_Activation_AIO.cmd (+2 -2)
📝 MAS/Separate-Files-Version/Activators/Online_KMS_Activation.cmd (+3 -3)
📝 MAS/Separate-Files-Version/Activators/TSforge_Activation.cmd (+2 -2)
📝 MAS/Separate-Files-Version/Change_Office_Edition.cmd (+2 -2)
📝 MAS/Separate-Files-Version/Change_Windows_Edition.cmd (+2 -2)
📝 MAS/Separate-Files-Version/Extract_OEM_Folder.cmd (+2 -2)
📝 MAS/Separate-Files-Version/Troubleshoot.cmd (+2 -2)
📝 README.md (+97 -1)

📄 Description

🚀 Summary

This PR modernizes the codebase with several quality improvements that enhance reliability and user experience while maintaining full backward compatibility.

🔧 Changes Made

Code Quality Improvements

• Modernized delay commands: Replaced all legacy ping 127.0.0.1 -n 20 delays with modern timeout /t 20 /nobreak >nul across 10 script files
• Enhanced PowerShell error handling: Added try-catch blocks for more robust service restart operations
• Fixed typos: Corrected "Respoding" → "Responding" in error messages for professional appearance

Documentation Enhancements

• Improved README.md: Added GitHub badges, features section, FAQ, and safety information
• Fixed folder path: Corrected navigation instructions to use All-In-One-Version-KL
• Enhanced user guidance: Added activation methods comparison table

✅ Benefits

• More reliable: Modern timeout commands don't depend on network stack
• Better user experience: Clearer error messages and comprehensive documentation
• Professional appearance: Fixed typos and improved formatting
• Maintainable code: Consistent patterns across all scripts
• Backward compatible: No breaking changes to existing functionality

🧪 Testing

• ✅ Verified timeout commands work correctly on Windows 10/11
• ✅ Confirmed PowerShell improvements don't break existing functionality
• ✅ Tested that timing behavior remains consistent with original
• ✅ Validated all activation methods still work as expected

📁 Files Changed

Scripts (10 files):

• MAS/All-In-One-Version-KL/MAS_AIO.cmd
• MAS/Separate-Files-Version/Activators/*.cmd (5 files)
• MAS/Separate-Files-Version/*.cmd (4 files)

Documentation:

• README.md (enhanced with new sections and corrections)

---

These improvements address real reliability issues while maintaining the excellent functionality that makes MAS so valuable to the community. 🙏

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/massgravel/Microsoft-Activation-Scripts/pull/1094 **Author:** [@atanuroy22](https://github.com/atanuroy22) **Created:** 9/24/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`24e0209`](https://github.com/massgravel/Microsoft-Activation-Scripts/commit/24e0209de9ec4b879b883c7383c86fa376083234) Improve code quality and reliability ### 📊 Changes **11 files changed** (+120 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `MAS/All-In-One-Version-KL/MAS_AIO.cmd` (+4 -4) 📝 `MAS/Separate-Files-Version/Activators/HWID_Activation.cmd` (+2 -2) 📝 `MAS/Separate-Files-Version/Activators/KMS38_Activation.cmd` (+2 -2) 📝 `MAS/Separate-Files-Version/Activators/Ohook_Activation_AIO.cmd` (+2 -2) 📝 `MAS/Separate-Files-Version/Activators/Online_KMS_Activation.cmd` (+3 -3) 📝 `MAS/Separate-Files-Version/Activators/TSforge_Activation.cmd` (+2 -2) 📝 `MAS/Separate-Files-Version/Change_Office_Edition.cmd` (+2 -2) 📝 `MAS/Separate-Files-Version/Change_Windows_Edition.cmd` (+2 -2) 📝 `MAS/Separate-Files-Version/Extract_OEM_Folder.cmd` (+2 -2) 📝 `MAS/Separate-Files-Version/Troubleshoot.cmd` (+2 -2) 📝 `README.md` (+97 -1) </details> ### 📄 Description ## 🚀 Summary This PR modernizes the codebase with several quality improvements that enhance reliability and user experience while maintaining full backward compatibility. ## 🔧 Changes Made ### **Code Quality Improvements** - **Modernized delay commands**: Replaced all legacy `ping 127.0.0.1 -n 20` delays with modern `timeout /t 20 /nobreak >nul` across **10 script files** - **Enhanced PowerShell error handling**: Added try-catch blocks for more robust service restart operations - **Fixed typos**: Corrected "Respoding" → "Responding" in error messages for professional appearance ### **Documentation Enhancements** - **Improved README.md**: Added GitHub badges, features section, FAQ, and safety information - **Fixed folder path**: Corrected navigation instructions to use `All-In-One-Version-KL` - **Enhanced user guidance**: Added activation methods comparison table ## ✅ Benefits - **More reliable**: Modern timeout commands don't depend on network stack - **Better user experience**: Clearer error messages and comprehensive documentation - **Professional appearance**: Fixed typos and improved formatting - **Maintainable code**: Consistent patterns across all scripts - **Backward compatible**: No breaking changes to existing functionality ## 🧪 Testing - ✅ Verified timeout commands work correctly on Windows 10/11 - ✅ Confirmed PowerShell improvements don't break existing functionality - ✅ Tested that timing behavior remains consistent with original - ✅ Validated all activation methods still work as expected ## 📁 Files Changed **Scripts (10 files):** - `MAS/All-In-One-Version-KL/MAS_AIO.cmd` - `MAS/Separate-Files-Version/Activators/*.cmd` (5 files) - `MAS/Separate-Files-Version/*.cmd` (4 files) **Documentation:** - `README.md` (enhanced with new sections and corrections) --- *These improvements address real reliability issues while maintaining the excellent functionality that makes MAS so valuable to the community.* 🙏 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-02-27 10:13:34 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

dev

3.10

3.9

3.8

3.7

3.6

3.5

3.4

3.3

3.2

3.1

3.0

2.9

2.8

2.7

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.9

1.8

1.7

1.6

1.5

1.4

1.3

1.2

Labels

Clear labels   

pull-request

Mirrored from GitHub Pull Request

No labels

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/Microsoft-Activation-Scripts#952

No description provided.