starred/Manila
1
0
Fork 0
mirror of https://github.com/neilsardesai/Manila.git synced 2026-04-25 19:45:48 +03:00
Code Issues 12 Projects Releases 2 Packages Wiki Activity

[GH-ISSUE #1] No Color Menu on partition #2

New issue
Open
opened 2026-03-03 16:41:28 +03:00 by kerem · 14 comments
kerem commented 2026-03-03 16:41:28 +03:00
Owner
Copy link

Originally created by @agencetwogether on GitHub (Mar 19, 2022).
Original GitHub issue: https://github.com/neilsardesai/Manila/issues/1

Hello,

I have 2 partitions on my MacBook Pro : first for macOs and second for data.
In fist one I can choose a color for folder or for second no option appears.

Originally created by @agencetwogether on GitHub (Mar 19, 2022). Original GitHub issue: https://github.com/neilsardesai/Manila/issues/1 Hello, I have 2 partitions on my MacBook Pro : first for macOs and second for data. In fist one I can choose a color for folder or for second no option appears.
kerem commented 2026-03-03 16:41:29 +03:00
Author
Owner
Copy link

@neilsardesai commented on GitHub (Mar 19, 2022):

Hello,
Would you mind posting a screen recording of the issue?

<!-- gh-comment-id:1073040252 --> @neilsardesai commented on GitHub (Mar 19, 2022): Hello, Would you mind posting a screen recording of the issue?
kerem commented 2026-03-03 16:41:29 +03:00
Author
Owner
Copy link

@agencetwogether commented on GitHub (Mar 19, 2022):

Sure, This is a video showing

https://user-images.githubusercontent.com/53862310/159132516-f9046260-2e20-493f-88e4-88b47eed18ba.mov

<!-- gh-comment-id:1073052301 --> @agencetwogether commented on GitHub (Mar 19, 2022): Sure, This is a video showing https://user-images.githubusercontent.com/53862310/159132516-f9046260-2e20-493f-88e4-88b47eed18ba.mov
kerem commented 2026-03-03 16:41:29 +03:00
Author
Owner
Copy link

@starbudweiser commented on GitHub (Mar 21, 2022):

I have the same issue.
The contextual menu shows up only on main Macintosh HD folders.
On other partitions or hardrives, it is not visible.

<!-- gh-comment-id:1074327524 --> @starbudweiser commented on GitHub (Mar 21, 2022): I have the same issue. The contextual menu shows up only on main Macintosh HD folders. On other partitions or hardrives, it is not visible.
kerem commented 2026-03-03 16:41:30 +03:00
Author
Owner
Copy link

@neilsardesai commented on GitHub (Mar 22, 2022):

Thanks for the info. This should now be resolved in the latest version (1.0.2). Please try it out and let me know if it works for you.

<!-- gh-comment-id:1074548227 --> @neilsardesai commented on GitHub (Mar 22, 2022): Thanks for the info. This should now be resolved in the latest version (1.0.2). Please try it out and let me know if it works for you.
kerem commented 2026-03-03 16:41:30 +03:00
Author
Owner
Copy link

@agencetwogether commented on GitHub (Mar 22, 2022):

Hi @neilsardesai

Thanks for the fix, Yes it's working..... But...
Manila replace hard drive icon of my second partition with file icon.
If i uncheck Manila in Finder extensions, hard drive icon shows, if I check again, file icon...

<!-- gh-comment-id:1074551309 --> @agencetwogether commented on GitHub (Mar 22, 2022): Hi @neilsardesai Thanks for the fix, Yes it's working..... But... Manila replace hard drive icon of my second partition with file icon. If i uncheck Manila in Finder extensions, hard drive icon shows, if I check again, file icon...
kerem commented 2026-03-03 16:41:30 +03:00
Author
Owner
Copy link

@neilsardesai commented on GitHub (Mar 22, 2022):

@agencetwogether I’m not sure I really understand. Would you mind posting another screen recording?

<!-- gh-comment-id:1074551979 --> @neilsardesai commented on GitHub (Mar 22, 2022): @agencetwogether I’m not sure I really understand. Would you mind posting another screen recording?
kerem commented 2026-03-03 16:41:30 +03:00
Author
Owner
Copy link

@agencetwogether commented on GitHub (Mar 22, 2022):

Here, Pay your attention on the left sidebar of finder window

https://user-images.githubusercontent.com/53862310/159384192-2f169dd9-1c30-4ba8-aee5-0672c1e0132e.mov

<!-- gh-comment-id:1074553797 --> @agencetwogether commented on GitHub (Mar 22, 2022): Here, Pay your attention on the left sidebar of finder window https://user-images.githubusercontent.com/53862310/159384192-2f169dd9-1c30-4ba8-aee5-0672c1e0132e.mov
kerem commented 2026-03-03 16:41:30 +03:00
Author
Owner
Copy link

@neilsardesai commented on GitHub (Mar 22, 2022):

Oh whoops, that’s…certainly unexpected 🙃. Thanks for catching this. I’ve reverted version 1.0.2 back to 1.0.1, and will look into why the sidebar icon is changing here.

<!-- gh-comment-id:1074555579 --> @neilsardesai commented on GitHub (Mar 22, 2022): Oh whoops, that’s…certainly unexpected 🙃. Thanks for catching this. I’ve reverted version 1.0.2 back to 1.0.1, and will look into why the sidebar icon is changing here.
kerem commented 2026-03-03 16:41:30 +03:00
Author
Owner
Copy link

@neilsardesai commented on GitHub (Mar 22, 2022):

Hmm, from the documentation:

The sidebar icons you provide will replace the default folder icons in the Finder’s sidebar for any of the root folders that your extension is monitoring. This icon does not replace the icon for any folders contained by your monitored folder. It also does not replace the icon for any system folders that you may be monitoring (for example, Documents, Desktop, Applications, and Downloads).

(https://developer.apple.com/library/archive/documentation/General/Conceptual/ExtensibilityPG/Finder.html)

That’s a bit annoying. I’m not sure there’s any way around this. Seems like any root folder that’s not a system folder gets its sidebar icon automatically changed when a Finder extension is monitoring that folder 🙁

<!-- gh-comment-id:1075753593 --> @neilsardesai commented on GitHub (Mar 22, 2022): Hmm, from the documentation: > The sidebar icons you provide will replace the default folder icons in the Finder’s sidebar for any of the root folders that your extension is monitoring. This icon does not replace the icon for any folders contained by your monitored folder. It also does not replace the icon for any system folders that you may be monitoring (for example, Documents, Desktop, Applications, and Downloads). (https://developer.apple.com/library/archive/documentation/General/Conceptual/ExtensibilityPG/Finder.html) That’s a bit annoying. I’m not sure there’s any way around this. Seems like any root folder that’s not a system folder gets its sidebar icon automatically changed when a Finder extension is monitoring that folder 🙁
kerem commented 2026-03-03 16:41:30 +03:00
Author
Owner
Copy link

@sbarex commented on GitHub (Mar 23, 2022):

This is a common bug for all extensions that do not define an icon for the monitored folders (and unfortunately the icon must be unique for all folders, defined at the compilation time and not dynamically customizable).

Unfortunately I have the same problem with an extension I developed.

A temporary solution is to monitor the parent folder of the one placed in the finder bar. In the case of disks, perhaps you could monitor the /Volumes folder?

<!-- gh-comment-id:1076121990 --> @sbarex commented on GitHub (Mar 23, 2022): This is a common bug for all extensions that do not define an icon for the monitored folders (and unfortunately the icon must be unique for all folders, defined at the compilation time and not dynamically customizable). Unfortunately I have the same problem with an extension I developed. A temporary solution is to monitor the parent folder of the one placed in the finder bar. In the case of disks, perhaps you could monitor the `/Volumes` folder?
kerem commented 2026-03-03 16:41:31 +03:00
Author
Owner
Copy link

@neilsardesai commented on GitHub (Mar 25, 2022):

A temporary solution is to monitor the parent folder of the one placed in the finder bar. In the case of disks, perhaps you could monitor the /Volumes folder?

@sbarex have you had success with this? I tried FIFinderSyncController.default().directoryURLs = [URL(fileURLWithPath: "/Volumes")] but that caused the context menu to just not show up at all anywhere

<!-- gh-comment-id:1079105380 --> @neilsardesai commented on GitHub (Mar 25, 2022): > A temporary solution is to monitor the parent folder of the one placed in the finder bar. In the case of disks, perhaps you could monitor the `/Volumes` folder? @sbarex have you had success with this? I tried `FIFinderSyncController.default().directoryURLs = [URL(fileURLWithPath: "/Volumes")]` but that caused the context menu to just not show up at all anywhere
kerem commented 2026-03-03 16:41:31 +03:00
Author
Owner
Copy link

@sbarex commented on GitHub (Mar 25, 2022):

It hasn't happened to me to manage multiple internal disks. Normally I only monitor the "/" path or specific subfolders.

However handling the "/" path does not extend the control of external disks (USB or network). For external disks I manage the NSWorkspace.didMountNotification notification from which I get the url of the disk path:

@objc func handleMount(_ notification: NSNotification) {
    guard let volumeURL = notification.userInfo?[NSWorkspace.volumeURLUserInfoKey] as? URL else {
        return
    }
    let finderSync = FIFinderSyncController.default()
    finderSync.directoryURLs.insert(volumeURL)
}

So I think that in addition to the root path / the exact disk mount path should be monitored (like /Volumes/Disk2).

<!-- gh-comment-id:1079136470 --> @sbarex commented on GitHub (Mar 25, 2022): It hasn't happened to me to manage multiple internal disks. Normally I only monitor the "/" path or specific subfolders. However handling the "/" path does not extend the control of external disks (USB or network). For external disks I manage the `NSWorkspace.didMountNotification` notification from which I get the url of the disk path: ```swift @objc func handleMount(_ notification: NSNotification) { guard let volumeURL = notification.userInfo?[NSWorkspace.volumeURLUserInfoKey] as? URL else { return } let finderSync = FIFinderSyncController.default() finderSync.directoryURLs.insert(volumeURL) } ``` So I think that in addition to the root path `/` the exact disk mount path should be monitored (like `/Volumes/Disk2`).
kerem commented 2026-03-03 16:41:31 +03:00
Author
Owner
Copy link

@noChillGrandma commented on GitHub (Sep 8, 2022):

same problem, manila won't show on context menu of an external drive. Hopefully 1.0.2 is released soon as mentioned above.

<!-- gh-comment-id:1240552304 --> @noChillGrandma commented on GitHub (Sep 8, 2022): same problem, manila won't show on context menu of an external drive. Hopefully 1.0.2 is released soon as mentioned above.
kerem commented 2026-03-03 16:41:31 +03:00
Author
Owner
Copy link

@frag-p commented on GitHub (Dec 24, 2023):

hello - are there any solutions now? I have the same issues since updating to MacOS Sonoma - I miss this app so much!!!

<!-- gh-comment-id:1868578945 --> @frag-p commented on GitHub (Dec 24, 2023): hello - are there any solutions now? I have the same issues since updating to MacOS Sonoma - I miss this app so much!!!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v1.0.2
v1.0.1
v1.0
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Manila#2
No description provided.