mirror of
https://github.com/LiveContainer/LiveContainer.git
synced 2026-04-26 01:25:52 +03:00
[GH-ISSUE #624] [BUG] App Icon #555
Labels
No labels
bug
compatibility
enhancement
multitasking
pull-request
safe area
status: broken
status: usable
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/LiveContainer#555
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Maxpro131 on GitHub (Jun 25, 2025).
Original GitHub issue: https://github.com/LiveContainer/LiveContainer/issues/624
Describe the bug
The dark mode icon is fine, but the bright mode has this white stuff in the corners. Besides that is the LiveContainer2 icon the same as the main one
Instructions to reproduce
Download nightly release (02e20b0) and install LiveContainer and LiveContainer2. Switch between dark and bright mode and see the result
What version of LiveContainer and iOS are you using?
Nightly release (02e20b0); iOS 18.3.1
Other info
No response
@abrhst commented on GitHub (Jun 25, 2025):
How do you have a dark LiveContainer icon in the first place? It doesn’t work for me
@Maxpro131 commented on GitHub (Jun 25, 2025):
Are you on iOS 18?
@abrhst commented on GitHub (Jun 25, 2025):
Yes, but I just noticed you are using a fork of LiveContainer and not the one from this repo and that’s how you have the icon
@Maxpro131 commented on GitHub (Jun 25, 2025):
No, I don’t? And you can do it by editing your home screen, then tap on edit in the top left corner. After that on the middle button and there you can select dark mode
@Maxpro131 commented on GitHub (Jun 25, 2025):
Idk why GitHub says that, but it has the same commit Id. GitHub may say the commit is from another repo, but I downloaded the ipa 100% from this repo
@m1337v commented on GitHub (Jun 25, 2025):
you probably downloaded with nightly.link and the latest action, which is my PR
@Maxpro131 commented on GitHub (Jun 25, 2025):
No I didn't. I added this link to my favorites in Safari to quick access the nightly builds:
https://github.com/LiveContainer/LiveContainer/actions
As you can see it's the right one
@m1337v commented on GitHub (Jun 25, 2025):
you did exactly what I said.
When you open a pull request, it runs the action to see if it compiles. The latest action is my PR.
This PR is not merged yet.
If you want nightly releases better add this as a bookmark: https://github.com/LiveContainer/LiveContainer/releases/tag/nightly
But thanks for reporting, will update the PR
@Maxpro131 commented on GitHub (Jun 25, 2025):
Oh, sorry I thought you were the one who always said I downloaded it from a fork. But I thought GitHub only shows the ✅ in actions if it is merged
@m1337v commented on GitHub (Jun 25, 2025):
should be fixed now in the latest action
@Maxpro131 commented on GitHub (Jun 25, 2025):
The white stuff in the corners is less noticable, but when leaving the app it is clearly visible. And the LiveContainer2 icon is still the same as the main one
@m1337v commented on GitHub (Jun 25, 2025):
where exactly do you see the issue when leaving the app? can you make a recording?
the livecontainer2 probably still uses the old build
@Maxpro131 commented on GitHub (Jun 25, 2025):
GitHub always fails to upload. I uploaded it on imgur
https://imgur.com/a/H4M6yTw
@Maxpro131 commented on GitHub (Jun 25, 2025):
And the same happens with the main LiveContainer. Forgot to show in the video
@abrhst commented on GitHub (Jun 25, 2025):
For me I don’t have this problem on the original LiveContainer so it probably is a problem with the fork (iOS 26 beta 2)
@Maxpro131 commented on GitHub (Jun 25, 2025):
I'm on iOS 18.3.1
@m1337v commented on GitHub (Jun 25, 2025):
I see the issue now. I had reduce motion enabled so the closing effect was missing.
Latest commit should fix it
@Maxpro131 commented on GitHub (Jun 26, 2025):
Nice. Now only the LiveContainer2 icon needs to be fixed. Can you make it look like the original? And add a dark mode icon for it?
@m1337v commented on GitHub (Jun 26, 2025):
Works with LC2 too. You may need to install LC2 with sidestore again so it applies the icon
https://github.com/user-attachments/assets/964f7057-1a51-4048-ab28-f164015272b8
@Maxpro131 commented on GitHub (Jun 26, 2025):
No, it works fine, but the icon should be grey
@hugeBlack commented on GitHub (Jun 26, 2025):
Since there are discussions here already, I'll directly write here.
@m1337v Thank you for enhancing our icon. It looks great! Here are few suggestions:
@hugeBlack commented on GitHub (Jun 26, 2025):
@m1337v
4. please remove UIApplicationExitsOnSuspend key and the launch storyboard
@m1337v commented on GitHub (Jun 26, 2025):
@hugeBlack done.
Just for the grey icon i can't figure out how to apply darkmode there as well, so it falls back to the hardcoded icons in /Resources
My approaches:
If you have an idea let me know, otherwise it will stay gray like before for now