starred/LiveContainer
1
0
Fork 0
mirror of https://github.com/LiveContainer/LiveContainer.git synced 2026-04-25 09:05:53 +03:00
Code Issues 37 Projects Releases 5 Packages Wiki Activity

[PR #623] [MERGED] Add Darkmode Icon and better resolution for Main Icon #1109

New issue
Closed
opened 2026-03-03 15:38:35 +03:00 by kerem · 0 comments
kerem commented 2026-03-03 15:38:35 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/LiveContainer/LiveContainer/pull/623
Author: @m1337v
Created: 6/25/2025
Status: ✅ Merged
Merged: 6/26/2025
Merged by: @hugeBlack

Base: main ← Head: darkmode

📝 Commits (6)

  • 58c6481 add darkmode icon - blue
  • 5a14244 fix main icon scale
  • df1e5f5 fix white border in lightmode
  • f488c75 storyboard
  • 66a091c add storyboard, remove alpha from icon
  • 9d3c85f revert changes in UIApplicationSceneManifest, remove UIApplicationExitsOnSuspend key, remove launch storyboard

📊 Changes

11 files changed (+74 additions, -27 deletions)

View changed files

📝 LiveContainerSwiftUI/LCUtils.m (+7 -0)
📝 Resources/AppIcon60x60_2.png (+0 -0)
📝 Resources/AppIcon76x76_2.png (+0 -0)
➕ Resources/AppIconGrey.png (+0 -0)
➕ Resources/Assets.xcassets/AppIcon.appiconset/AppIcon1024.png (+0 -0)
➕ Resources/Assets.xcassets/AppIcon.appiconset/AppIconDark1024.png (+0 -0)
📝 Resources/Assets.xcassets/AppIcon.appiconset/Contents.json (+25 -1)
➕ Resources/Assets.xcassets/AppIconGrey.appiconset/AppIconGrey1024.png (+0 -0)
➕ Resources/Assets.xcassets/AppIconGrey.appiconset/AppIconGreyDark1024.png (+0 -0)
➕ Resources/Assets.xcassets/AppIconGrey.appiconset/Contents.json (+37 -0)
📝 Resources/Info.plist (+5 -26)

📄 Description

I noticed when using the darkmode for icons LC still has the regular icon.
With this PR it gets a darkmode icon and in addition to that the main icon now has a better resolution as it's based on a higher resolution image.

see the comparison (left regular LC - right LC after PR):
darkmode:
IMG_0734

lightmode (better resolution):
IMG_0738

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LiveContainer/LiveContainer/pull/623 **Author:** [@m1337v](https://github.com/m1337v) **Created:** 6/25/2025 **Status:** ✅ Merged **Merged:** 6/26/2025 **Merged by:** [@hugeBlack](https://github.com/hugeBlack) **Base:** `main` ← **Head:** `darkmode` --- ### 📝 Commits (6) - [`58c6481`](https://github.com/LiveContainer/LiveContainer/commit/58c648139f9e7f2222757579381e10d65a5f7267) add darkmode icon - blue - [`5a14244`](https://github.com/LiveContainer/LiveContainer/commit/5a14244d8482c3ede65d6bb710591f3fc61229d0) fix main icon scale - [`df1e5f5`](https://github.com/LiveContainer/LiveContainer/commit/df1e5f5b4f22317332536d7053b837f96bf8033c) fix white border in lightmode - [`f488c75`](https://github.com/LiveContainer/LiveContainer/commit/f488c7560d228538ff0ab3c5acf4dcbd9be2ca01) storyboard - [`66a091c`](https://github.com/LiveContainer/LiveContainer/commit/66a091c8e0ab687ca964ff2849991bc9d9b64d3e) add storyboard, remove alpha from icon - [`9d3c85f`](https://github.com/LiveContainer/LiveContainer/commit/9d3c85f8f388e3562dccc91c70432c723912dc8a) revert changes in UIApplicationSceneManifest, remove UIApplicationExitsOnSuspend key, remove launch storyboard ### 📊 Changes **11 files changed** (+74 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `LiveContainerSwiftUI/LCUtils.m` (+7 -0) 📝 `Resources/AppIcon60x60_2.png` (+0 -0) 📝 `Resources/AppIcon76x76_2.png` (+0 -0) ➕ `Resources/AppIconGrey.png` (+0 -0) ➕ `Resources/Assets.xcassets/AppIcon.appiconset/AppIcon1024.png` (+0 -0) ➕ `Resources/Assets.xcassets/AppIcon.appiconset/AppIconDark1024.png` (+0 -0) 📝 `Resources/Assets.xcassets/AppIcon.appiconset/Contents.json` (+25 -1) ➕ `Resources/Assets.xcassets/AppIconGrey.appiconset/AppIconGrey1024.png` (+0 -0) ➕ `Resources/Assets.xcassets/AppIconGrey.appiconset/AppIconGreyDark1024.png` (+0 -0) ➕ `Resources/Assets.xcassets/AppIconGrey.appiconset/Contents.json` (+37 -0) 📝 `Resources/Info.plist` (+5 -26) </details> ### 📄 Description I noticed when using the darkmode for icons LC still has the regular icon. With this PR it gets a darkmode icon and in addition to that the main icon now has a better resolution as it's based on a higher resolution image. see the comparison (left regular LC - right LC after PR): darkmode: ![IMG_0734](https://github.com/user-attachments/assets/0ba75592-7d6b-4416-a21f-e903c661c09a) lightmode (better resolution): ![IMG_0738](https://github.com/user-attachments/assets/39320d2e-050b-49ad-bf7b-fa554a815d27) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:38:35 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
multitask-experimental
SecuritySignerPOC
externalstorage-poc
jitless
nightly
3.7.2
3.7.0
3.6.1
3.6.0
3.5.1
3.5.0
3.4.0
3.3.1
3.3.0
3.2.0
3.1.0
3.0.0
2.1.2
2.1.1
2.1
2.0-pre
1.0
Labels
Clear labels   
bug

   
compatibility

   
enhancement

   
multitasking

   
pull-request

Mirrored from GitHub Pull Request

  
safe area

   
status: broken

   
status: usable

   
wontfix
No labels
bug
compatibility
enhancement
multitasking
pull-request
safe area
status: broken
status: usable
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LiveContainer#1109
No description provided.