mirror of
https://github.com/LiveContainer/LiveContainer.git
synced 2026-04-25 09:05:53 +03:00
[PR #129] [MERGED] Allow "Open In App" for Apps inside LiveContainer & Remove Data Folder after Uninstalling #1065
Labels
No labels
bug
compatibility
enhancement
multitasking
pull-request
safe area
status: broken
status: usable
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/LiveContainer#1065
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/LiveContainer/LiveContainer/pull/129
Author: @hugeBlack
Created: 8/18/2024
Status: ✅ Merged
Merged: 8/30/2024
Merged by: @khanhduytran0
Base:
main← Head:main📝 Commits (7)
7c8a532user can input urlb443e88almost working8cc56afallow open web page with url schemes.f5bad50fix not working at first launch91529adAllow deleting data folder when uninstalling. Removed some debug NSLog.ef77c1afix some url handling logic65557d2allow other actions reach guest app📊 Changes
15 files changed (+437 additions, -18 deletions)
View changed files
📝
LCSharedUtils.h(+1 -1)📝
LCSharedUtils.m(+4 -0)📝
LiveContainerUI/LCAppDelegate.m(+12 -0)📝
LiveContainerUI/LCAppInfo.h(+3 -2)📝
LiveContainerUI/LCAppInfo.m(+26 -1)📝
LiveContainerUI/LCAppListViewController.h(+1 -0)📝
LiveContainerUI/LCAppListViewController.m(+117 -1)📝
LiveContainerUI/LCTabBarController.h(+3 -0)📝
LiveContainerUI/LCTabBarController.m(+5 -1)➕
LiveContainerUI/LCWebView.h(+11 -0)➕
LiveContainerUI/LCWebview.m(+150 -0)📝
LiveContainerUI/Makefile(+1 -1)📝
TweakLoader/UIKit+GuestHooks.m(+86 -11)📝
UIKitPrivate.h(+1 -0)📝
main.m(+16 -0)📄 Description
I sometimes need to open a link to an app inside LiveContainer, a Spotify album for example, and it's a pain that "Open In App" button doesn't work for apps inside LiveContainer. https://github.com/khanhduytran0/LiveContainer/issues/119
In this PR, I implemented the feature that users can share a Safari page or link to LiveContainer. LiveContainer will open a WKWebView to show these pages and users can click "Open In App" button to open specific apps inside LiveContainer. LiveContainer will intercept that navigation, open the specific app and pass URL scheme to that app.
What's more, I added a link button on the top left corner so users can manually input the URL of a web page or a URL scheme.
I made a Shortcut to accomplish the Safari sharing feature, you can download and have a try: https://www.icloud.com/shortcuts/44ea82ce7ed8469ea24198c375db09a0
P.S. I'm pretty new to Objc so please forgive my dumb code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.