[GH-ISSUE #1228] unzip is not a required dependency, yet fn_dl_extract uses it #957

Closed
opened 2026-02-27 02:54:30 +03:00 by kerem · 8 comments
Owner

Originally created by @braunsonm on GitHub (Jan 5, 2017).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1228

unzip is used to extract .zip files, yet LGSM does not install or check it as a dependency.

github.com/GameServerManagers/LinuxGSM@34d2c96bec/lgsm/functions/core_dl.sh (L65)

Originally created by @braunsonm on GitHub (Jan 5, 2017). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1228 unzip is used to extract .zip files, yet LGSM does not install or check it as a dependency. https://github.com/GameServerManagers/LinuxGSM/blob/34d2c96becbe3d7a0c81688ead460cdba17abac9/lgsm/functions/core_dl.sh#L65
kerem 2026-02-27 02:54:30 +03:00
Author
Owner

@dgibbs64 commented on GitHub (Jan 5, 2017):

I dont believe there are any files that use zip within LGSM. I ensured they are all .tar.bz2 because of this zip is not a requirement. Only Unreal used to use zip until I changed it.

<!-- gh-comment-id:270782282 --> @dgibbs64 commented on GitHub (Jan 5, 2017): I dont believe there are any files that use zip within LGSM. I ensured they are all .tar.bz2 because of this zip is not a requirement. Only Unreal used to use zip until I changed it.
Author
Owner

@braunsonm commented on GitHub (Jan 5, 2017):

But if you have the functionality to extract zip files on that function, you need the unzip dependency.

Zip is required on this pull request:
https://github.com/GameServerManagers/LinuxGSM/pull/1224

<!-- gh-comment-id:270782880 --> @braunsonm commented on GitHub (Jan 5, 2017): But if you have the functionality to extract zip files on that function, you need the unzip dependency. Zip is required on this pull request: https://github.com/GameServerManagers/LinuxGSM/pull/1224
Author
Owner

@dgibbs64 commented on GitHub (Jan 5, 2017):

I see then it would be a requirement for the specific game rather than a general requirement as no servers require it apart from Multi Theft Auto.

Good work btw. Sorry im quite slow with dev stuff currently I have loads on (still). I will review your work as soon as I actually get some time :)

<!-- gh-comment-id:270784953 --> @dgibbs64 commented on GitHub (Jan 5, 2017): I see then it would be a requirement for the specific game rather than a general requirement as no servers require it apart from Multi Theft Auto. Good work btw. Sorry im quite slow with dev stuff currently I have loads on (still). I will review your work as soon as I actually get some time :)
Author
Owner

@braunsonm commented on GitHub (Jan 5, 2017):

But then why is tar a LGSM requirement, yet no server on master uses it?

I'm just a bit confused about the inconsistency. I will adjust it to be a MTA requirement only if that's what you'd like though.

<!-- gh-comment-id:270789746 --> @braunsonm commented on GitHub (Jan 5, 2017): But then why is tar a LGSM requirement, yet no server on master uses it? I'm just a bit confused about the inconsistency. I will adjust it to be a MTA requirement only if that's what you'd like though.
Author
Owner

@UltimateByte commented on GitHub (Jan 6, 2017):

SteamCMD comes in a tar file if i remember well.
BTW, @dgibbs64 unzip as a requirement is a good idea since it's a pretty common package and mods installations will usually be made from zip files.

<!-- gh-comment-id:270800618 --> @UltimateByte commented on GitHub (Jan 6, 2017): SteamCMD comes in a tar file if i remember well. BTW, @dgibbs64 unzip as a requirement is a good idea since it's a pretty common package and mods installations will usually be made from zip files.
Author
Owner

@cedarlug commented on GitHub (Jan 6, 2017):

Looks like UT (still?) requires it, too:

cia@cryptbookpro:~/LinuxGSM$ grep -d recurse \\.zip .
./lgsm/functions/install_server_files.sh:               fileurl="http://files.gameservermanagers.com/UnrealTournament/UnrealTournament-Server-XAN-3045522-Linux.zip"; filedir="${tmpdir}"; filename="UnrealTournament-Server-XAN-3045522-Linux.zip";  executecmd="noexecute" run="norun"; force="noforce"; md5="553fed5645a9fc623e92563049bf79f6"
<!-- gh-comment-id:270803068 --> @cedarlug commented on GitHub (Jan 6, 2017): Looks like UT (still?) requires it, too: ```bash cia@cryptbookpro:~/LinuxGSM$ grep -d recurse \\.zip . ./lgsm/functions/install_server_files.sh: fileurl="http://files.gameservermanagers.com/UnrealTournament/UnrealTournament-Server-XAN-3045522-Linux.zip"; filedir="${tmpdir}"; filename="UnrealTournament-Server-XAN-3045522-Linux.zip"; executecmd="noexecute" run="norun"; force="noforce"; md5="553fed5645a9fc623e92563049bf79f6" ```
Author
Owner

@dgibbs64 commented on GitHub (Jan 15, 2017):

https://github.com/GameServerManagers/LinuxGSM/pull/1229

<!-- gh-comment-id:272717941 --> @dgibbs64 commented on GitHub (Jan 15, 2017): https://github.com/GameServerManagers/LinuxGSM/pull/1229
Author
Owner

@lock[bot] commented on GitHub (Jul 19, 2018):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:406119575 --> @lock[bot] commented on GitHub (Jul 19, 2018): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#957
No description provided.