starred/LinuxGSM

Fork 0

mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-26 06:35:54 +03:00

[GH-ISSUE #1030] [mcserver] Incorrect or missing output by starting? #815

New issue

Closed

opened 2026-02-27 02:53:41 +03:00 by kerem · 17 comments

kerem commented

2026-02-27 02:53:41 +03:00

Owner

Originally created by @Sebbo94BY on GitHub (Aug 25, 2016).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1030

I've just noticed, that after each colon is something written like "OK". If you start the mcserver, it seems like, that there is a message/output missing:

mcserver@lgsm-debian8:$ ./mcserver start
[ WARN ] Starting mc-server: Check RAM: 1G required, 986M available
* Minecraft server may fail to run or experience poor performance.
[ OK ] Starting mc-server:
mcserver@lgsm-debian8:$

Shouldn't be there an "OK" or something like that? If not, I would like to suggest, to remove this colon to prevent irritated users.

Originally created by @Sebbo94BY on GitHub (Aug 25, 2016). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/1030 I've just noticed, that after each colon is something written like "OK". If you start the mcserver, it seems like, that there is a message/output missing: > mcserver@lgsm-debian8:~$ ./mcserver start > [ WARN ] Starting mc-server: Check RAM: 1G required, 986M available > \* Minecraft server may fail to run or experience poor performance. > [ OK ] Starting mc-server: > mcserver@lgsm-debian8:~$ Shouldn't be there an "OK" or something like that? If not, I would like to suggest, to remove this colon to prevent irritated users.

kerem

2026-02-27 02:53:41 +03:00

closed this issue
added the
type: feature
label

kerem commented

2026-02-27 02:53:41 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 25, 2016):

@dgibbs64 Told ya ! :p

@UltimateByte commented on GitHub (Aug 25, 2016): @dgibbs64 Told ya ! :p

kerem commented

2026-02-27 02:53:41 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Aug 25, 2016):

Blame Minecraft not having a server name like every other game server

@dgibbs64 commented on GitHub (Aug 25, 2016): Blame Minecraft not having a server name like every other game server

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 26, 2016):

So...
https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/info_config.sh#L71

Easy workaround to minecraft having no server name is to add
servername="Minecraft Server"

Should we do it ?

PS @Sebi94nbg There should be the server name after : , and as far as i know, there is none for MC, that's why it's left blank. The problem here is that we won't rewrite the whole function just for MC, and it can be confusing to add a generic name as well as it doesn't respect LGSM's standards.

@UltimateByte commented on GitHub (Aug 26, 2016): So... https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/info_config.sh#L71 Easy workaround to minecraft having no server name is to add `servername="Minecraft Server"` Should we do it ? PS @Sebi94nbg There should be the server name after `:` , and as far as i know, there is none for MC, that's why it's left blank. The problem here is that we won't rewrite the whole function just for MC, and it can be confusing to add a generic name as well as it doesn't respect LGSM's standards.

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@cedarlug commented on GitHub (Aug 26, 2016):

I'm not one to encourage defining variables that are exposed at the top level way down deep in the functional plumbing.

A reasonable approach would be to set
: ${servername:="Minecraft Server"}
so that if there ever was a way to set servername in the top-level script, this assignment under-the-hood would be ignored.

@cedarlug commented on GitHub (Aug 26, 2016): I'm not one to encourage defining variables that are exposed at the top level way down deep in the functional plumbing. A reasonable approach would be to set `: ${servername:="Minecraft Server"}` so that if there ever was a way to set servername in the top-level script, this assignment under-the-hood would be ignored.

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@Sebbo94BY commented on GitHub (Aug 26, 2016):

I'm not sure, but as far as I can remember myself, the motd variable is used as servername. If you search for your server, you'll see that message, the counter of max. players and the status of this server.

motd=A Minecraft Server

However, this value could be used instead of displaying nothing or setting a static variable somewhere.

@Sebbo94BY commented on GitHub (Aug 26, 2016): I'm not sure, but as far as I can remember myself, the _motd_ variable is used as servername. If you search for your server, you'll see that message, the counter of max. players and the status of this server. `motd=A Minecraft Server` However, this value could be used instead of displaying nothing or setting a static variable somewhere.

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 26, 2016):

There was a "server-name" settings in MC classic, but seems there is not anymore.
"motd" isn't a servername, and can take up to two lines using \n, which wouldn't be adapted.

@UltimateByte commented on GitHub (Aug 26, 2016): There was a "server-name" settings in MC classic, but seems there is not anymore. "motd" isn't a servername, and can take up to two lines using `\n`, which wouldn't be adapted.

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 26, 2016):

servername=${servername:-"Minecraft Server"}

servername=${servername:-"Generic Minecraft Servername as Minecraft doesn't allow to set a server name, sorry, there's nothing we can do about it, blame Minecraft, sorry again lololol"}

@UltimateByte commented on GitHub (Aug 26, 2016): `servername=${servername:-"Minecraft Server"}` Or `servername=${servername:-"Generic Minecraft Servername as Minecraft doesn't allow to set a server name, sorry, there's nothing we can do about it, blame Minecraft, sorry again lololol"}`

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@Sebbo94BY commented on GitHub (Aug 26, 2016):

lol. Clearly the second one! 👍

@Sebbo94BY commented on GitHub (Aug 26, 2016): lol. Clearly the second one! :+1:

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@JimTR commented on GitHub (Aug 26, 2016):

Just an odd point with minecraft motd the gameq php lib returns the motd as the server name and to a degree so does the minecraft interface

and gameq

and of course http://www.gameserverdirectory.com/search.php?q=37.122.211.130&players=&game=&bots=&country=&pwd=&map=&type=&version=&claimed=&tags=
so it may be worth considering it
motd = Minecraft Server Jims XX

@JimTR commented on GitHub (Aug 26, 2016): Just an odd point with minecraft motd the gameq php lib returns the motd as the server name and to a degree so does the minecraft interface ![mc1](https://cloud.githubusercontent.com/assets/4038510/18019929/71c0bb10-6bd6-11e6-83ea-65d7a9562b3f.png) and gameq ![gameq](https://cloud.githubusercontent.com/assets/4038510/18019936/801e76ac-6bd6-11e6-92a6-b2af9fa3a00b.png) and of course [http://www.gameserverdirectory.com/search.php?q=37.122.211.130&players=&game=&bots=&country=&pwd=&map=&type=&version=&claimed=&tags=](url) so it may be worth considering it motd = Minecraft Server Jims XX

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@marvinlehmann commented on GitHub (Aug 26, 2016):

Then what about:

servername=$(grep "motd=" "${servercfgfullpath}" | sed 's/motd=//g' | tr -d '=\";' | sed 's/\\n/ /g')
(replace linebreaks with spaces)
or
servername=$(grep "motd=" "${servercfgfullpath}" | sed 's/motd=//g' | tr -d '=\";' | sed 's/\\n.*//g')
(only use first line)

@marvinlehmann commented on GitHub (Aug 26, 2016): Then what about: `servername=$(grep "motd=" "${servercfgfullpath}" | sed 's/motd=//g' | tr -d '=\";' | sed 's/\\n/ /g')` (replace linebreaks with spaces) or `servername=$(grep "motd=" "${servercfgfullpath}" | sed 's/motd=//g' | tr -d '=\";' | sed 's/\\n.*//g')` (only use first line)

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 26, 2016):

I'd go for first line only, otherwise it could be too long.
Let's add it :D

@UltimateByte commented on GitHub (Aug 26, 2016): I'd go for first line only, otherwise it could be too long. Let's add it :D

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@JimTR commented on GitHub (Aug 26, 2016):

There is also the point that if the install routine shuts motd to one line there is a chance it will be buried in server.properties & get forgotten

@JimTR commented on GitHub (Aug 26, 2016): There is also the point that if the install routine shuts motd to one line there is a chance it will be buried in server.properties & get forgotten

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@Sebbo94BY commented on GitHub (Aug 26, 2016):

Just a bit shorter:
grep "motd=" "${servercfgfullpath}" | cut -d '=' -f 2 | sed 's/\\n/ /g'

@Sebbo94BY commented on GitHub (Aug 26, 2016): Just a bit shorter: `grep "motd=" "${servercfgfullpath}" | cut -d '=' -f 2 | sed 's/\\n/ /g'`

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 26, 2016):

@JimTR Went for the one line !
@Sebi94nbg Let's stick with set | tr for coherence with other ones. :o))

Look how beautiful it is ! :o))

@UltimateByte commented on GitHub (Aug 26, 2016): @JimTR Went for the one line ! @Sebi94nbg Let's stick with set | tr for coherence with other ones. :o)) Look how beautiful it is ! :o)) ![Image of mcserver](http://image.noelshack.com/fichiers/2016/34/1472248463-mcserver-has-a-name.png)

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 26, 2016):

Well, everyone can now run ./mcserver uf and go home :o))
Bar is closing, cya ! :o))

@UltimateByte commented on GitHub (Aug 26, 2016): Well, everyone can now run ./mcserver uf and go home :o)) Bar is closing, cya ! :o))

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@JimTR commented on GitHub (Aug 26, 2016):

oddly if you add /n to produce a second line gameq ignores it & makes it a one liner but the minecraft interface adds the line break so I guess you need to make people aware on install as to the different properties ... but I guess one line is good

@JimTR commented on GitHub (Aug 26, 2016): oddly if you add /n to produce a second line gameq ignores it & makes it a one liner but the minecraft interface adds the line break so I guess you need to make people aware on install as to the different properties ... but I guess one line is good

kerem commented

2026-02-27 02:53:42 +03:00

Author

Owner

@lock[bot] commented on GitHub (Jul 19, 2018):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock[bot] commented on GitHub (Jul 19, 2018): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.