[GH-ISSUE #964] [gsquery] TypeError #768

New issue

Closed

opened 2026-02-27 02:53:23 +03:00 by kerem · 4 comments

kerem commented

2026-02-27 02:53:23 +03:00

Owner

Originally created by @m-rousse on GitHub (Aug 2, 2016).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/964

Originally assigned to: @UltimateByte on GitHub.

After a fresh installation of a TeamFortress2 server, I was not able to monitor it :

[testlgsm@myserver:~/TF2]$ ./tf2server start
[  OK  ] Starting tf2-server: Test Server LGSM
[testlgsm@myserver:~/TF2]$ ./tf2server monitor
[  OK  ] Monitor tf2-server: Checking session: OK
[ FAIL ] Monitor tf2-server: Querying port: 10.240.0.1:27015 : 0/1 : Traceback (most recent call last):
  File "/home/testlgsm/TF2/lgsm/functions/gsquery.py", line 125, in <module>
    server.responding()
  File "/home/testlgsm/TF2/lgsm/functions/gsquery.py", line 61, in responding
    connection.send( self.query_prompt_string )
...
[ FAIL ] Monitor tf2-server: Querying port: 10.240.0.1:27015 : 3/1 : Traceback (most recent call last):
  File "/home/testlgsm/TF2/lgsm/functions/gsquery.py", line 125, in <module>
    server.responding()
  File "/home/testlgsm/TF2/lgsm/functions/gsquery.py", line 61, in responding
    connection.send( self.query_prompt_string )

I patched it by adding a b in front of the query strings in gsquery.py :

       self.query_prompt_string = b'\xFF\xFF\xFF\xFFTSource Engine Query\0'
elif self.option.engine == 'goldsource':
       self.query_prompt_string = b'\xFF\xFF\xFF\xFFTSource Engine Query\0'
       ...
elif self.option.engine == 'avalanche':
       self.query_prompt_string = b'\xFE\xFD\x09\x10\x20\x30\x40'

I am using python 3.5.2.
Is it really an issue, should I send a Pull-Request of this small fix ?

Best regards, Mathieu

Originally created by @m-rousse on GitHub (Aug 2, 2016). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/964 Originally assigned to: @UltimateByte on GitHub. After a fresh installation of a TeamFortress2 server, I was not able to monitor it : ``` sh [testlgsm@myserver:~/TF2]$ ./tf2server start [ OK ] Starting tf2-server: Test Server LGSM [testlgsm@myserver:~/TF2]$ ./tf2server monitor [ OK ] Monitor tf2-server: Checking session: OK [ FAIL ] Monitor tf2-server: Querying port: 10.240.0.1:27015 : 0/1 : Traceback (most recent call last): File "/home/testlgsm/TF2/lgsm/functions/gsquery.py", line 125, in <module> server.responding() File "/home/testlgsm/TF2/lgsm/functions/gsquery.py", line 61, in responding connection.send( self.query_prompt_string ) ... [ FAIL ] Monitor tf2-server: Querying port: 10.240.0.1:27015 : 3/1 : Traceback (most recent call last): File "/home/testlgsm/TF2/lgsm/functions/gsquery.py", line 125, in <module> server.responding() File "/home/testlgsm/TF2/lgsm/functions/gsquery.py", line 61, in responding connection.send( self.query_prompt_string ) ``` I patched it by adding a b in front of the query strings in gsquery.py : ``` python self.query_prompt_string = b'\xFF\xFF\xFF\xFFTSource Engine Query\0' elif self.option.engine == 'goldsource': self.query_prompt_string = b'\xFF\xFF\xFF\xFFTSource Engine Query\0' ... elif self.option.engine == 'avalanche': self.query_prompt_string = b'\xFE\xFD\x09\x10\x20\x30\x40' ``` I am using python 3.5.2. Is it really an issue, should I send a Pull-Request of this small fix ? Best regards, Mathieu

kerem

2026-02-27 02:53:23 +03:00

closed this issue
added the
type: bug
label

kerem commented

2026-02-27 02:53:23 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 2, 2016):

Hey,

Well, this function has been developped for python 2.x.
The only question is : Would this change break compatibility with older versions ?
I'm gonna try it. :)

@UltimateByte commented on GitHub (Aug 2, 2016): Hey, Well, this function has been developped for python 2.x. The only question is : Would this change break compatibility with older versions ? I'm gonna try it. :)

kerem commented

2026-02-27 02:53:23 +03:00

Author

Owner

@UltimateByte commented on GitHub (Aug 2, 2016):

Python version (currently v2.7).
Your fix works with it. Nice catch !
Don't bother, i'll pull request the change. :)

@UltimateByte commented on GitHub (Aug 2, 2016): `Python version (currently v2.7).` Your fix works with it. Nice catch ! Don't bother, i'll pull request the change. :)

kerem commented

2026-02-27 02:53:24 +03:00

Author

Owner

@m-rousse commented on GitHub (Aug 2, 2016):

Perfect, thank you :)

@m-rousse commented on GitHub (Aug 2, 2016): Perfect, thank you :)

kerem commented

2026-02-27 02:53:24 +03:00

Author

Owner

@lock[bot] commented on GitHub (Jul 19, 2018):

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock[bot] commented on GitHub (Jul 19, 2018): This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.