[PR #4854] fix (alerts): Alerts on update uses the old game server version not the new one #4456

Open
opened 2026-02-27 04:55:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/4854
Author: @dgibbs64
Created: 11/10/2025
Status: 🔄 Open

Base: developHead: 4696-bug-discord-alert-on-update-uses-the-old-version-not-the-new-one


📝 Commits (10+)

  • cfa873c feat: refactor update comparison output for consistency and clarity
  • bdfc6e5 Refactor remote build version handling across multiple modules
  • 9c36976 fix(alert): resolve issue with servername not always being listed in title
  • 4d0d110 fix(alert_discord): remove "More info" field from Discord alert JSON
  • 6580b89 fix(alert): improve update alert messaging for clarity
  • 24183e7 Merge branch 'develop' into 4696-bug-discord-alert-on-update-uses-the-old-version-not-the-new-one
  • 7abedc4 remove inline
  • c707de8 fix(alert): Correct grammar in update alert message
  • e5026a8 typo
  • ee1dca9 fix(alert_discord): Add inline property to "Is my Game Server Online?" field

📊 Changes

186 files changed (+1156 additions, -1097 deletions)

View changed files

📝 .devcontainer/devcontainer.json (+28 -28)
📝 .editorconfig (+16 -1)
.github/linters/.codespellrc (+11 -0)
.github/linters/.flake8 (+2 -0)
.github/linters/.markdown-lint.yml (+23 -0)
.github/linters/.shellcheckrc (+1 -0)
.github/linters/.yaml-lint.yml (+25 -0)
📝 .github/pull_request_template.md (+15 -15)
📝 .github/workflows/action-super-linter.yml (+6 -3)
📝 .github/workflows/add-to-project.yml (+2 -0)
📝 .github/workflows/details-check-generate-matrix.sh (+6 -4)
📝 .github/workflows/details-check.yml (+5 -2)
📝 .github/workflows/git-sync.yml (+2 -0)
📝 .github/workflows/potential-duplicates.yml (+4 -0)
📝 .github/workflows/serverlist-validate-game-icons.sh (+8 -4)
📝 .github/workflows/serverlist-validate.sh (+6 -3)
📝 .github/workflows/serverlist-validate.yml (+3 -0)
📝 .github/workflows/trigger-docker-build.yml (+2 -0)
📝 .github/workflows/update-check.yml (+3 -1)
📝 .github/workflows/update-copyright-years-in-license-file.yml (+4 -0)

...and 80 more files

📄 Description

Description

Please include a summary of the change and which issues are fixed.

Fixes #[issue]

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/4854 **Author:** [@dgibbs64](https://github.com/dgibbs64) **Created:** 11/10/2025 **Status:** 🔄 Open **Base:** `develop` ← **Head:** `4696-bug-discord-alert-on-update-uses-the-old-version-not-the-new-one` --- ### 📝 Commits (10+) - [`cfa873c`](https://github.com/GameServerManagers/LinuxGSM/commit/cfa873c483ad1b3ae5c82fcf3e9cf84cd1a2c27a) feat: refactor update comparison output for consistency and clarity - [`bdfc6e5`](https://github.com/GameServerManagers/LinuxGSM/commit/bdfc6e5bd1737bbe525d3c91eb54a4c459409fdc) Refactor remote build version handling across multiple modules - [`9c36976`](https://github.com/GameServerManagers/LinuxGSM/commit/9c36976573aef1493c1da8c5cd64a4454943d83b) fix(alert): resolve issue with servername not always being listed in title - [`4d0d110`](https://github.com/GameServerManagers/LinuxGSM/commit/4d0d11010ab14cab11b0b452174de5c9bc0bd16f) fix(alert_discord): remove "More info" field from Discord alert JSON - [`6580b89`](https://github.com/GameServerManagers/LinuxGSM/commit/6580b89e8f03d396d11b4d834e3cdecf995ae747) fix(alert): improve update alert messaging for clarity - [`24183e7`](https://github.com/GameServerManagers/LinuxGSM/commit/24183e75ffeb3bd409f8f7e9e032f3d381abe225) Merge branch 'develop' into 4696-bug-discord-alert-on-update-uses-the-old-version-not-the-new-one - [`7abedc4`](https://github.com/GameServerManagers/LinuxGSM/commit/7abedc4dcc167cfe7e24de774b15846b2a10e19f) remove inline - [`c707de8`](https://github.com/GameServerManagers/LinuxGSM/commit/c707de8098197451f725fc00c245307676b75d2f) fix(alert): Correct grammar in update alert message - [`e5026a8`](https://github.com/GameServerManagers/LinuxGSM/commit/e5026a8235d5c52ee00f7d799dc63787591ca660) typo - [`ee1dca9`](https://github.com/GameServerManagers/LinuxGSM/commit/ee1dca9c3dff94d239097a93c6b316f89a5ebac7) fix(alert_discord): Add inline property to "Is my Game Server Online?" field ### 📊 Changes **186 files changed** (+1156 additions, -1097 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/devcontainer.json` (+28 -28) 📝 `.editorconfig` (+16 -1) ➕ `.github/linters/.codespellrc` (+11 -0) ➕ `.github/linters/.flake8` (+2 -0) ➕ `.github/linters/.markdown-lint.yml` (+23 -0) ➕ `.github/linters/.shellcheckrc` (+1 -0) ➕ `.github/linters/.yaml-lint.yml` (+25 -0) 📝 `.github/pull_request_template.md` (+15 -15) 📝 `.github/workflows/action-super-linter.yml` (+6 -3) 📝 `.github/workflows/add-to-project.yml` (+2 -0) 📝 `.github/workflows/details-check-generate-matrix.sh` (+6 -4) 📝 `.github/workflows/details-check.yml` (+5 -2) 📝 `.github/workflows/git-sync.yml` (+2 -0) 📝 `.github/workflows/potential-duplicates.yml` (+4 -0) 📝 `.github/workflows/serverlist-validate-game-icons.sh` (+8 -4) 📝 `.github/workflows/serverlist-validate.sh` (+6 -3) 📝 `.github/workflows/serverlist-validate.yml` (+3 -0) 📝 `.github/workflows/trigger-docker-build.yml` (+2 -0) 📝 `.github/workflows/update-check.yml` (+3 -1) 📝 `.github/workflows/update-copyright-years-in-license-file.yml` (+4 -0) _...and 80 more files_ </details> ### 📄 Description # Description Please include a summary of the change and which issues are fixed. Fixes #[issue] ## Type of change - [ ] Bug fix (a change which fixes an issue). - [ ] New feature (a change which adds functionality). - [ ] New Server (new server added). - [ ] Refactor (restructures existing code). - [ ] Comment update (typo, spelling, explanation, examples, etc). ## Checklist PR will not be merged until all steps are complete. - [ ] This pull request links to an issue. - [ ] This pull request uses the `develop` branch as its base. - [ ] This pull request subject follows the Conventional Commits standard. - [ ] This code follows the style guidelines of this project. - [ ] I have performed a self-review of my code. - [ ] I have checked that this code is commented where required. - [ ] I have provided a detailed enough description of this PR. - [ ] I have checked if documentation needs updating. ## Documentation If documentation does need updating either update it by creating a PR (preferred) or request a documentation update. - User docs: https://github.com/GameServerManagers/LinuxGSM-Docs - Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#4456
No description provided.