[PR #4352] [MERGED] refactor: remove ansi sequence from creeol when ansi=off #4316

New issue

Closed

opened 2026-02-27 04:54:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 04:54:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/4352
Author: @pirpyn
Created: 10/25/2023
Status: ✅ Merged
Merged: 10/28/2023
Merged by: @dgibbs64

Base: develop ← Head: develop

📝 Commits (1)

430d900 refactor: remove ansi sequence from creeol when ansi=off

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 lgsm/modules/core_messages.sh (+4 -2)

📄 Description

Description

fixes #3729

When using "ansi"="off", the escape sequence \033[K is still present and tools that input from lgsm will get thoses bytes.

This commit removes that.

One side-effect if two prints are done without a line feed and the second is shorter than the first, then some unwanted character could remain.

echo -en "${creeol}foo/bar"
echo -en "${creeol}foo"

before : prints "foo"
after: prints "foo/bar"

Type of change

Bug fix (a change which fixes an issue).
New feature (a change which adds functionality).
New Server (new server added).
Refactor (restructures existing code).
Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

This pull request links to an issue. (The bug is in the PR)
This pull request uses the develop branch as its base.
This pull request subject follows the Conventional Commits standard.
This code follows the style guidelines of this project.
I have performed a self-review of my code.
I have checked that this code is commented where required.
I have provided a detailed enough description of this PR.
I have checked if documentation needs updating.

Documentation

Yea, the ANSI doc is lacklust and should at least explains a little bit this option for non tech user
https://docs.linuxgsm.com/features/ansi-colors

Thank you for your Pull Request!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/4352 **Author:** [@pirpyn](https://github.com/pirpyn) **Created:** 10/25/2023 **Status:** ✅ Merged **Merged:** 10/28/2023 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (1) - [`430d900`](https://github.com/GameServerManagers/LinuxGSM/commit/430d9001337c0bd1dd49334a7fd4237bbe784c4c) refactor: remove ansi sequence from creeol when ansi=off ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/modules/core_messages.sh` (+4 -2) </details> ### 📄 Description # Description fixes #3729 When using "ansi"="off", the escape sequence \033[K is still present and tools that input from lgsm will get thoses bytes. ![image](https://github.com/GameServerManagers/LinuxGSM/assets/13225186/0001dc9c-4b68-4d57-a3a6-c50b666070e6) This commit removes that. ![image](https://github.com/GameServerManagers/LinuxGSM/assets/13225186/faf673c0-8d05-4e2b-856f-9e614a3db8c4) One side-effect if two prints are done without a line feed and the second is shorter than the first, then some unwanted character could remain. ``` echo -en "${creeol}foo/bar" echo -en "${creeol}foo" ``` * before : prints "foo" * after: prints "foo/bar" ## Type of change - [ ] Bug fix (a change which fixes an issue). - [ ] New feature (a change which adds functionality). - [ ] New Server (new server added). - [x] Refactor (restructures existing code). - [ ] Comment update (typo, spelling, explanation, examples, etc). ## Checklist PR will not be merged until all steps are complete. - [x] This pull request links to an issue. (The bug is in the PR) - [x] This pull request uses the `develop` branch as its base. - [ ] This pull request subject follows the Conventional Commits standard. - [ ] This code follows the style guidelines of this project. - [x] I have performed a self-review of my code. - [x] I have checked that this code is commented where required. - [x] I have provided a detailed enough description of this PR. - [ ] I have checked if documentation needs updating. ## Documentation Yea, the ANSI doc is lacklust and should at least explains a little bit this option for non tech user https://docs.linuxgsm.com/features/ansi-colors **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>