[PR #4345] [MERGED] feat: alerts refactor #4314

Closed
opened 2026-02-27 04:54:41 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/4345
Author: @dgibbs64
Created: 10/19/2023
Status: Merged
Merged: 10/22/2023
Merged by: @dgibbs64

Base: developHead: feature/alerts-refactor-2


📝 Commits (10+)

  • 2baf370 feat(alert): add new alert types
  • 6b596b6 Merge branch 'develop' into feature/alerts-refactor-2
  • 3b39c78 Merge branch 'develop' into feature/alerts-refactor-2
  • c8d2715 feat: remove more info if not enabled
  • 09dc2f4 refactor: refactor alert functions and add color codes
  • b3fafe8 feat: add colour to discord alert
  • 0805246 refactor: improve Pushbullet alert sending
  • c8893c2 feat: add alert icon and footer to Discord alerts
  • 00a6b22 refactor(alert): refactor alert functions
  • fde5515 feat: add first batch of icons

📊 Changes

286 files changed (+1139 additions, -296 deletions)

View changed files

.github/workflows/serverlist-validate-game-icons.sh (+40 -0)
📝 .github/workflows/serverlist-validate.sh (+16 -0)
📝 .github/workflows/serverlist-validate.yml (+3 -0)
📝 lgsm/config-default/config-lgsm/acserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/ahl2server/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/ahlserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/arkserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/arma3server/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/armarserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/atsserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/avserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/bb2server/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/bbserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/bdserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/bf1942server/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/bfvserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/bmdmserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/boserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/bsserver/_default.cfg (+3 -1)
📝 lgsm/config-default/config-lgsm/btlserver/_default.cfg (+3 -1)

...and 80 more files

📄 Description

Description

Refactor of LinuxGSM alerts

  • added icons to alerts (when supported)
  • More info now only shows up if enabled
  • Added server time to the alert
  • Further standardised alerts structure
  • added new alerts for wipe, stopping, starting and restarting.
  • Update alert will now trigger for every instance in multi instance setups
  • updated alert icons and messages
  • added colors (when supported)

Fixes #[issue]

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/4345 **Author:** [@dgibbs64](https://github.com/dgibbs64) **Created:** 10/19/2023 **Status:** ✅ Merged **Merged:** 10/22/2023 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `develop` ← **Head:** `feature/alerts-refactor-2` --- ### 📝 Commits (10+) - [`2baf370`](https://github.com/GameServerManagers/LinuxGSM/commit/2baf370f907250f3828194893594e80fe2441b63) feat(alert): add new alert types - [`6b596b6`](https://github.com/GameServerManagers/LinuxGSM/commit/6b596b6adfbd918c9b56c40d561907d660207ea5) Merge branch 'develop' into feature/alerts-refactor-2 - [`3b39c78`](https://github.com/GameServerManagers/LinuxGSM/commit/3b39c78dab978243c2824fa383334081cbdfd27e) Merge branch 'develop' into feature/alerts-refactor-2 - [`c8d2715`](https://github.com/GameServerManagers/LinuxGSM/commit/c8d271578c8fd8f4bf4bfe9e6245055a912578b3) feat: remove more info if not enabled - [`09dc2f4`](https://github.com/GameServerManagers/LinuxGSM/commit/09dc2f48c90489e9ca2adfdb13a905ca57e0efe4) refactor: refactor alert functions and add color codes - [`b3fafe8`](https://github.com/GameServerManagers/LinuxGSM/commit/b3fafe852192e28a1bdcf8950f68cd4c8beda49f) feat: add colour to discord alert - [`0805246`](https://github.com/GameServerManagers/LinuxGSM/commit/0805246011c4d571cb38a098a3f36311be8f12da) refactor: improve Pushbullet alert sending - [`c8893c2`](https://github.com/GameServerManagers/LinuxGSM/commit/c8893c23cfe5945f763ec1770ebc388adb364bc3) feat: add alert icon and footer to Discord alerts - [`00a6b22`](https://github.com/GameServerManagers/LinuxGSM/commit/00a6b222dca0a5d5b50c408cef3893e49cae2583) refactor(alert): refactor alert functions - [`fde5515`](https://github.com/GameServerManagers/LinuxGSM/commit/fde551532639c7fdf4c4d8407933db3077c8e29b) feat: add first batch of icons ### 📊 Changes **286 files changed** (+1139 additions, -296 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/serverlist-validate-game-icons.sh` (+40 -0) 📝 `.github/workflows/serverlist-validate.sh` (+16 -0) 📝 `.github/workflows/serverlist-validate.yml` (+3 -0) 📝 `lgsm/config-default/config-lgsm/acserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/ahl2server/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/ahlserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/arkserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/arma3server/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/armarserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/atsserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/avserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/bb2server/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/bbserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/bdserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/bf1942server/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/bfvserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/bmdmserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/boserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/bsserver/_default.cfg` (+3 -1) 📝 `lgsm/config-default/config-lgsm/btlserver/_default.cfg` (+3 -1) _...and 80 more files_ </details> ### 📄 Description # Description Refactor of LinuxGSM alerts - added icons to alerts (when supported) - More info now only shows up if enabled - Added server time to the alert - Further standardised alerts structure - added new alerts for wipe, stopping, starting and restarting. - Update alert will now trigger for every instance in multi instance setups - updated alert icons and messages - added colors (when supported) Fixes #[issue] ## Type of change - [ ] Bug fix (a change which fixes an issue). - [ ] New feature (a change which adds functionality). - [ ] New Server (new server added). - [x] Refactor (restructures existing code). - [ ] Comment update (typo, spelling, explanation, examples, etc). ## Checklist PR will not be merged until all steps are complete. - [x] This pull request links to an issue. - [x] This pull request uses the `develop` branch as its base. - [x] This pull request subject follows the Conventional Commits standard. - [x] This code follows the style guidelines of this project. - [x] I have performed a self-review of my code. - [x] I have checked that this code is commented where required. - [x] I have provided a detailed enough description of this PR. - [ ] I have checked if documentation needs updating. ## Documentation If documentation does need updating either update it by creating a PR (preferred) or request a documentation update. - User docs: https://github.com/GameServerManagers/LinuxGSM-Docs - Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 04:54:41 +03:00
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#4314
No description provided.