[PR #4140] [MERGED] fix(update-lgsm): incorrect wdir sometimes #4222

New issue

Closed

opened 2026-02-27 04:54:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 04:54:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/4140
Author: @jusito
Created: 3/13/2023
Status: ✅ Merged
Merged: 3/27/2023
Merged by: @dgibbs64

Base: develop ← Head: fix/update-lgsm

📝 Commits (1)

a84fec2 fix(update-lgsm): cd functionsdir but never back

📊 Changes

1 file changed (+40 additions, -38 deletions)

View changed files

📝 lgsm/functions/command_update_linuxgsm.sh (+40 -38)

📄 Description

Description

If lgsm updates itself it cds into functions directory but not back, this is in at least one case an issue.

Fixes #[issue] Discord LGSM cannot update itself, breaks when checking lgsm module
Got the same error some time ago as well: https://github.com/jusito/docker-ttt/issues/9

In the "files changed" it looks weird, basically I just wrapped the cd into ( cd ".."; do somethin), this ensures that even if it exits somewhere in between it will cd back if outside of the block.

Example to trigger the issue and also the validation that the pr will fix it:

Check the log before and after "a server is already installed" for the first log is shows function directory.

#!/bin/bash

set -euo pipefail

function stop_after_update() {
	pid="$1"
	while ! grep -F 'Checking Dependencies' gmodserver.log; do
		sleep 1s
	done
	kill "$pid"
	while ps -p "$pid" -o pid= > /dev/null 2>&1; do
		sleep 1s
	done
	if [ -d "./functions/lgsm/" ]; then
		echo "Issue: found folder $(pwd)/functions/lgsm"
	else
		echo "Solved: no folder $(pwd)/functions/lgsm"
	fi
}

(
	cd "$(dirname "$0")"
	if [ -d bugreport ]; then
		echo "please remove folder \"$(pwd)/bugreport\""
		exit 1
	fi
	mkdir bugreport
	(
		cd bugreport
		wget -O linuxgsm.sh "https://raw.githubusercontent.com/GameServerManagers/LinuxGSM/v23.1.0/linuxgsm.sh"
		chmod +x linuxgsm.sh
		(
			export LGSM_GITHUBUSER="GameServerManagers"
			export LGSM_GITHUBBRANCH="master"
			./linuxgsm.sh gmodserver
			sed -i 's/"v23.1.0"/"v21.5.1"/' ./gmodserver
			./gmodserver auto-install
		) | tee /dev/tty > gmodserver.log 2>&1 &
		stop_after_update "$!"
		mv gmodserver.log gmodserver.before.log

		rm -rf ../bugreport/lgsm

		(
			export LGSM_GITHUBUSER="jusito"
			export LGSM_GITHUBBRANCH="fix/update-lgsm"
			sed -i 's/"v23.1.0"/"v21.5.1"/' ./gmodserver
			./gmodserver auto-install
		) | tee /dev/tty > gmodserver.log 2>&1 &
		stop_after_update "$!"
		mv gmodserver.log gmodserver.after.log
	)
)

Type of change

Bug fix (a change which fixes an issue).
New feature (a change which adds functionality).
New Server (new server added).
Refactor (restructures existing code).
Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

This pull request links to an issue.
This pull request uses the develop branch as its base.
This pull request subject follows the Conventional Commits standard.
This code follows the style guidelines of this project.
I have performed a self-review of my code.
I have checked that this code is commented where required.
I have provided a detailed enough description of this PR.
I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

User docs: https://github.com/GameServerManagers/LinuxGSM-Docs
Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs

Thank you for your Pull Request!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/4140 **Author:** [@jusito](https://github.com/jusito) **Created:** 3/13/2023 **Status:** ✅ Merged **Merged:** 3/27/2023 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `develop` ← **Head:** `fix/update-lgsm` --- ### 📝 Commits (1) - [`a84fec2`](https://github.com/GameServerManagers/LinuxGSM/commit/a84fec2241c598c76b6ea1392186c8f64ae2c240) fix(update-lgsm): cd functionsdir but never back ### 📊 Changes **1 file changed** (+40 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/command_update_linuxgsm.sh` (+40 -38) </details> ### 📄 Description # Description If lgsm updates itself it cds into functions directory but not back, this is in at least one case an issue. Fixes #[issue] Discord LGSM cannot update itself, breaks when checking lgsm module Got the same error some time ago as well: https://github.com/jusito/docker-ttt/issues/9 ![image](https://user-images.githubusercontent.com/17811819/224748442-103c38ce-a249-4ecb-b844-f15bf9b8ba15.png) In the "files changed" it looks weird, basically I just wrapped the cd into ( cd ".."; do somethin), this ensures that even if it exits somewhere in between it will cd back if outside of the block. # Example to trigger the issue and also the validation that the pr will fix it: Check the log before and after "a server is already installed" for the first log is shows function directory. ```bash #!/bin/bash set -euo pipefail function stop_after_update() { pid="$1" while ! grep -F 'Checking Dependencies' gmodserver.log; do sleep 1s done kill "$pid" while ps -p "$pid" -o pid= > /dev/null 2>&1; do sleep 1s done if [ -d "./functions/lgsm/" ]; then echo "Issue: found folder $(pwd)/functions/lgsm" else echo "Solved: no folder $(pwd)/functions/lgsm" fi } ( cd "$(dirname "$0")" if [ -d bugreport ]; then echo "please remove folder \"$(pwd)/bugreport\"" exit 1 fi mkdir bugreport ( cd bugreport wget -O linuxgsm.sh "https://raw.githubusercontent.com/GameServerManagers/LinuxGSM/v23.1.0/linuxgsm.sh" chmod +x linuxgsm.sh ( export LGSM_GITHUBUSER="GameServerManagers" export LGSM_GITHUBBRANCH="master" ./linuxgsm.sh gmodserver sed -i 's/"v23.1.0"/"v21.5.1"/' ./gmodserver ./gmodserver auto-install ) | tee /dev/tty > gmodserver.log 2>&1 & stop_after_update "$!" mv gmodserver.log gmodserver.before.log rm -rf ../bugreport/lgsm ( export LGSM_GITHUBUSER="jusito" export LGSM_GITHUBBRANCH="fix/update-lgsm" sed -i 's/"v23.1.0"/"v21.5.1"/' ./gmodserver ./gmodserver auto-install ) | tee /dev/tty > gmodserver.log 2>&1 & stop_after_update "$!" mv gmodserver.log gmodserver.after.log ) ) ``` ## Type of change - [x] Bug fix (a change which fixes an issue). - [ ] New feature (a change which adds functionality). - [ ] New Server (new server added). - [ ] Refactor (restructures existing code). - [ ] Comment update (typo, spelling, explanation, examples, etc). ## Checklist PR will not be merged until all steps are complete. - [x] This pull request links to an issue. - [x] This pull request uses the `develop` branch as its base. - [x] This pull request subject follows the Conventional Commits standard. - [x] This code follows the style guidelines of this project. - [x] I have performed a self-review of my code. - [x] I have checked that this code is commented where required. - [x] I have provided a detailed enough description of this PR. - [x] I have checked if documentation needs updating. ## Documentation If documentation does need updating either update it by creating a PR (preferred) or request a documentation update. - User docs: https://github.com/GameServerManagers/LinuxGSM-Docs - Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>