starred/LinuxGSM
1
0
Fork 0
mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-25 06:05:57 +03:00
Code Issues 409 Projects Releases 10 Packages Wiki Activity

[PR #3836] [CLOSED] fix(monitor): provide always valid exitcode #4137

New issue
Closed
opened 2026-02-27 04:54:00 +03:00 by kerem · 0 comments
kerem commented 2026-02-27 04:54:00 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/3836
Author: @jusito
Created: 4/3/2022
Status: ❌ Closed

Base: develop ← Head: feat/docker-integration

📝 Commits (9)

  • 05c1702 fix(gamedig): no querystatus after exit
  • 07e4824 fix: curl fails but linuxgsm not
  • a9bd66a refactor: simplified fix.sh
  • 242d0a4 feat(monitor): docker integration
  • ed4362c fix(details): port printing ws fails silently
  • de699d5 fix(query_gamedig): variable typo
  • 7fe3f5e log(monitor): more precise log message
  • 1e44535 clean(fix): shellcheck complain
  • aac290b clean(monitor): SAT output not relevant

📊 Changes

7 files changed (+254 additions, -252 deletions)

View changed files

📝 lgsm/functions/check_ip.sh (+18 -13)
📝 lgsm/functions/command_monitor.sh (+179 -147)
📝 lgsm/functions/core_dl.sh (+12 -8)
📝 lgsm/functions/fix.sh (+38 -81)
📝 lgsm/functions/info_messages.sh (+1 -1)
📝 lgsm/functions/install_server_files.sh (+4 -0)
📝 lgsm/functions/query_gamedig.sh (+2 -2)

📄 Description

Description

These changes are the core changes needed for my docker pull request. The changes are tested against every servercode.

  1. command monitor had multiple issues, mainly it doesn't exit with a usable exit code. I applied the style guide and documentation should be correct now.
  2. 127.0.0.1 should be part of fallback ips and maybe the others should even be removed. E.g. the port config inside a container can be 27015 but its mapped to host 27016, maybe because on 27015 is another server. Therefore if the host ip is taken to do a check, the wrong server is monitored.
  3. lgsm/functions/core_dl.sh:368 hides curl failing
  4. linuxgsm.sh changes are really useful to debug multiple invocations. As a result you can run a clean container and dump this file after the run to get a complete debug log.
  5. lgsm/functions/install_server_files.sh missed a check if branch is missing
  6. lgsm/functions/fix.sh refactoring to get rid of lots of branches which are error prone. Also added check to validate names added to arrays are valid.
  7. lgsm/functions/install_header.sh probably a typo?

Fixes #[issue]

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue draft pr which depends on this.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/3836 **Author:** [@jusito](https://github.com/jusito) **Created:** 4/3/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `feat/docker-integration` --- ### 📝 Commits (9) - [`05c1702`](https://github.com/GameServerManagers/LinuxGSM/commit/05c1702082a8de586592bf3c5a3c99d6831bd56c) fix(gamedig): no querystatus after exit - [`07e4824`](https://github.com/GameServerManagers/LinuxGSM/commit/07e4824df60af45b1a0a31c052b171beae524054) fix: curl fails but linuxgsm not - [`a9bd66a`](https://github.com/GameServerManagers/LinuxGSM/commit/a9bd66a16ac310fc6c2539b9ac8aab3680b61df5) refactor: simplified fix.sh - [`242d0a4`](https://github.com/GameServerManagers/LinuxGSM/commit/242d0a4072ea7cdff0e9701db9ec8ed9c1e8e996) feat(monitor): docker integration - [`ed4362c`](https://github.com/GameServerManagers/LinuxGSM/commit/ed4362cbf206f3b67370b364b1679c374d6db7d6) fix(details): port printing ws fails silently - [`de699d5`](https://github.com/GameServerManagers/LinuxGSM/commit/de699d54eda72d0f6acf060a99108bd636142d5e) fix(query_gamedig): variable typo - [`7fe3f5e`](https://github.com/GameServerManagers/LinuxGSM/commit/7fe3f5e196e85791d9488820e682f20183840201) log(monitor): more precise log message - [`1e44535`](https://github.com/GameServerManagers/LinuxGSM/commit/1e445357a0bf11d5b46ab041b081c5e5adad6ebf) clean(fix): shellcheck complain - [`aac290b`](https://github.com/GameServerManagers/LinuxGSM/commit/aac290b8e5e69ac818a2d112347adc0fee1ff629) clean(monitor): SAT output not relevant ### 📊 Changes **7 files changed** (+254 additions, -252 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/check_ip.sh` (+18 -13) 📝 `lgsm/functions/command_monitor.sh` (+179 -147) 📝 `lgsm/functions/core_dl.sh` (+12 -8) 📝 `lgsm/functions/fix.sh` (+38 -81) 📝 `lgsm/functions/info_messages.sh` (+1 -1) 📝 `lgsm/functions/install_server_files.sh` (+4 -0) 📝 `lgsm/functions/query_gamedig.sh` (+2 -2) </details> ### 📄 Description # Description [These changes are the core changes needed for my docker pull request.](https://github.com/GameServerManagers/LinuxGSM-Docker/pull/43) The changes are tested against every servercode. 1. command monitor had multiple issues, mainly it doesn't exit with a usable exit code. I applied the style guide and documentation should be correct now. 2. 127.0.0.1 should be part of fallback ips and maybe the others should even be removed. E.g. the port config inside a container can be 27015 but its mapped to host 27016, maybe because on 27015 is another server. Therefore if the host ip is taken to do a check, the wrong server is monitored. 3. `lgsm/functions/core_dl.sh:368` hides curl failing 4. `linuxgsm.sh` changes are really useful to debug multiple invocations. As a result you can run a clean container and dump this file after the run to get a complete debug log. 5. `lgsm/functions/install_server_files.sh` missed a check if branch is missing 6. `lgsm/functions/fix.sh` refactoring to get rid of lots of branches which are error prone. Also added check to validate names added to arrays are valid. 7. `lgsm/functions/install_header.sh` probably a typo? Fixes #[issue] ## Type of change * [x] Bug fix (a change which fixes an issue). * [ ] New feature (change which adds functionality). * [ ] New Server (new server added). * [x] Refactor (restructures existing code). * [ ] Comment update (typo, spelling, explanation, examples, etc). ## Checklist PR will not be merged until all steps are complete. * [x] This pull request links to an ~issue~ draft pr which depends on this. * [x] This pull request uses the `develop` branch as its base. * [ ] This pull request Subject follows the Conventional Commits standard. * [x] This code follows the style guidelines of this project. * [x] I have performed a self-review of my code. * [x] I have checked that this code is commented where required. * [x] I have provided a detailed with enough description of this PR. * [x] I have checked If documentation needs updating. ## Documentation If documentation does need updating either update it by creating a PR (preferred) or request a documentation update. * User docs: https://github.com/GameServerManagers/LinuxGSM-Docs * Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 04:54:00 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
develop
feature/mcv
feat/matrix-alerts
details-outputs
feature/4738-humanitz
feature/4426-tf-fixes
feature/dst-changes
feature/786-playersonline
feature/786-online-players-check
feature/4117-steamcmfauth
feature/git-branch-check
feature/sendgrid
feature/alerts-refactor
server-instances
gmod-content-mounting
v26.1.0
v25.2.0
v25.1.6
v25.1.5
v25.1.4
v25.1.3
v25.1.2
v25.1.1
v25.1.0
v24.3.4
v24.3.3
v24.3.2
v24.3.1
v24.3.0
v24.2.4
v24.2.3
v24.2.2
v24.2.1
v24.2.0
v24.1.5
v24.1.4
v24.1.3
v24.1.2
v24.1.1
v24.1.0
v23.7.1
v23.7.0
v23.6.2
v23.6.1
v23.6.0
v23.5.3
v23.5.2
v23.5.1
v23.5.0
v23.4.0
v23.3.6
v23.3.5
v23.3.4
v23.3.3
v23.3.2
v23.3.1
v23.3.0
v23.2.3
v23.2.2
v23.2.1
v23.2.0
v23.1.0
v22.2.1
v22.2.0
v22.1.0
v21.5.1
v21.5.0
v21.4.1
v21.4.0
v21.3.3
v21.3.2
v21.3.1
v21.3.0
v21.2.5
v21.2.4
v21.2.3
v21.2.2
v21.2.1
v21.2.0
v21.1.3
v21.1.2
v21.1.1
v21.1.0
v20.6.2
v20.6.1
v20.6.0
v20.5.1
v20.5.0
v20.4.1
v20.4.0
v20.3.3
v20.3.2
v20.3.1
v20.3.0
v20.2.1
v20.2.0
v20.1.5
v20.1.4
v20.1.3
v20.1.2
v20.1.1
v20.1.0
v19.12.5
v19.12.4
v19.12.3
v19.12.2
v19.12.1
v19.12.0
v19.11.0
v19.10.2
v19.10.1
v19.10.0
v19.9.0
v19.8.4
v19.8.3
v19.8.2
v19.8.1
v19.8.0
v19.7.0
v19.6.0
v19.5.3
190422
190401.2
190401.1
190401
190217.1
190202
190217
190106
181216.1
181216
181124
181027.1
181027
180908.3
180908.2
180908.1
180908
180718.2
180718.1
180718
180709.6
180409.5
180409.4
180409.3
180409.2
180409.1
180409
180318.3
180318.2
180318.1
180318
180313
171216.1
171216
171014
170926.1
170926
170803.2
170803.1
170803
170710.2
170710.1
170710
170619
170501
170430
170305.1
170305
170219.1
170219
170212
170128.1
170128
170110.2
170110.1
170110
161224
161221
161125
161118
161113.2
161113.1
161113
161030
Labels
Clear labels   
Atomic

   
Epic

   
cannot reproduce

   
command: backup

   
command: console

   
command: debug

   
command: details

   
command: fast-dl

   
command: install

   
command: mods

   
command: monitor

   
command: post-details

   
command: restart

   
command: send

   
command: start

   
command: stop

   
command: update

   
command: update-lgsm

   
command: validate

   
command: wipe

   
distro: AlmaLinux

   
distro: Arch Linux

   
distro: CentOS

   
distro: Debian

   
distro: Fedora

   
distro: RedHat

   
distro: Rocky Linux

   
distro: Ubuntu

   
distro: openSUSE

   
engine: goldsrc

   
engine: source

   
game: 7 Days to Die

   
game: ARMA 3

   
game: Ark: Survival Evolved

   
game: Assetto Corsa

   
game: Avorion

   
game: BATTALION: Legacy

   
game: Barotrauma

   
game: Battalion 1944

   
game: Battlefield 1942

   
game: Black Mesa: Deathmatch

   
game: Blade Symphony

   
game: Call of Duty 2

   
game: Call of Duty 4

   
game: Call of Duty: United Offensive

   
game: Counter-Strike 1.6

   
game: Counter-Strike 2

   
game: Counter-Strike: Global Offensive

   
game: Counter-Strike: Source

   
game: Day of Infamy

   
game: Dayz

   
game: Death Match Classic

   
game: Don't Starve Together

   
game: ET: Legacy

   
game: Eco

   
game: Factorio

   
game: Factorio

   
game: Garry's Mod

   
game: Half-Life

   
game: Hurtword

   
game: Insurgecy

   
game: Insurgecy

   
game: Insurgency: Sandstorm

   
game: Just Cause 3

   
game: Killing Floor

   
game: Killing Floor 2

   
game: Left 4 Dead 2

   
game: Minecraft

   
game: Minecraft Bedrock

   
game: Mordhau

   
game: Multi Theft Auto

   
game: Mumble

   
game: Natural Selection 2

   
game: No More Room in Hell

   
game: Pavlov VR

   
game: Post Scriptum

   
game: Project Zomboid

   
game: Quake 3

   
game: QuakeWorld

   
game: Red Orchestra: Ostfront 41-45

   
game: Return to Castle Wolfenstein

   
game: Rising World

   
game: Rust

   
game: San Andreas Multiplayer

   
game: Satisfactory

   
game: Soldat

   
game: Soldier of Fortune 2

   
game: Squad

   
game: Squad 44

   
game: Starbound

   
game: Stationeers

   
game: Sven Co-op

   
game: Team Fortress 2

   
game: Teamspeak 3

   
game: Teeworlds

   
game: Terraria

   
game: The Front

   
game: Unreal Tournament 2004

   
game: Unreal Tournament 3

   
game: Unreal Tournament 99

   
game: Unturned

   
game: Valheim

   
game: Wurm Unlimited

   
game: Zombie Master Reborn

   
game: label missing

   
good first issue

   
help wanted

   
info: alerts

   
info: dependency

   
info: docker

   
info: docs

   
info: email

   
info: query

   
info: steamcmd

   
info: systemd

   
info: tmux

   
info: website

   
info: website

   
needs more info

   
outcome: duplicate

   
outcome: issue resolved

   
outcome: issue resolved

   
outcome: issue unresolved

   
outcome: pr accepted

   
outcome: pr rejected

   
outcome: unconfirmed

   
outcome: wontfix

   
outcome: wrong forum

   
potential-duplicate

   
priority

   
pull-request

Mirrored from GitHub Pull Request

  
type: bug

   
type: feature

   
type: feature

   
type: feature request

   
type: game server request

   
type: refactor

   
waiting response
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#4137
No description provided.