[PR #3328] [MERGED] fix(backup): force $lastbackup to use latest backup. #3989

New issue

Closed

opened 2026-02-27 04:53:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 04:53:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/3328
Author: @Xalorous
Created: 3/3/2021
Status: ✅ Merged
Merged: 3/6/2021
Merged by: @dgibbs64

Base: develop ← Head: IssueNo3319

📝 Commits (2)

389964f Force $lastbackup to use latest date.
fbe5cef Merge branch 'develop' into IssueNo3319

📊 Changes

1 file changed (+14 additions, -10 deletions)

View changed files

📝 lgsm/functions/info_distro.sh (+14 -10)

📄 Description

Description

Find does not sort results, it displays them in the order they are found. In this case, this may usually be the order the backups are found, it is possible that it is not. Also, ls -1tr is lighter than find -print0 | sort -xargs 0, and we're not using any of the advanced features of find. So why not use a lighter command and force a sorted result where -head and -tail work well.

Use `ls -1tr` in place of `find`
    * produce a simple list,
    * one item per line,
    * sorted by date reverse. (this is the part find does not do easily)

Fixes #[3319]

Type of change

Bug fix (a change which fixes an issue).
New feature (change which adds functionality).
New Server (new server added).
Refactor (restructures existing code).
Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

This pull request links to an issue.
This pull request uses the develop branch as its base.
This pull request Subject follows the Conventional Commits standard.
This code follows the style guidelines of this project.
I have performed a self-review of my code.
I have checked that this code is commented where required.
I have provided a detailed with enough description of this PR.
I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

User docs: https://github.com/GameServerManagers/LinuxGSM-Docs
Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs

Thank you for your Pull Request!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/3328 **Author:** [@Xalorous](https://github.com/Xalorous) **Created:** 3/3/2021 **Status:** ✅ Merged **Merged:** 3/6/2021 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `develop` ← **Head:** `IssueNo3319` --- ### 📝 Commits (2) - [`389964f`](https://github.com/GameServerManagers/LinuxGSM/commit/389964f739d70504767fb81c0769a51a16362806) Force $lastbackup to use latest date. - [`fbe5cef`](https://github.com/GameServerManagers/LinuxGSM/commit/fbe5cef8545ceeb162f9440787603fca02008133) Merge branch 'develop' into IssueNo3319 ### 📊 Changes **1 file changed** (+14 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/info_distro.sh` (+14 -10) </details> ### 📄 Description # Description Find does not sort results, it displays them in the order they are found. In this case, this may usually be the order the backups are found, it is possible that it is not. Also, `ls -1tr` is lighter than `find -print0 | sort -xargs 0`, and we're not using any of the advanced features of find. So why not use a lighter command and force a sorted result where -head and -tail work well. Use `ls -1tr` in place of `find` * produce a simple list, * one item per line, * sorted by date reverse. (this is the part find does not do easily) Fixes #[3319] ## Type of change * [x] Bug fix (a change which fixes an issue). * [ ] New feature (change which adds functionality). * [ ] New Server (new server added). * [ ] Refactor (restructures existing code). * [ ] Comment update (typo, spelling, explanation, examples, etc). ## Checklist PR will not be merged until all steps are complete. * [x] This pull request links to an issue. * [x] This pull request uses the `develop` branch as its base. * [x] This pull request Subject follows the Conventional Commits standard. * [x] This code follows the style guidelines of this project. * [x] I have performed a self-review of my code. * [x] I have checked that this code is commented where required. * [x] I have provided a detailed with enough description of this PR. * [x] I have checked If documentation needs updating. ## Documentation If documentation does need updating either update it by creating a PR (preferred) or request a documentation update. * User docs: https://github.com/GameServerManagers/LinuxGSM-Docs * Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>