[PR #3135] [CLOSED] fix: Fix Stop Command when console has pending input #3929

New issue

Closed

opened 2026-02-27 03:56:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 03:56:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/3135
Author: @unknowntrojan
Created: 12/19/2020
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

fc0e3ec Fix Stop Command when console has pending input

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 lgsm/functions/command_stop.sh (+1 -1)

📄 Description

Description

When executing the stop command whilst something is still typed in the server session (enter was not pressed), the stop command will time out and fail, requiring manual intervention.

Type of change

This pull request simply "flushes" the command buffer by pressing enter. This may cause unintended behavior, such as a typed command getting implicitly executed, but the command will only have an impact on the game state if its persistent between restarts.

Properly execute quit when the session was improperly detached with something typed on the command line.
For example, someone types a command into the server console, then detaches. The stop command will wait, fail and need manual intervention.

Checklist

PR will not be merged until all steps are complete.

This pull request links to an issue.
This pull request uses the develop branch as its base.
This pull request Subject follows the Conventional Commits standard.
This code follows the style guidelines of this project.
I have performed a self-review of my code.
I have checked that this code is commented where required.
I have provided a detailed with enough description of this PR.
I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

User docs: https://github.com/GameServerManagers/LinuxGSM-Docs
Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs

Thank you for your Pull Request!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/3135 **Author:** [@unknowntrojan](https://github.com/unknowntrojan) **Created:** 12/19/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`fc0e3ec`](https://github.com/GameServerManagers/LinuxGSM/commit/fc0e3eca05cf28fd92e551631270a47f530421c4) Fix Stop Command when console has pending input ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/command_stop.sh` (+1 -1) </details> ### 📄 Description # Description When executing the stop command whilst something is still typed in the server session (enter was not pressed), the stop command will time out and fail, requiring manual intervention. ## Type of change This pull request simply "flushes" the command buffer by pressing enter. This may cause unintended behavior, such as a typed command getting implicitly executed, but the command will only have an impact on the game state if its persistent between restarts. Properly execute quit when the session was improperly detached with something typed on the command line. For example, someone types a command into the server console, then detaches. The stop command will wait, fail and need manual intervention. ## Checklist PR will not be merged until all steps are complete. * [ ] This pull request links to an issue. * [ ] This pull request uses the `develop` branch as its base. * [ ] This pull request Subject follows the Conventional Commits standard. * [ ] This code follows the style guidelines of this project. * [ ] I have performed a self-review of my code. * [ ] I have checked that this code is commented where required. * [ ] I have provided a detailed with enough description of this PR. * [ ] I have checked If documentation needs updating. ## Documentation If documentation does need updating either update it by creating a PR (preferred) or request a documentation update. * User docs: https://github.com/GameServerManagers/LinuxGSM-Docs * Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>