[PR #2831] [CLOSED] fix(command_backup.sh): Corrected directory path based on output of excludedir variable (fixes #1899) #3804

Closed
opened 2026-02-27 03:55:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/2831
Author: @codingWithJimmy
Created: 4/19/2020
Status: Closed

Base: developHead: develop


📝 Commits (9)

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 lgsm/functions/command_backup.sh (+1 -1)
📝 lgsm/functions/command_monitor.sh (+4 -4)

📄 Description

Description

Noticed my scripted backups were failing and the script log was saying the backup directory couldn't be properly identified when scheduling the backup via cronjob.

Apr 19 03:54:05.091 mcserver: Backup: FATAL: Problem identifying the previous backup directory for exclusion

After investigating, it looks like the "${excludedir}" variable was just outputting "lgsm/backup". This obviously works fine if you're running the backup manually from inside the root directory but it won't be enough context for running the backup via cronjob or script. My change to the code simply adds the "${rootdir}" variable on the front of the path to determine the existence of the "${excludedir}".

Fixes #1899

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/2831 **Author:** [@codingWithJimmy](https://github.com/codingWithJimmy) **Created:** 4/19/2020 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (9) - [`9e53770`](https://github.com/GameServerManagers/LinuxGSM/commit/9e5377086bbbb0bc065c5a8990b25c3d472c1d20) Merge branch 'hotfix/v20.1.5' - [`dc053ff`](https://github.com/GameServerManagers/LinuxGSM/commit/dc053ff9368fef3edc4fef8ed96bffc680f0d9b5) fix(bug): gamedig not using correct JSON object - [`4429f53`](https://github.com/GameServerManagers/LinuxGSM/commit/4429f532208efd9908c900f333f78a87171af084) Merge pull request #1 from jimmyatSplunk/fix/gamedig - [`4b16cb2`](https://github.com/GameServerManagers/LinuxGSM/commit/4b16cb26c58c676b519071fbae31fc765fe59f74) feat(monitor): Include bot count in monitor output - [`a2eb7f6`](https://github.com/GameServerManagers/LinuxGSM/commit/a2eb7f66e4a6149e85e95222771d9edf43570cb7) fix(messages): Fix to set proper component logging - [`a1d27d1`](https://github.com/GameServerManagers/LinuxGSM/commit/a1d27d1621678aadf73a4b8ceec9405c185828e0) Merge branch 'develop' into develop - [`b0f782a`](https://github.com/GameServerManagers/LinuxGSM/commit/b0f782a6532a10cdebecc23cc91f4cb19a3bb08e) Confirm commit for changes made - [`a6c2352`](https://github.com/GameServerManagers/LinuxGSM/commit/a6c2352ebc526d8a972b679d8c3996361e782ebf) fix(command_backup): Correct path for exludedir variable - [`b873335`](https://github.com/GameServerManagers/LinuxGSM/commit/b8733356d5336cd371026651cf31aaea250ba910) Merge branch 'develop' of https://github.com/jimmyatSplunk/LinuxGSM into develop ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/command_backup.sh` (+1 -1) 📝 `lgsm/functions/command_monitor.sh` (+4 -4) </details> ### 📄 Description # Description Noticed my scripted backups were failing and the script log was saying the backup directory couldn't be properly identified when scheduling the backup via cronjob. `Apr 19 03:54:05.091 mcserver: Backup: FATAL: Problem identifying the previous backup directory for exclusion` After investigating, it looks like the "${excludedir}" variable was just outputting "lgsm/backup". This obviously works fine if you're running the backup manually from inside the root directory but it won't be enough context for running the backup via cronjob or script. My change to the code simply adds the "${rootdir}" variable on the front of the path to determine the existence of the "${excludedir}". Fixes #1899 ## Type of change * [x] Bug fix (change which fixes an issue). * [ ] New feature (change which adds functionality). * [ ] New Server (new server added). * [ ] Refactor (restructures existing code). * [ ] Comment update (typo, spelling, explanation, examples, etc). ## Checklist PR will not be merged until all steps are complete. * [x] This pull request links to an issue. * [x] This pull request uses the `develop` branch as its base. * [x] This pull request Subject follows the Conventional Commits standard. * [x] This code follows the style guidelines of this project. * [x] I have performed a self-review of my own code. * [x] I have checked that this code is commented where required. * [x] I have provided a detailed enough description of this PR. * [x] I have checked If documentation needs updating. ## Documentation If documentation does need updating either update it by creating a PR (preferred) or request a documentation update. * User docs: https://github.com/GameServerManagers/LinuxGSM-Docs * Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 03:55:52 +03:00
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#3804
No description provided.