[PR #2802] [MERGED] fix(validate): resolve validate not functioning for non branch #3789

Closed
opened 2026-02-27 03:55:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/2802
Author: @dgibbs64
Created: 4/3/2020
Status: Merged
Merged: 4/4/2020
Merged by: @dgibbs64

Base: developHead: feature/2780-validate


📝 Commits (6)

📊 Changes

4 files changed (+64 additions, -17 deletions)

View changed files

📝 lgsm/functions/command_validate.sh (+13 -3)
📝 lgsm/functions/info_messages.sh (+1 -1)
📝 lgsm/functions/install_server_files.sh (+36 -11)
📝 lgsm/functions/update_steamcmd.sh (+14 -2)

📄 Description

Description

validate was not working correctly for all servers not using a branch. New if statement added to remove the -branch if there is not branch specified.

Fixes #2780

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/2802 **Author:** [@dgibbs64](https://github.com/dgibbs64) **Created:** 4/3/2020 **Status:** ✅ Merged **Merged:** 4/4/2020 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `develop` ← **Head:** `feature/2780-validate` --- ### 📝 Commits (6) - [`b19ae68`](https://github.com/GameServerManagers/LinuxGSM/commit/b19ae68a42dd2cb0623cd0c07ab33fb3500acc02) fix(validate): resolve validate not functioning for non branch - [`ca7ad80`](https://github.com/GameServerManagers/LinuxGSM/commit/ca7ad806dd9e1f02e577e044fc6a540734392492) comments - [`0faf365`](https://github.com/GameServerManagers/LinuxGSM/commit/0faf365f66deff871d57f558e8fb641c37141856) comments - [`e3fe9bf`](https://github.com/GameServerManagers/LinuxGSM/commit/e3fe9bfbc49d4892cd829aa7f95a3cf7c080d260) changed to appid 90 - [`c6b0069`](https://github.com/GameServerManagers/LinuxGSM/commit/c6b00699dbd16d7c2489c4ea3bca8bb47381b3ea) comments - [`958c3d5`](https://github.com/GameServerManagers/LinuxGSM/commit/958c3d5a16cde1f43cad4654cfdfa37975456cac) Merge branch 'develop' into feature/2780-validate ### 📊 Changes **4 files changed** (+64 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/command_validate.sh` (+13 -3) 📝 `lgsm/functions/info_messages.sh` (+1 -1) 📝 `lgsm/functions/install_server_files.sh` (+36 -11) 📝 `lgsm/functions/update_steamcmd.sh` (+14 -2) </details> ### 📄 Description # Description validate was not working correctly for all servers not using a branch. New if statement added to remove the `-branch` if there is not branch specified. Fixes #2780 ## Type of change * [x] Bug fix (change which fixes an issue). * [ ] New feature (change which adds functionality). * [ ] New Server (new server added). * [ ] Refactor (restructures existing code). * [ ] Comment update (typo, spelling, explanation, examples, etc). ## Checklist PR will not be merged until all steps are complete. * [x] This pull request links to an issue. * [x] This pull request uses the `develop` branch as its base. * [x] This pull request Subject follows the Conventional Commits standard. * [x] This code follows the style guidelines of this project. * [x] I have performed a self-review of my own code. * [x] I have checked that this code is commented where required. * [x] I have provided a detailed enough description of this PR. * [x] I have checked If documentation needs updating. ## Documentation If documentation does need updating either update it by creating a PR (preferred) or request a documentation update. * User docs: https://github.com/GameServerManagers/LinuxGSM-Docs * Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 03:55:49 +03:00
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#3789
No description provided.