[PR #2616] [MERGED] feat(core): convert ${curlpath} to using curl and improve code standards #3726

Closed
opened 2026-02-27 03:55:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/2616
Author: @dgibbs64
Created: 11/25/2019
Status: Merged
Merged: 11/25/2019
Merged by: @dgibbs64

Base: developHead: feature/curl


📝 Commits (10+)

📊 Changes

100 files changed (+382 additions, -402 deletions)

View changed files

📝 lgsm/functions/alert_discord.sh (+3 -3)
📝 lgsm/functions/alert_email.sh (+1 -1)
📝 lgsm/functions/alert_ifttt.sh (+2 -2)
📝 lgsm/functions/alert_mailgun.sh (+2 -2)
📝 lgsm/functions/alert_pushbullet.sh (+2 -2)
📝 lgsm/functions/alert_pushover.sh (+2 -2)
📝 lgsm/functions/alert_slack.sh (+1 -1)
📝 lgsm/functions/alert_telegram.sh (+2 -2)
📝 lgsm/functions/check_config.sh (+1 -1)
📝 lgsm/functions/check_deps.sh (+4 -4)
📝 lgsm/functions/check_executable.sh (+1 -1)
📝 lgsm/functions/check_logs.sh (+1 -1)
📝 lgsm/functions/check_permissions.sh (+5 -6)
📝 lgsm/functions/check_root.sh (+1 -1)
📝 lgsm/functions/check_status.sh (+1 -1)
📝 lgsm/functions/check_system_dir.sh (+1 -1)
📝 lgsm/functions/check_system_requirements.sh (+1 -1)
📝 lgsm/functions/command_backup.sh (+1 -1)
📝 lgsm/functions/command_console.sh (+1 -1)
📝 lgsm/functions/command_debug.sh (+1 -1)

...and 80 more files

📄 Description

Description

Converted form using ${curlpath} to curl as I don't believe there is a ready to continue using curlpath

Fixes #2579

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/2616 **Author:** [@dgibbs64](https://github.com/dgibbs64) **Created:** 11/25/2019 **Status:** ✅ Merged **Merged:** 11/25/2019 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `develop` ← **Head:** `feature/curl` --- ### 📝 Commits (10+) - [`c1b3ac9`](https://github.com/GameServerManagers/LinuxGSM/commit/c1b3ac9235135fab1fd10c36442651ec369868c2) Update core_dl.sh - [`e0c1dd6`](https://github.com/GameServerManagers/LinuxGSM/commit/e0c1dd6beb93ae20721a06670e684f6fc281e247) Update linuxgsm.sh - [`bf543a1`](https://github.com/GameServerManagers/LinuxGSM/commit/bf543a1d18c0f057e40e442fcd6d9268a1df7e47) Update core_dl.sh - [`e774ef9`](https://github.com/GameServerManagers/LinuxGSM/commit/e774ef936b9b7c265f40cab7a53fdeb827161161) Update tests_fctrserver.sh - [`f845290`](https://github.com/GameServerManagers/LinuxGSM/commit/f845290c54eb9878531caf4dca97459cc8623437) Update tests_jc2server.sh - [`06a8761`](https://github.com/GameServerManagers/LinuxGSM/commit/06a87616ded8f0228cf551310ed90a004deb6310) Update tests_mcserver.sh - [`b60713b`](https://github.com/GameServerManagers/LinuxGSM/commit/b60713b98608751149c2f69f1bfa621e58afdaa4) Update tests_ts3server.sh - [`5fa657d`](https://github.com/GameServerManagers/LinuxGSM/commit/5fa657df276d180d1d419672c4e891ecc57f5683) Update info_stats.sh - [`a898f55`](https://github.com/GameServerManagers/LinuxGSM/commit/a898f555bc36e7599cf4aae950c5aaf5bce1eb97) Update info_distro.sh - [`ecbd09e`](https://github.com/GameServerManagers/LinuxGSM/commit/ecbd09e0894dcbcb763a39b79fb92d9b9198cc26) shellcheck fn_print_horizontal ### 📊 Changes **100 files changed** (+382 additions, -402 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/alert_discord.sh` (+3 -3) 📝 `lgsm/functions/alert_email.sh` (+1 -1) 📝 `lgsm/functions/alert_ifttt.sh` (+2 -2) 📝 `lgsm/functions/alert_mailgun.sh` (+2 -2) 📝 `lgsm/functions/alert_pushbullet.sh` (+2 -2) 📝 `lgsm/functions/alert_pushover.sh` (+2 -2) 📝 `lgsm/functions/alert_slack.sh` (+1 -1) 📝 `lgsm/functions/alert_telegram.sh` (+2 -2) 📝 `lgsm/functions/check_config.sh` (+1 -1) 📝 `lgsm/functions/check_deps.sh` (+4 -4) 📝 `lgsm/functions/check_executable.sh` (+1 -1) 📝 `lgsm/functions/check_logs.sh` (+1 -1) 📝 `lgsm/functions/check_permissions.sh` (+5 -6) 📝 `lgsm/functions/check_root.sh` (+1 -1) 📝 `lgsm/functions/check_status.sh` (+1 -1) 📝 `lgsm/functions/check_system_dir.sh` (+1 -1) 📝 `lgsm/functions/check_system_requirements.sh` (+1 -1) 📝 `lgsm/functions/command_backup.sh` (+1 -1) 📝 `lgsm/functions/command_console.sh` (+1 -1) 📝 `lgsm/functions/command_debug.sh` (+1 -1) _...and 80 more files_ </details> ### 📄 Description # Description Converted form using ${curlpath} to curl as I don't believe there is a ready to continue using curlpath Fixes #2579 ## Type of change * [ ] Bug fix (change which fixes an issue). * [ ] New feature (change which adds functionality). * [ ] New Server (new server added). * [X] Refactor (restructures existing code). * [ ] Comment update (typo, spelling, explanation, examples, etc). ## Checklist PR will not be merged until all steps are complete. * [x] This pull request links to an issue. * [x] This pull request uses the `develop` branch as its base. * [x] This code follows the style guidelines of this project. * [x] I have performed a self-review of my own code. * [x] I have checked that this code is commented where required. * [x] I have provided a detailed enough description of this PR. * [x] I have checked If documentation needs updating. ## Documentation If documentation does need updating either update it by creating a PR (preferred) or request a documentation update. * User docs: https://github.com/GameServerManagers/LinuxGSM-Docs * Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs **Thank you for your Pull Request!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 03:55:35 +03:00
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#3726
No description provided.