[PR #2101] [MERGED] POC changes for docker #3492

New issue

Closed

opened 2026-02-27 03:54:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 03:54:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/2101
Author: @joshhsoj1902
Created: 12/8/2018
Status: ✅ Merged
Merged: 8/26/2020
Merged by: @dgibbs64

Base: feature/docker ← Head: joshhsoj1902-changes-4-docker

📝 Commits (10+)

4b460b1 Add gomplate support for templating configs
a70f149 Always return ip 0.0.0.0
8bdeda9 Always test against an actual IP
332284d Add checks for if we're running inside docker
48a803e lookup hostname when in docker
e1f86f3 Merge remote-tracking branch 'origin/master' into joshhsoj1902-changes-4-docker
9fed486 Merge remote-tracking branch 'origin/master' into joshhsoj1902-changes-4-docker
44f5b32 fix tabbing
802f161 fix paths
72a4385 fix 0.0.0.0 return

📊 Changes

3 files changed (+45 additions, -19 deletions)

View changed files

📝 lgsm/functions/check_ip.sh (+4 -0)
📝 lgsm/functions/command_monitor.sh (+34 -14)
📝 lgsm/functions/install_config.sh (+7 -5)

📄 Description

As part of trying to make a dockerized version of LGSM there were a few src changes that I needed to make for it to work.

I always intended to polish them and try to contribute them back. Since @dgibbs64 is showing some interest in the project I wanted to expose the changes that I did make.

These changes in their current form are pretty small, but cannot be merged as is. They were done knowing that they would only need to work inside docker. I'm hoping through this PR we could potentially figure out the better ways to work around the issues I was encountering or potentially incorporate some changes into the main code base!

Edit (some additional details)

For me to actually get LinuxGSM running in docker I did need to make a few src changes though (fairly small ones). https://github.com/GameServerManagers/LinuxGSM/pull/2101

There were 2 things that I needed to be able to do.

I needed a way to inject config values into LinuxGSM. For this, I decided to use gomplate (a templating tool) to basically inject env vars into the common.cfg
When inside Docker it's easiest bind to all interfaces (when running in kubernetes or docker swarm you'll often have multiple network interfaces)
- This didn't work so well out of the box because LinuxGSM does some health checking every 60 seconds. But it uses the same IP and 0.0.0.0 doesn't work for that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/2101 **Author:** [@joshhsoj1902](https://github.com/joshhsoj1902) **Created:** 12/8/2018 **Status:** ✅ Merged **Merged:** 8/26/2020 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `feature/docker` ← **Head:** `joshhsoj1902-changes-4-docker` --- ### 📝 Commits (10+) - [`4b460b1`](https://github.com/GameServerManagers/LinuxGSM/commit/4b460b1823a288e19d6765a03ca20ed569c55953) Add gomplate support for templating configs - [`a70f149`](https://github.com/GameServerManagers/LinuxGSM/commit/a70f1497aee6752396acaa88e779e03ea1ae4aa9) Always return ip 0.0.0.0 - [`8bdeda9`](https://github.com/GameServerManagers/LinuxGSM/commit/8bdeda9dc31d27910399137b9d4478e909035173) Always test against an actual IP - [`332284d`](https://github.com/GameServerManagers/LinuxGSM/commit/332284debd91b9cc3b1917a64e7af13a288e8494) Add checks for if we're running inside docker - [`48a803e`](https://github.com/GameServerManagers/LinuxGSM/commit/48a803e4393c4903333d53b685c1518092803a9c) lookup hostname when in docker - [`e1f86f3`](https://github.com/GameServerManagers/LinuxGSM/commit/e1f86f3c243d4d62c83e2d3338045811df29ff0a) Merge remote-tracking branch 'origin/master' into joshhsoj1902-changes-4-docker - [`9fed486`](https://github.com/GameServerManagers/LinuxGSM/commit/9fed48696535ff7a437c4724675d24d084ee9014) Merge remote-tracking branch 'origin/master' into joshhsoj1902-changes-4-docker - [`44f5b32`](https://github.com/GameServerManagers/LinuxGSM/commit/44f5b32b692602bb361923c2562d9813ad582e34) fix tabbing - [`802f161`](https://github.com/GameServerManagers/LinuxGSM/commit/802f161e8b3ac8af2ec6c6798adc47d4d81783f8) fix paths - [`72a4385`](https://github.com/GameServerManagers/LinuxGSM/commit/72a4385619e1c2bafc1b30001c5af166a79d8ddc) fix 0.0.0.0 return ### 📊 Changes **3 files changed** (+45 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/check_ip.sh` (+4 -0) 📝 `lgsm/functions/command_monitor.sh` (+34 -14) 📝 `lgsm/functions/install_config.sh` (+7 -5) </details> ### 📄 Description As part of trying to make a [dockerized version of LGSM](https://github.com/joshhsoj1902/linuxgsm-docker) there were a few src changes that I needed to make for it to work. I always intended to polish them and try to contribute them back. Since @dgibbs64 is showing some interest in the project I wanted to expose the changes that I did make. These changes in their current form are pretty small, but cannot be merged as is. They were done knowing that they would only need to work inside docker. I'm hoping through this PR we could potentially figure out the better ways to work around the issues I was encountering or potentially incorporate some changes into the main code base! **Edit (some additional details)** For me to actually get LinuxGSM running in docker I did need to make a few src changes though (fairly small ones). https://github.com/GameServerManagers/LinuxGSM/pull/2101 There were 2 things that I needed to be able to do. - I needed a way to inject config values into LinuxGSM. For this, I decided to use gomplate (a templating tool) to basically inject env vars into the `common.cfg` - When inside Docker it's easiest bind to all interfaces (when running in kubernetes or docker swarm you'll often have multiple network interfaces) - This didn't work so well out of the box because LinuxGSM does some health checking every 60 seconds. But it uses the same IP and 0.0.0.0 doesn't work for that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>