[PR #1882] [MERGED] Fixes tmux handling of similar session names #3423

New issue

Closed

opened 2026-02-27 03:54:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 03:54:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/1882
Author: @UltimateByte
Created: 4/16/2018
Status: ✅ Merged
Merged: 4/16/2018
Merged by: @dgibbs64

Base: develop ← Head: feature/tmux-180416

📝 Commits (7)

01919f2 Major cleaning of tmux handling
4763200 Remaining -t= to clean
97c87a9 Fixed tmux sessions killed when they should not
aed05e2 You can remain quiet now tmux, we know you're here
aa31cdb Better place to remove the lockfile
0a575f6 Fixed & simplified log rotation changes from my previous commit
0fe368f space

📊 Changes

3 files changed (+40 additions, -59 deletions)

View changed files

📝 lgsm/functions/check_status.sh (+1 -1)
📝 lgsm/functions/command_start.sh (+21 -34)
📝 lgsm/functions/command_stop.sh (+18 -24)

📄 Description

This is probably my (not to say "THE") best PR in a while! It resolves an old issue (since LinuxGSM uses TMUX I think) where the wrong tmux session gets killed when they got similar names.

Example:

./csgoserver start
[  OK  ] Starting csgoserver: LinuxGSM
./csgoserver-2 start
[  OK  ] Starting csgoserver-2: LinuxGSM
./csgoserver stop
[  OK  ] Stopping csgoserver: Graceful: sending "quit": 2: OK
./csgoserver-2 stop
[ INFO ] Stopping csgoserver-2: LinuxGSM is already stopped

The reason is:
When graceful shutdown works, probably because of pipe-pane or for whatever reason, the tmux session dies. But fn_stop_tmux was ran anyways because it made sense in termes of code. That caused a command like tmux kill-session -t csgoserver to be run after the session died, so the command affected the closest matching alternate, like csgoserver-2 tmux session. Because yes... tmux aproximates session names, which is cool for lazy people, but not cool when you seek precision.

Anyway, it forced a little more cautiousness, which lead me to finding this, as well as some minor issues with the code.

The main change in this PR is that we make sure to run the session kill only when required. But some duplicate tests were removed as well, and some tests reorganized, which leads to a more simple and more comprehensible code.

It seems pretty right to me now, tested with csgo, and resolved the few issues pointed by our dear Travis.

Let's merge this to develop first for further testing until you think it is ready for master!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/1882 **Author:** [@UltimateByte](https://github.com/UltimateByte) **Created:** 4/16/2018 **Status:** ✅ Merged **Merged:** 4/16/2018 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `develop` ← **Head:** `feature/tmux-180416` --- ### 📝 Commits (7) - [`01919f2`](https://github.com/GameServerManagers/LinuxGSM/commit/01919f28308ef8a9f1c6d3ae4ef3c8e9d32e492b) Major cleaning of tmux handling - [`4763200`](https://github.com/GameServerManagers/LinuxGSM/commit/476320095ece85b12bb2db5e1cf48ec386374e77) Remaining -t= to clean - [`97c87a9`](https://github.com/GameServerManagers/LinuxGSM/commit/97c87a9d56fbe6919c6c77c3ac328d630d1f947f) Fixed tmux sessions killed when they should not - [`aed05e2`](https://github.com/GameServerManagers/LinuxGSM/commit/aed05e2dc1c0b8e66bdbfcb29d2def44ef6312ae) You can remain quiet now tmux, we know you're here - [`aa31cdb`](https://github.com/GameServerManagers/LinuxGSM/commit/aa31cdb74b69c8e8c1fbcca3331aa5b4fba2c432) Better place to remove the lockfile - [`0a575f6`](https://github.com/GameServerManagers/LinuxGSM/commit/0a575f666db459ab559fdf25b7a6979ec871a35c) Fixed & simplified log rotation changes from my previous commit - [`0fe368f`](https://github.com/GameServerManagers/LinuxGSM/commit/0fe368fb937a26e98fc422618ecb616e67ee77fd) space ### 📊 Changes **3 files changed** (+40 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `lgsm/functions/check_status.sh` (+1 -1) 📝 `lgsm/functions/command_start.sh` (+21 -34) 📝 `lgsm/functions/command_stop.sh` (+18 -24) </details> ### 📄 Description This is probably my (not to say "THE") best PR in a while! It resolves an old issue (since LinuxGSM uses TMUX I think) where the wrong tmux session gets killed when they got similar names. Example: ``` ./csgoserver start [ OK ] Starting csgoserver: LinuxGSM ./csgoserver-2 start [ OK ] Starting csgoserver-2: LinuxGSM ./csgoserver stop [ OK ] Stopping csgoserver: Graceful: sending "quit": 2: OK ./csgoserver-2 stop [ INFO ] Stopping csgoserver-2: LinuxGSM is already stopped ``` The reason is: When graceful shutdown works, probably because of pipe-pane or for whatever reason, the tmux session dies. But `fn_stop_tmux` was ran anyways because it made sense in termes of code. That caused a command like `tmux kill-session -t csgoserver ` to be run after the session died, so the command affected the closest matching alternate, like `csgoserver-2` tmux session. Because yes... tmux aproximates session names, which is cool for lazy people, but not cool when you seek precision. Anyway, it forced a little more cautiousness, which lead me to finding this, as well as some minor issues with the code. The main change in this PR is that we make sure to run the session kill only when required. But some duplicate tests were removed as well, and some tests reorganized, which leads to a more simple and more comprehensible code. It seems pretty right to me now, tested with csgo, and resolved the few issues pointed by our dear Travis. Let's merge this to develop first for further testing until you think it is ready for master! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>