[PR #1554] [CLOSED] Added pre-install config creation #3360

New issue

Closed

opened 2026-02-27 03:54:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 03:54:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/1554
Author: @marvinlehmann
Created: 7/29/2017
Status: ❌ Closed

Base: develop ← Head: feature/config-dl

📝 Commits (6)

54cb7cf Removed customized servicename
7eea40c Added pre-install config creation
7ade67f Merge develop into config-dl
1e69ece Added pre-install config creation to fctrserver test
a99d146 Merge remote-tracking branch 'origin/develop' into feature/config-dl
2deb20a Fixed config url

📊 Changes

5 files changed (+360 additions, -287 deletions)

View changed files

📝 linuxgsm.sh (+74 -61)
📝 tests/tests_fctrserver.sh (+71 -56)
📝 tests/tests_jc2server.sh (+72 -57)
📝 tests/tests_mcserver.sh (+72 -57)
📝 tests/tests_ts3server.sh (+71 -56)

📄 Description

Partly adressing the feedback by @Khelgar1:

The instructions for installing a 7dtd server at https://gameservermanagers.com/lgsm/sdtdserver/ are incorrect. You cannot edit the common.cfg file because the lgsm directory structure isn't created until after you run ./sdtdserver install command once... Am I missing something in how this should be done because it's not at all obvious.
IMO what should happen when you run ./linuxgsm install is that is should create the proper directory structure and then then download the sdtdserver script. Downloading it before the folders are created is just confusing.
Finally the message Installed 7 Days to Die server as sdtdserver is very misleading it would be clearer if it said Downloaded sdtdserver script then give the message To install server run ./sdtdserver install or something along those lines
Finally Finally it might be useful to add an instruction in how to create an entire common.cfg file for the first time cat _default.cfg >> common.cfg works a treat for me. Then it's easy to edit common.cfg to suit. I've not even looked through common.cfg apart from entering the steam details though so maybe you have reasons for not doing this, apart from overwriting existing cfg files

Furthermore it'll fix and break the current already broken DST sharding stuff (#1538).

This is NOT completely tested yet and I'd like to get some feedback if it's OK.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/1554 **Author:** [@marvinlehmann](https://github.com/marvinlehmann) **Created:** 7/29/2017 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `feature/config-dl` --- ### 📝 Commits (6) - [`54cb7cf`](https://github.com/GameServerManagers/LinuxGSM/commit/54cb7cfe79d84abcdb791db83899186733e3289e) Removed customized servicename - [`7eea40c`](https://github.com/GameServerManagers/LinuxGSM/commit/7eea40c8d2a58dd3423fb20918252e8e19664af3) Added pre-install config creation - [`7ade67f`](https://github.com/GameServerManagers/LinuxGSM/commit/7ade67f4e523e1693912c0e5cf639e74eacd84b0) Merge develop into config-dl - [`1e69ece`](https://github.com/GameServerManagers/LinuxGSM/commit/1e69ece8a2469c002c1a998650c2a064b5b83f13) Added pre-install config creation to fctrserver test - [`a99d146`](https://github.com/GameServerManagers/LinuxGSM/commit/a99d146d11111003c105d796575ede1130793679) Merge remote-tracking branch 'origin/develop' into feature/config-dl - [`2deb20a`](https://github.com/GameServerManagers/LinuxGSM/commit/2deb20a36a178ef02e71781287bf8cdb9ed0a0b5) Fixed config url ### 📊 Changes **5 files changed** (+360 additions, -287 deletions) <details> <summary>View changed files</summary> 📝 `linuxgsm.sh` (+74 -61) 📝 `tests/tests_fctrserver.sh` (+71 -56) 📝 `tests/tests_jc2server.sh` (+72 -57) 📝 `tests/tests_mcserver.sh` (+72 -57) 📝 `tests/tests_ts3server.sh` (+71 -56) </details> ### 📄 Description Partly adressing the feedback by @Khelgar1: > The instructions for installing a 7dtd server at https://gameservermanagers.com/lgsm/sdtdserver/ are incorrect. You cannot edit the common.cfg file because the lgsm directory structure isn't created until after you run ./sdtdserver install command once... Am I missing something in how this should be done because it's not at all obvious. > IMO what should happen when you run ./linuxgsm install is that is should create the proper directory structure and then then download the sdtdserver script. Downloading it before the folders are created is just confusing. > Finally the message Installed 7 Days to Die server as sdtdserver is very misleading it would be clearer if it said Downloaded sdtdserver script then give the message To install server run ./sdtdserver install or something along those lines > _Finally Finally it might be useful to add an instruction in how to create an entire common.cfg file for the first time cat \_default.cfg >> common.cfg works a treat for me. Then it's easy to edit common.cfg to suit. I've not even looked through common.cfg apart from entering the steam details though so maybe you have reasons for not doing this, apart from overwriting existing cfg files_ Furthermore it'll fix and break the current already broken DST sharding stuff (#1538). This is **NOT** completely tested yet and I'd like to get some feedback if it's OK. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

Rows
Columns