[PR #1323] [MERGED] Loads of minor fixes #3317

Closed
opened 2026-02-27 03:54:04 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/GameServerManagers/LinuxGSM/pull/1323
Author: @UltimateByte
Created: 2/19/2017
Status: Merged
Merged: 2/19/2017
Merged by: @dgibbs64

Base: developHead: feature/ultimatebyte-0219


📝 Commits (10+)

  • 92f748c Rust now supports custom log dir
  • 9d603d1 only rotate logs if server is off
  • 7a4438e sys permission fix only upon server start
  • 2b4262e Allow to run details with non-installed server
  • 15f80f1 Run log manager upon update
  • 14141d4 Case where there is no console log
  • fadc79e Full path showed to the user
  • ab8ad90 Only create dirs if they don't already exist
  • 6c6fd3a Create gamelogdir if variable exists & dir doesn't
  • 8401655 double quote missing

📊 Changes

8 files changed (+29 additions, -17 deletions)

View changed files

📝 Rust/rustserver (+2 -3)
📝 lgsm/functions/check.sh (+2 -2)
📝 lgsm/functions/check_executable.sh (+3 -2)
📝 lgsm/functions/check_logs.sh (+11 -2)
📝 lgsm/functions/check_permissions.sh (+3 -1)
📝 lgsm/functions/command_update.sh (+1 -1)
📝 lgsm/functions/logs.sh (+2 -5)
📝 lgsm/functions/update_steamcmd.sh (+5 -1)

📄 Description

  • Rust now allows for custom log locations: log/gamelog
  • details and postdetails commands can now be run even if server is not installed yet #1302
  • If executable is not found, the full path will be displayed instead of just the executable name #1288
  • Log rotation will now occur upon updates #1075
  • Rust will not move gamelog if server is already started #1318
  • Checks on /sys will now only occur upon server start #1303
  • Fixed a possible error when ${consolelog} doesn't exist

Note: Log rotation already worked with monitor #1075

Also:

  • Log directories will now only be created if they don't already exist.
  • gamelog dir will be created if variable is set but dir doesn't exist
  • Legacy server logs (log/server) won't be removed anymore if dir is empty

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/GameServerManagers/LinuxGSM/pull/1323 **Author:** [@UltimateByte](https://github.com/UltimateByte) **Created:** 2/19/2017 **Status:** ✅ Merged **Merged:** 2/19/2017 **Merged by:** [@dgibbs64](https://github.com/dgibbs64) **Base:** `develop` ← **Head:** `feature/ultimatebyte-0219` --- ### 📝 Commits (10+) - [`92f748c`](https://github.com/GameServerManagers/LinuxGSM/commit/92f748c1ca47cad2b120572c5d44402bc0c02af5) Rust now supports custom log dir - [`9d603d1`](https://github.com/GameServerManagers/LinuxGSM/commit/9d603d10ceb6a264826dd2359aa0152e8c33ee44) only rotate logs if server is off - [`7a4438e`](https://github.com/GameServerManagers/LinuxGSM/commit/7a4438e8d0cc56cea90f7c0cccb3cf1a6b6dd6fa) sys permission fix only upon server start - [`2b4262e`](https://github.com/GameServerManagers/LinuxGSM/commit/2b4262e1d5e83f71f64f20a4caf0414b175b4b5d) Allow to run details with non-installed server - [`15f80f1`](https://github.com/GameServerManagers/LinuxGSM/commit/15f80f1151699c38f884f9335acb7139b4e8af52) Run log manager upon update - [`14141d4`](https://github.com/GameServerManagers/LinuxGSM/commit/14141d4c8a2421b13207abda74f8c44e701d192c) Case where there is no console log - [`fadc79e`](https://github.com/GameServerManagers/LinuxGSM/commit/fadc79e84c1af3f0fec33a7a4b146c02cf5e3a71) Full path showed to the user - [`ab8ad90`](https://github.com/GameServerManagers/LinuxGSM/commit/ab8ad9084c89c5871646b022d5fcf00a71aa8e7c) Only create dirs if they don't already exist - [`6c6fd3a`](https://github.com/GameServerManagers/LinuxGSM/commit/6c6fd3a33c041fb35d24ae7f98f1feeeadf523b1) Create gamelogdir if variable exists & dir doesn't - [`8401655`](https://github.com/GameServerManagers/LinuxGSM/commit/84016558b8df2f5225c7bd4292a78c0a6b4f2e54) double quote missing ### 📊 Changes **8 files changed** (+29 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `Rust/rustserver` (+2 -3) 📝 `lgsm/functions/check.sh` (+2 -2) 📝 `lgsm/functions/check_executable.sh` (+3 -2) 📝 `lgsm/functions/check_logs.sh` (+11 -2) 📝 `lgsm/functions/check_permissions.sh` (+3 -1) 📝 `lgsm/functions/command_update.sh` (+1 -1) 📝 `lgsm/functions/logs.sh` (+2 -5) 📝 `lgsm/functions/update_steamcmd.sh` (+5 -1) </details> ### 📄 Description - Rust now allows for custom log locations: log/gamelog - `details `and `postdetails `commands can now be run even if server is not installed yet #1302 - If executable is not found, the full path will be displayed instead of just the executable name #1288 - Log rotation will now occur upon updates #1075 - Rust will not move gamelog if server is already started #1318 - Checks on /sys will now only occur upon server start #1303 - Fixed a possible error when ${consolelog} doesn't exist Note: Log rotation already worked with monitor #1075 Also: - Log directories will now only be created if they don't already exist. - `gamelog` dir will be created if variable is set but dir doesn't exist - Legacy server logs (log/server) won't be removed anymore if dir is empty --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 03:54:04 +03:00
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#3317
No description provided.