[GH-ISSUE #4279] [Adjustment?]: maybe adjust permissions checks to be more lenient? #2691

Closed
opened 2026-02-27 03:04:45 +03:00 by kerem · 4 comments
Owner

Originally created by @ddan39 on GitHub (Jul 28, 2023).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/4279

Originally assigned to: @dgibbs64 on GitHub.

User story

a new unused file in lgsm/modules/ could cause lgsm to fail. i think it would be good to some how limit that check,

Game

Project Zomboid

Linux distro

Debian 12

Command

command: start, command: stop, command: restart

Further information

Permissions checks run on every file in lgsm/modules/ folder, in check_permissions.sh for example it runs find "${modulesdir}" -type f -not -executable | wc -l. Maybe that should be adjust to something like find "${modulesdir}" -type f -name '*.sh' -not -executable | wc -l, or another option is to store a list of all lgsm sh files and check those specific files instead of all files in the modulesdir? I don't know, just spitballing here.

Originally created by @ddan39 on GitHub (Jul 28, 2023). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/4279 Originally assigned to: @dgibbs64 on GitHub. ### User story a new unused file in lgsm/modules/ could cause lgsm to fail. i think it would be good to some how limit that check, ### Game Project Zomboid ### Linux distro Debian 12 ### Command command: start, command: stop, command: restart ### Further information Permissions checks run on every file in lgsm/modules/ folder, in check_permissions.sh for example it runs `find "${modulesdir}" -type f -not -executable | wc -l`. Maybe that should be adjust to something like `find "${modulesdir}" -type f -name '*.sh' -not -executable | wc -l`, or another option is to store a list of all lgsm sh files and check those specific files instead of all files in the modulesdir? I don't know, just spitballing here.
Author
Owner

@dgibbs64 commented on GitHub (Sep 4, 2023):

I can see how this could be a problem. Is there a specific reason why a non-linuxgsm file would be in that directory?

<!-- gh-comment-id:1705719007 --> @dgibbs64 commented on GitHub (Sep 4, 2023): I can see how this could be a problem. Is there a specific reason why a non-linuxgsm file would be in that directory?
Author
Owner

@ddan39 commented on GitHub (Sep 4, 2023):

I had opened one of the sh files with vim, which automatically created a
.swp file and then when my server went to do the scheduled restart while I
had vim left open it errored and my server stopped but didn't start back up
(another issue I reported).

On Mon, Sep 4, 2023, 5:43 PM Daniel Gibbs @.***> wrote:

I can see how this could be a problem. Is there a specific reason why a
non-linuxgsm file would be in that directory?


Reply to this email directly, view it on GitHub
https://github.com/GameServerManagers/LinuxGSM/issues/4279#issuecomment-1705719007,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIPN6LHRNL7VHICI377PQ3XYZDRNANCNFSM6AAAAAA24B7GH4
.
You are receiving this because you authored the thread.Message ID:
@.***>

<!-- gh-comment-id:1705721932 --> @ddan39 commented on GitHub (Sep 4, 2023): I had opened one of the sh files with vim, which automatically created a .swp file and then when my server went to do the scheduled restart while I had vim left open it errored and my server stopped but didn't start back up (another issue I reported). On Mon, Sep 4, 2023, 5:43 PM Daniel Gibbs ***@***.***> wrote: > I can see how this could be a problem. Is there a specific reason why a > non-linuxgsm file would be in that directory? > > — > Reply to this email directly, view it on GitHub > <https://github.com/GameServerManagers/LinuxGSM/issues/4279#issuecomment-1705719007>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAIPN6LHRNL7VHICI377PQ3XYZDRNANCNFSM6AAAAAA24B7GH4> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >
Author
Owner

@dgibbs64 commented on GitHub (Feb 28, 2024):

I have made a minor change to exclude .swp file from the permissions check 1f50055f5a
for now, I will add exceptions on a case-by-case basis.

<!-- gh-comment-id:1970002035 --> @dgibbs64 commented on GitHub (Feb 28, 2024): I have made a minor change to exclude .swp file from the permissions check 1f50055f5ac0e0bed0ea01f82f82ef4dca3deec2 for now, I will add exceptions on a case-by-case basis.
Author
Owner

@github-actions[bot] commented on GitHub (Apr 7, 2025):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

<!-- gh-comment-id:2781743428 --> @github-actions[bot] commented on GitHub (Apr 7, 2025): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Sign in to join this conversation.
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/LinuxGSM#2691
No description provided.