starred/LinuxGSM

Fork 0

mirror of https://github.com/GameServerManagers/LinuxGSM.git synced 2026-04-25 14:15:59 +03:00

[GH-ISSUE #3587] [BUG] printf invalid number error on some locale #2404

New issue

Closed

opened 2026-02-27 03:02:44 +03:00 by kerem · 5 comments

kerem commented

2026-02-27 03:02:44 +03:00

Owner

Originally created by @Marcin648 on GitHub (Oct 1, 2021).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/3587

User Story

If user use any command that use info_distro they get printf invalid number error.

Basic info

Distro: Ubuntu 20.04 (any distro)
LinuxGSM version: v20.3.1

Further Information

linuxgsm@LGSM:~/srv$ locale
LANG=pl_PL.UTF-8
LANGUAGE=pl
LC_CTYPE="pl_PL.UTF-8"
LC_NUMERIC="pl_PL.UTF-8"
LC_TIME="pl_PL.UTF-8"
LC_COLLATE="pl_PL.UTF-8"
LC_MONETARY="pl_PL.UTF-8"
LC_MESSAGES="pl_PL.UTF-8"
LC_PAPER="pl_PL.UTF-8"
LC_NAME="pl_PL.UTF-8"
LC_ADDRESS="pl_PL.UTF-8"
LC_TELEPHONE="pl_PL.UTF-8"
LC_MEASUREMENT="pl_PL.UTF-8"
LC_IDENTIFICATION="pl_PL.UTF-8"
LC_ALL=
linuxgsm@LGSM:~/srv$ ./dayzserver start
/home/linuxgsm/srv/lgsm/functions/info_distro.sh: wiersz 39: printf: 20.04: nieprawidłowa liczba
/home/linuxgsm/srv/lgsm/functions/info_distro.sh: wiersz 39: printf: 20.04: nieprawidłowa liczba
/home/linuxgsm/srv/lgsm/functions/info_distro.sh: wiersz 39: printf: 20.04: nieprawidłowa liczba
[  OK  ] Starting dayzserver: LinuxGSM

core_exit.sh exiting with code: 0

TL;DR. info_distro used printf to cut off decimal of distro version. Some countries use comma (,) instead of dot (.) for number separation and printf adjusts to that. This problem do not exist when we use standard en_US.UTF-8

few printf examples:

linuxgsm@LGSM:~/srv$ LC_NUMERIC="en_US.utf8" printf "%.0f\n" 20.04
20

linuxgsm@LGSM:~/srv$ LC_NUMERIC="pl_PL.utf8" printf "%.0f\n" 20.04
bash: printf: 20.04: nieprawidłowa liczba
20

To Reproduce

Steps to reproduce the behaviour:

Fresh install ubuntu server 20.04
Use locale that use comma as number separator. (for example Polish pl_PL.UTF-8)
Use LGSM install/start command on any game.
See error info_distro.sh: wiersz 39: printf: 20.04: nieprawidłowa liczba

Originally created by @Marcin648 on GitHub (Oct 1, 2021). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/3587 ## User Story If user use any command that use `info_distro` they get printf invalid number error. ## Basic info * **Distro:** Ubuntu 20.04 (any distro) * **LinuxGSM version:** v20.3.1 ## Further Information ``` linuxgsm@LGSM:~/srv$ locale LANG=pl_PL.UTF-8 LANGUAGE=pl LC_CTYPE="pl_PL.UTF-8" LC_NUMERIC="pl_PL.UTF-8" LC_TIME="pl_PL.UTF-8" LC_COLLATE="pl_PL.UTF-8" LC_MONETARY="pl_PL.UTF-8" LC_MESSAGES="pl_PL.UTF-8" LC_PAPER="pl_PL.UTF-8" LC_NAME="pl_PL.UTF-8" LC_ADDRESS="pl_PL.UTF-8" LC_TELEPHONE="pl_PL.UTF-8" LC_MEASUREMENT="pl_PL.UTF-8" LC_IDENTIFICATION="pl_PL.UTF-8" LC_ALL= linuxgsm@LGSM:~/srv$ ./dayzserver start /home/linuxgsm/srv/lgsm/functions/info_distro.sh: wiersz 39: printf: 20.04: nieprawidłowa liczba /home/linuxgsm/srv/lgsm/functions/info_distro.sh: wiersz 39: printf: 20.04: nieprawidłowa liczba /home/linuxgsm/srv/lgsm/functions/info_distro.sh: wiersz 39: printf: 20.04: nieprawidłowa liczba [ OK ] Starting dayzserver: LinuxGSM core_exit.sh exiting with code: 0 ``` TL;DR. info_distro used printf to cut off decimal of distro version. Some countries use comma (,) instead of dot (.) for number separation and printf adjusts to that. This problem do not exist when we use standard `en_US.UTF-8` few printf examples: ``` linuxgsm@LGSM:~/srv$ LC_NUMERIC="en_US.utf8" printf "%.0f\n" 20.04 20 ``` ``` linuxgsm@LGSM:~/srv$ LC_NUMERIC="pl_PL.utf8" printf "%.0f\n" 20.04 bash: printf: 20.04: nieprawidłowa liczba 20 ``` ## To Reproduce Steps to reproduce the behaviour: 1. Fresh install ubuntu server 20.04 2. Use locale that use comma as number separator. (for example Polish `pl_PL.UTF-8`) 3. Use LGSM install/start command on any game. 4. See error `info_distro.sh: wiersz 39: printf: 20.04: nieprawidłowa liczba`

kerem

2026-02-27 03:02:44 +03:00

closed this issue
added the
type: bug

distro: Ubuntu

command: install

command: start
labels

kerem commented

2026-02-27 03:02:44 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Oct 10, 2021):

Thanks raising this. I would never have spotted it. I always forget about the , instead of the .

@dgibbs64 commented on GitHub (Oct 10, 2021): Thanks raising this. I would never have spotted it. I always forget about the `,` instead of the `.`

kerem commented

2026-02-27 03:02:44 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Oct 10, 2021):

Not sure the best solution to this yet. It looks like we still get the correct output. so maybe just silencing the error would do it

@dgibbs64 commented on GitHub (Oct 10, 2021): Not sure the best solution to this yet. It looks like we still get the correct output. so maybe just silencing the error would do it

kerem commented

2026-02-27 03:02:44 +03:00

Author

Owner

@Marcin648 commented on GitHub (Oct 10, 2021):

I don't know if it would be better not to use printf.
The easiest way can be use LC_NUMERIC=C before command line. (full command line)

$ LC_NUMERIC=C printf "%.0f\n" "20.04"
20

... but printf have some more trap. 🙃

$ LC_NUMERIC=C printf "%.0f\n" "3.5"
4

~ $ LC_NUMERIC=C printf "%.0f\n" "10.5"
10

~ $ LC_NUMERIC=C printf "%.0f\n" "10.6"
11

Mayby regex is better?

sed -nr 's/^VERSION_ID="([0-9]*).+?"/\1/p' /etc/os-release

@Marcin648 commented on GitHub (Oct 10, 2021): I don't know if it would be better not to use printf. The easiest way can be use `LC_NUMERIC=C` before command line. (full command line) ``` $ LC_NUMERIC=C printf "%.0f\n" "20.04" 20 ``` ... but printf have some more trap. 🙃 ``` $ LC_NUMERIC=C printf "%.0f\n" "3.5" 4 ``` ``` ~ $ LC_NUMERIC=C printf "%.0f\n" "10.5" 10 ``` ``` ~ $ LC_NUMERIC=C printf "%.0f\n" "10.6" 11 ``` Mayby regex is better? ``` sed -nr 's/^VERSION_ID="([0-9]*).+?"/\1/p' /etc/os-release ```

kerem commented

2026-02-27 03:02:44 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Oct 10, 2021):

great suggestion thank you

@dgibbs64 commented on GitHub (Oct 10, 2021): great suggestion thank you

kerem commented

2026-02-27 03:02:44 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Oct 12, 2022):

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions[bot] commented on GitHub (Oct 12, 2022): This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

kerem referenced this issue

2026-02-27 03:55:14 +03:00

[PR #2404] [MERGED] Hotfix v19.8.0 #3633