mirror of
https://github.com/GameServerManagers/LinuxGSM.git
synced 2026-04-26 06:35:54 +03:00
[GH-ISSUE #3211] [BUG] Backup command fails due to bad backup.lock handling #2241
Labels
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/LinuxGSM#2241
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @StinkyMcKraken on GitHub (Feb 3, 2021).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/3211
User Story
I have discovered the LinuxGSM Backup command is not working. I run Backups once a week via crontab, my last backup was 22 days ago as of this post, on 1/11/21. Found the commit that broke it, 8 days ago,
a194f3cBasic info
Further Information
LGSM is creating backup.lock then checking to see if a backup is running. When the backup check finds the newly created backup.lock, it [INFO]s saying a backup is running and quits.
I have manually deleted backup.lock multiple times and manually run backup. Here is the output:
Additional info:
I looked at command_backup.sh on github.
fn_backup_check_lockfile happens well after fn_backup_create_lockfile
command_backup.sh lines 256-265 are as follows:
To Reproduce
Run LGSM Backup command on any LGSM install, it is not specific to any game server
Expected behaviour
maybe reorder the run functions:
@dgibbs64 commented on GitHub (Feb 3, 2021):
Thanks. This is going to be a hotfix
@h3o66 commented on GitHub (Feb 6, 2021):
Fixed with the latest release
@github-actions[bot] commented on GitHub (Feb 7, 2022):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.