mirror of
https://github.com/GameServerManagers/LinuxGSM.git
synced 2026-04-25 06:05:57 +03:00
[GH-ISSUE #3143] [BUG] [Garry's Mod] Validating server while on a different branch breaks local build version #2213
Labels
No labels
Atomic
Epic
cannot reproduce
command: backup
command: console
command: debug
command: details
command: fast-dl
command: install
command: mods
command: monitor
command: post-details
command: restart
command: send
command: start
command: stop
command: update
command: update-lgsm
command: validate
command: wipe
distro: AlmaLinux
distro: Arch Linux
distro: CentOS
distro: Debian
distro: Fedora
distro: RedHat
distro: Rocky Linux
distro: Ubuntu
distro: openSUSE
engine: goldsrc
engine: source
game: 7 Days to Die
game: ARMA 3
game: Ark: Survival Evolved
game: Assetto Corsa
game: Avorion
game: BATTALION: Legacy
game: Barotrauma
game: Battalion 1944
game: Battlefield 1942
game: Black Mesa: Deathmatch
game: Blade Symphony
game: Call of Duty 2
game: Call of Duty 4
game: Call of Duty: United Offensive
game: Counter-Strike 1.6
game: Counter-Strike 2
game: Counter-Strike: Global Offensive
game: Counter-Strike: Source
game: Day of Infamy
game: Dayz
game: Death Match Classic
game: Don't Starve Together
game: ET: Legacy
game: Eco
game: Factorio
game: Factorio
game: Garry's Mod
game: Half-Life
game: Hurtword
game: Insurgecy
game: Insurgecy
game: Insurgency: Sandstorm
game: Just Cause 3
game: Killing Floor
game: Killing Floor 2
game: Left 4 Dead 2
game: Minecraft
game: Minecraft Bedrock
game: Mordhau
game: Multi Theft Auto
game: Mumble
game: Natural Selection 2
game: No More Room in Hell
game: Pavlov VR
game: Post Scriptum
game: Project Zomboid
game: Quake 3
game: QuakeWorld
game: Red Orchestra: Ostfront 41-45
game: Return to Castle Wolfenstein
game: Rising World
game: Rust
game: San Andreas Multiplayer
game: Satisfactory
game: Soldat
game: Soldier of Fortune 2
game: Squad
game: Squad 44
game: Starbound
game: Stationeers
game: Sven Co-op
game: Team Fortress 2
game: Teamspeak 3
game: Teeworlds
game: Terraria
game: The Front
game: Unreal Tournament 2004
game: Unreal Tournament 3
game: Unreal Tournament 99
game: Unturned
game: Valheim
game: Wurm Unlimited
game: Zombie Master Reborn
game: label missing
good first issue
help wanted
info: alerts
info: dependency
info: docker
info: docs
info: email
info: query
info: steamcmd
info: systemd
info: tmux
info: website
info: website
needs more info
outcome: duplicate
outcome: issue resolved
outcome: issue resolved
outcome: issue unresolved
outcome: pr accepted
outcome: pr rejected
outcome: unconfirmed
outcome: wontfix
outcome: wrong forum
potential-duplicate
priority
pull-request
type: bug
type: feature
type: feature
type: feature request
type: game server request
type: refactor
waiting response
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/LinuxGSM#2213
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @peter-r-g on GitHub (Dec 25, 2020).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/3143
Basic info
Further Information
To actually get LinuxGSM to update to the x86-64 branch for testing I used the fix from #3139. Although it doesn't matter if you use the regular 20.6.2 version of LinuxGSM for this problem to arise.
To Reproduce
Steps to reproduce the behaviour:
The local build number will always be the same as the x86-64 branch number and using the update or validate commands won't change it.
Expected behaviour
The local build number to change so that LinuxGSM doesn't think it always has to update the server.
@peter-r-g commented on GitHub (Dec 25, 2020):
Upon further inspection I've noticed that SteamCMD doesn't update the BuildID (that I assume LinuxGSM uses) found in serverfiles/steamapps/appmanifest_4020.acf because the x86-64 branch does not seem to change any files. Only add some, I suppose this can't be worked around in LinuxGSM?
@h3o66 commented on GitHub (Dec 25, 2020):
so with the following command I get different build ids that should be not a problem to change this with a validate command:
steamcmd +app_info_update 1 +app_info_print 4020 +quit | sed -e '/"branches"/,/^}/!d'Public: 5956225
x86-64: 5956258
@peter-r-g commented on GitHub (Dec 25, 2020):
Validating does not change the local build, it stays at 5956258.
@h3o66 commented on GitHub (Dec 26, 2020):
Afaik if the buildid is lower than the last buildid, the files need to be vaidated by the steamcmd
@h3o66 commented on GitHub (Dec 26, 2020):
Well, can preproduce this issue with a vaidate, but i guess this is then not a lgsm issue, more specifc a issue with the steamcmd
@peter-r-g commented on GitHub (Dec 29, 2020):
I ended up trying to edit the app manifest directly to change the build ID and beta branch but it was still somehow reporting the x86-64 build ID. Is LinuxGSM saving the build ID somewhere else? The only solution I could get was to delete everything in the serverfiles directory and install LinuxGSM again.
I also was looking through and comparing the files between the public and x86-64 branches to find that there are a bunch of differences between them. Yet SteamCMD would say that everything is already up to date, as if it's comparing the files to the x86-64 branch rather than the default public branch like LinuxGSM is reporting that it's comparing to.
@JimTR commented on GitHub (Jan 1, 2021):
I hit this a while ago with a project I'm doing ..
and the fix is to delete the manifest file "serverfiles/steamapps/appmanifest_.acf"
e.g gmod would be like "/home/user/games/gmod/serverfiles/steamapps/appmanifest_4020.acf"
then re run validation on the install with the correct branch, from the command line it would be like
"steamcmd +login anonymous +force_install_dir /home/user/games/gmod/serverfiles +app_update 4020 -beta x86-64 validate +quit".
of course to return to public remove the -beta from the command so
"steamcmd +login anonymous +force_install_dir /home/user/games/gmod/serverfiles +app_update 4020 validate +quit" but I guess the LGSM validate command will do this for you.
the key here is to remove the manifest file before you revalidate the install. my guess is one of the other entries in the acf file governs this or steamcmd does not update the data in the acf file correctly on validation
@JimTR commented on GitHub (Jan 1, 2021):
Just tried using LGSM to validate .. it works as long as you check that the numerous config files do not contain a line "branch='currentbranch'".
as a side note LGSM appeared to be slow to validate this appeared to be down to somewhere in LGSM code there is a call to Tee which in turn opened up other tasks (/usr/bin/unbuffer) on Ubuntu 20.04
@h3o66 commented on GitHub (Jan 9, 2021):
Can someone please test with the fix from the PR ?
@github-actions[bot] commented on GitHub (Jan 29, 2022):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.