[GH-ISSUE #3060] Permissions edge-case during updates #2167

New issue

Open

opened 2026-02-27 03:01:16 +03:00 by kerem · 3 comments

kerem commented

2026-02-27 03:01:16 +03:00

Owner

Originally created by @grandprixgp on GitHub (Sep 29, 2020).
Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/3060

User Story

If you don't have permissions over the $rootdir folder itself, but only the relevant contents of $rootdir, updates will fail because sed attempts to drop temporary files into this folder. In addition to this, when an update fails at this section, the backup previously made is not restored to $rootdir which causes the gameserver.sh to report an invalid gameserver:

[ FAIL ] unknown game server

Basic info

Distro: All
Game: N/A
Command: update
LinuxGSM version: <= v20.5.0

Further Information

The bug occurs because we don't utilize $tmpdir to sed our changes, additionally we do not restore the backup previously created here.

To Reproduce

Steps to reproduce the behaviour:

Set permissions such that you have the required permissions for all LGSM files and folders but not the root directory itself.
Launch an update
gameserver.sh becomes invalid and update fails.

Expected behaviour

At the very least the backup should be restored in this case, but it is trivial to remove the case entirely by utilizing the $tmpdir rather than the $rootdir for sed changes.

Originally created by @grandprixgp on GitHub (Sep 29, 2020). Original GitHub issue: https://github.com/GameServerManagers/LinuxGSM/issues/3060 ## User Story If you don't have permissions over the `$rootdir` folder itself, but only the relevant contents of `$rootdir`, updates will fail because `sed` attempts to drop temporary files into this folder. In addition to this, when an update fails at this section, the backup previously made is not restored to `$rootdir` which causes the `gameserver.sh` to report an invalid gameserver: `[ FAIL ] unknown game server` ## Basic info * **Distro:** All * **Game:** N/A * **Command:** update * **LinuxGSM version:** <= v20.5.0 ## Further Information The bug occurs because we don't utilize `$tmpdir` to `sed` our changes, additionally we do not restore the backup previously created [here](https://github.com/GameServerManagers/LinuxGSM/blob/v20.5.0/lgsm/functions/command_update_linuxgsm.sh#L80). ## To Reproduce Steps to reproduce the behaviour: 1. Set permissions such that you have the required permissions for all LGSM files and folders but not the root directory itself. 2. Launch an update 3. `gameserver.sh` becomes invalid and update fails. ## Expected behaviour At the very least the backup should be restored in this case, but it is trivial to remove the case entirely by utilizing the `$tmpdir` rather than the `$rootdir` for `sed` changes.

kerem added the

type: bug

label

2026-02-27 03:01:16 +03:00

kerem commented

2026-02-27 03:01:17 +03:00

Author

Owner

@issue-label-bot[bot] commented on GitHub (Sep 29, 2020):

Issue-Label Bot is automatically applying the label type: bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot[bot] commented on GitHub (Sep 29, 2020): Issue-Label Bot is automatically applying the label `type: bug` to this issue, with a confidence of 0.94. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/GameServerManagers/LinuxGSM) and [code](https://github.com/hamelsmu/MLapp) for this bot.

kerem commented

2026-02-27 03:01:17 +03:00

Author

Owner

@dgibbs64 commented on GitHub (Sep 29, 2020):

Why would someone not have permissions to the rootdir?

@dgibbs64 commented on GitHub (Sep 29, 2020): Why would someone not have permissions to the rootdir?

kerem commented

2026-02-27 03:01:17 +03:00

Author

Owner

@grandprixgp commented on GitHub (Sep 29, 2020):

In my case it's a side effect of migrating permissions while maintaining the original directory structure, I don't want to grant permissions on $rootdir. However it is a very niche situation and would be fixed by spending the time to properly migrate. Still, this being such a trivial fix (and I believe backup should be restored regardless, no?) I'd argue its worth implementing.

@grandprixgp commented on GitHub (Sep 29, 2020): In my case it's a side effect of migrating permissions while maintaining the original directory structure, I don't want to grant permissions on `$rootdir`. However it is a very niche situation and would be fixed by spending the time to properly migrate. Still, this being such a trivial fix (and I believe backup should be restored regardless, no?) I'd argue its worth implementing.